Uh oh!
There was an error while loading. Please reload this page.
Promote warnings to exceptions in ext/soap and ext/xmlwriter - #5998
Promote warnings to exceptions in ext/soap and ext/xmlwriter#5998kocsismate wants to merge 2 commits into
Conversation
e03c2f9 to
17afddbCompareThere was a problem hiding this comment.
As far as I see, this PR will eliminate a few cases when a constructor returned null... :)
df10d30 to
955f289CompareThere was a problem hiding this comment.
I have to wonder wtf UNLIMATERECEIVER is supposed to mean...
There was a problem hiding this comment.
:D Do you also suppose it's "ultimate receiver"? As far as I see, Google shows quite some hits for "soap ultimate receiver" :D
There was a problem hiding this comment.
This error message is a bit misleading, in that it implies that it accepts arbitrary callbacks (not just global functions).
There was a problem hiding this comment.
Changed it to "must be a valid function name", if that's ok for you
There was a problem hiding this comment.
Shouldn't there be one more else below to handle a completely invalid type?
There was a problem hiding this comment.
Yeah, I missed that, thanks!
| php_error_docref(NULL, E_WARNING, "Tried to add a non existent function '%s'", Z_STRVAL_P(tmp_function)); | ||
| zend_type_error("SoapServer::addFunction(): Function \"%s\" not found", Z_STRVAL_P(tmp_function)); | ||
| RETURN_THROWS(); | ||
| return; |
No description provided.