Skip to content

Promote warnings to exceptions in ext/pcntl - #6004

Closed
kocsismate wants to merge 2 commits into
php:masterfrom
kocsismate:pcntl-warning
Closed

Promote warnings to exceptions in ext/pcntl#6004
kocsismate wants to merge 2 commits into
php:masterfrom
kocsismate:pcntl-warning

Conversation

@kocsismate

@kocsismatekocsismate commented Aug 17, 2020

Copy link
Copy Markdown
Member

No description provided.

@kocsismate
kocsismateforce-pushed the pcntl-warning branch 2 times, most recently from 9f2a1d7 to 4bb2cb6CompareAugust 17, 2020 20:41
kocsismate
kocsismate commented Aug 17, 2020
View reviewed changes
Comment threadext/pcntl/pcntl.c Outdated
@GirgiasGirgias mentioned this pull request Aug 17, 2020
Closed
71 tasks
nikic
nikic reviewed Aug 24, 2020
View reviewed changes
Comment threadext/pcntl/pcntl.c Outdated
Comment threadext/pcntl/pcntl.c Outdated
Comment threadext/pcntl/pcntl.c Outdated
Comment threadext/pcntl/pcntl.stub.php Outdated
Comment threadext/pcntl/pcntl.c Outdated
nikic
nikic approved these changes Aug 25, 2020
View reviewed changes
Comment threadext/pcntl/pcntl.c
@kocsismate
kocsismate deleted the pcntl-warning branch August 25, 2020 11:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@nikicnikicnikic approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Warning promotion

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kocsismate@nikic