Skip to content

Promote warnings to exceptions in ext/gd - #6023

Closed
kocsismate wants to merge 1 commit into
php:masterfrom
kocsismate:gd-warning
Closed

Promote warnings to exceptions in ext/gd#6023
kocsismate wants to merge 1 commit into
php:masterfrom
kocsismate:gd-warning

Conversation

@kocsismate

Copy link
Copy Markdown
Member

No description provided.

@cmb69cmb69 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! I'm fine with these changes, but I can imagine that calls to imagecolormatch() may now break some scripts; formerly, calling imagecolormatch() on unsuitable images would have basically been a NOP, but now it would error. Well, fixing such programmer errors would be long overdue anyways. :)

@kocsismate
kocsismate deleted the gd-warning branch August 20, 2020 10:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@kocsismate@cmb69