Uh oh!
There was an error while loading. Please reload this page.
Promote warnings to exceptions in ext/ftp - #6054
Closed
kocsismate wants to merge 3 commits into
Closed
Conversation
71 tasks
nikic
commented
Aug 31, 2020
Member
Test failures look legit. |
nikic
commented
Aug 31, 2020
Member
Still failing :) |
kocsismate
commented
Aug 31, 2020
MemberAuthor
Noo way :( Sorry for the noise. it should be good after my newest commit. |
nikic
approved these changes
Aug 31, 2020
nikic
left a comment
Member
There was a problem hiding this comment.
It would be nice to get rid of the trailing . in the other FTP error messages as well...
MemberAuthor
@nikic Yeah, I noticed them, but then I realized that this message is only defined in the tests ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.