Uh oh!
There was an error while loading. Please reload this page.
Promote warnings to exceptions in ext/ldap - #6065
Closed
kocsismate wants to merge 2 commits into
Closed
Conversation
MCMic
commented
Sep 3, 2020
Contributor
Calls to zend_zval_type_name with no attribute seems to cause build errors. The changes on themselves seems fine apart from this. |
kocsismateforce-pushed
the
ldap-warning
branch
from
September 3, 2020 13:24
61a88cf to
f32ed9dComparekocsismate
commented
Sep 3, 2020
MemberAuthor
@MCMic Thanks for the review! I've just fixed the build (hopefully), and I'm going to fix the tests now. |
cmb69
commented
Sep 3, 2020
Member
@koksismate, please rebase to get rid of the Windows build error. |
kocsismateforce-pushed
the
ldap-warning
branch
from
September 3, 2020 14:21
f32ed9d to
d5a8b6bComparekocsismateforce-pushed
the
ldap-warning
branch
from
September 3, 2020 15:07
d5a8b6b to
8c3f4ffComparekocsismate
marked this pull request as ready for review
September 3, 2020 15:30
nikic
reviewed
Sep 4, 2020
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.