Uh oh!
There was an error while loading. Please reload this page.
Promote warnings to Error in SNMP extension - #6124
Conversation
982b362 to
dcc0b41CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Is there an existing function instead of zval_get_long() which behaves more consistently with usual ZPP rules? E.g. won't return 0 or 1 in case of an array new_zval, depending on if it is empty or not. :D
otherwise, I would say something like Property SNMP::$max_oids must be greater than 0. AFAIR, null is neither mentioned explicitly in case of nullable parameters in similar situations (e.g. shm_attach()).
There was a problem hiding this comment.
I don't think there is, but NULL is handled explicitly above, and as this is a property hook I have no clue about a better approach for handling the type.
There was a problem hiding this comment.
This looks okay to me, but possibly lowercase null would be more common now?
Uh oh!
There was an error while loading. Please reload this page.
8760c06 to
745465aCompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
This looks okay to me, but possibly lowercase null would be more common now?
Uh oh!
There was an error while loading. Please reload this page.
7831901 to
777a00fCompareThere was a problem hiding this comment.
Here again, some of these var_dumps should be outside the try/catch.
777a00f to
62c20c6Compare
No description provided.