Uh oh!
There was an error while loading. Please reload this page.
Promote warnings to Error in IMAP - #6164
Conversation
ce0c983 to
ce5e858CompareUh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
How do you determine which options are valid for which function?
There was a problem hiding this comment.
I pulled them from the PHP.net documentation, as I would expect the options which are documented there to work.
There was a problem hiding this comment.
The question then is whether imap_reopen only lists part of the flags because the rest are not supported, or because only the imap_open docs were updated ^^
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ce5e858 to
a6acaa3Compare| *** Testing imap_fetch_overview() : usage variations *** | ||
| Create a temporary mailbox and add 1 msgs | ||
| .. mailbox '{%s}%s' created | ||
| .. mailbox '{127.0.0.1:143/norsh}INBOX.phpttest' created |
| *** Testing imap_fetchbody() : usage variations *** | ||
| Create a temporary mailbox and add 1 msgs | ||
| .. mailbox '{%s}%s' created | ||
| .. mailbox '{127.0.0.1:143/norsh}INBOX.phpttest' created |
| *** Testing imap_fetchheader() : usage variations *** | ||
| Create a temporary mailbox and add 1 msgs | ||
| .. mailbox '{%s}%s' created | ||
| .. mailbox '{127.0.0.1:143/norsh}INBOX.phpttest' created |
There was a problem hiding this comment.
The question then is whether imap_reopen only lists part of the flags because the rest are not supported, or because only the imap_open docs were updated ^^
| body = mail_fetchtext_full (imap_le_struct->imap_stream, msgno, &body_len, (argc == 3 ? flags : NIL)); | ||
| PHP_IMAP_CHECK_MSGNO(msgindex, 2); | ||
| /* TODO Shouldn't this pass msgindex??? */ |
| PHP_IMAP_CHECK_MSGNO(msgno, 2); | ||
| if (fromlength < 0 || fromlength > MAILTMPLEN) { | ||
| RETURN_THROWS(); |
Discovered several potential bug and integer overflows.