Promote E_NOTICE to Error in PostgreSQL extension

[Girgias]

Some of these are obvious type/value errors which is surprising they were classified as E_NOTICE...

And because it is PGSQL none of these conditions are tested :-)

[nikic]

And because it is PGSQL none of these conditions are tested :-)

We should add some (representative) tests then ^

[nikic]

While you're here, indent this block one level?

[nikic]

No, this code is there to handle integer strings larger than zend_long. is_numeric_string would convert those to floats, which defeats the purpose of this code.

[Girgias]

Right, but this code is lot, so maybe make it a dedicated function in the future?

[nikic]

Oh sure, we should extract the common pgsql code (later...)

[nikic]

Nah, at least going by the message, this is an issue with the environment...

[nikic]

Same here, this block is missing an indent.

[nikic]

Suggested change

	zend_value_error("Array of values must be an associated array of string keys");
	zend_value_error("Array of values must be an associative array with string keys");

[nikic]

Suggested change

	zend_value_error("Array of values must be an associative array of string keys");
	zend_value_error("Array of values must be an associative array with string keys");