Convert resources to objects in ext/ldap

[kocsismate]

No description provided.

[Girgias]

Cursory look and it looks fine, but I'm far from the expert there.

[kocsismate]

@MCMic your review is welcome :)

[nikic]

This looks reasonable to me.

[nikic]

Just to throw it out there, maybe make it LDAPConnection?

[kocsismate]

Yeah, that's also a possibility. I chose LDAP because I thought it's more consistent with other extensions: e.g. with mysqli, PDO classes. But I've just found out that we now have FTPConnection, and we also chose CurlHandle.. So I'm not sure what to do here. But I'm open to change it to LDAPConnection.

[nikic]

LGTM, but maybe wait a bit in case @MCMic has some comments.

[kocsismate]

@MCMic I've just applied these changes, but I can do some amendments if you find anything that should be changed.

[MCMic]

Hello @nikic@kocsismate sorry for the delay.

Thank you for the work on php-ldap.

Has the ship sailed for using a common namespace for the 3 classes?

I’m fine with the name LDAP given the parameter name is always $ldap it’s consistent. (if we kept $link it would’ve been LDAPLink)

Is it expected that the LDAP object has no properties and would it make sense to add some (like the parameters passed to ldap_connect) ?

Am I right to consider that this is a step towards adding an object oriented interface or is that not a goal? If we do so, would it be acceptable to add methods which are not direct aliases on existing functions, to fix inconsistencies, and for example removing the _ext suffix to have only LDAP::bind working like ldap_bind_ext($ldap)?
And I suppose an easy first step would be to add LDAP::__construct mapping to ldap_connect()?

[kocsismate]

Has the ship sailed for using a common namespace for the 3 classes?

I think the ship has not even started, since doing so would need https://wiki.php.net/rfc/namespaces_in_bundled_extensions first.

Am I right to consider that this is a step towards adding an object oriented interface or is that not a goal?

My main goal is to get rid of as many resource type hints as possible, but yes, the resource to object migration initiative serves as a great potential to add better OO interfaces. Personally, I would be very happy if we moved towards OO APIs. So it makes sense for me to add properties as well as new methods to the newly introduced LDAP classes.

And I suppose an easy first step would be to add LDAP::__construct mapping to ldap_connect()?

Yes, I believe so.