Implement mysqli_fetch_column by kamil-tekiela · Pull Request #6798 · php/php-src

kamil-tekiela · 2021-03-22T23:51:53Z

This is WIP but I am looking for suggestions to improve.

Is mixed better than null|int|string|false?
How to avoid temporary zval?

This should work almost exactly the same as PDO fetchColumn with the only difference that MySQL doesn't have a boolean type so the function can never return true (it will return false if no more rows are available).

cmb69 · 2021-03-30T12:17:05Z

Accompanying RFC: https://wiki.php.net/rfc/mysqli_fetch_column

nikic · 2021-04-14T08:34:39Z


 function mysqli_fetch_row(mysqli_result $result): array|null|false {}

+function mysqli_fetch_column(mysqli_result $result, int $column = 0): null|int|string|false {}


Can't it also return float in INT_AND_FLOAT native mode?

nikic

Looks good (assuming RFC accepted)

While only the method is mentioned in the RFC and the Migration guide, a procedural version of the same was also implemented. Includes unit tests. Refs: * https://www.php.net/manual/en/migration81.new-features.php#migration81.new-features.mysqli.mysqli_fetch_column * https://wiki.php.net/rfc/mysqli_fetch_column * php/php-src#6798 * php/php-src@54222a6

(mentioned in new features, but not in the new functions list) > `mysqli_result::fetch_column()` has been added to allow fetching a single scalar value from the result set. While only the method is mentioned in the RFC and the Migration guide, a procedural version of the same was also implemented. Refs: * https://www.php.net/manual/en/migration81.new-features.php#migration81.new-features.mysqli.mysqli_fetch_column * https://wiki.php.net/rfc/mysqli_fetch_column * php/php-src#6798 * php/php-src@54222a6

* PHP 8.1 | MigrationGuide/New functions: add missing functions [1] (mentioned in new features, but not in the new functions list) > GD: > * Avif support is now available through the `imagecreatefromavif()` and > `imageavif()` functions, if libgd has been built with avif support. Refs: * https://github.com/php/php-src/blob/f67986a9218f4889d9352a87c29337a5b6eaa4bd/UPGRADING#L245-L247 * php/php-src#7026 * php/php-src@81f6d36 * PHP 8.1 | MigrationGuide/New functions: add missing functions [2] (mentioned in new features, but not in the new functions list) > `mysqli_result::fetch_column()` has been added to allow fetching a single scalar value from the result set. While only the method is mentioned in the RFC and the Migration guide, a procedural version of the same was also implemented. Refs: * https://www.php.net/manual/en/migration81.new-features.php#migration81.new-features.mysqli.mysqli_fetch_column * https://wiki.php.net/rfc/mysqli_fetch_column * php/php-src#6798 * php/php-src@54222a6 Co-authored-by: jrfnl <jrfnl@users.noreply.github.com> ClosesGH-1448.

* PHP 8.1 | MigrationGuide/New functions: add missing functions [1] (mentioned in new features, but not in the new functions list) > GD: > * Avif support is now available through the `imagecreatefromavif()` and > `imageavif()` functions, if libgd has been built with avif support. Refs: * https://github.com/php/php-src/blob/f67986a9218f4889d9352a87c29337a5b6eaa4bd/UPGRADING#L245-L247 * php/php-src#7026 * php/php-src@81f6d36 * PHP 8.1 | MigrationGuide/New functions: add missing functions [2] (mentioned in new features, but not in the new functions list) > `mysqli_result::fetch_column()` has been added to allow fetching a single scalar value from the result set. While only the method is mentioned in the RFC and the Migration guide, a procedural version of the same was also implemented. Refs: * https://www.php.net/manual/en/migration81.new-features.php#migration81.new-features.mysqli.mysqli_fetch_column * https://wiki.php.net/rfc/mysqli_fetch_column * php/php-src#6798 * php/php-src@54222a6 Co-authored-by: jrfnl <jrfnl@users.noreply.github.com> ClosesphpGH-1448.

kamil-tekiela · 2021-03-22T23:51:53Z

This is WIP but I am looking for suggestions to improve.

Is mixed better than null|int|string|false?
How to avoid temporary zval?

This should work almost exactly the same as PDO fetchColumn with the only difference that MySQL doesn't have a boolean type so the function can never return true (it will return false if no more rows are available).

cmb69 · 2021-03-30T12:17:05Z

Accompanying RFC: https://wiki.php.net/rfc/mysqli_fetch_column

nikic · 2021-04-14T08:34:39Z


 function mysqli_fetch_row(mysqli_result $result): array|null|false {}

+function mysqli_fetch_column(mysqli_result $result, int $column = 0): null|int|string|false {}


Can't it also return float in INT_AND_FLOAT native mode?

nikic

Looks good (assuming RFC accepted)

While only the method is mentioned in the RFC and the Migration guide, a procedural version of the same was also implemented. Includes unit tests. Refs: * https://www.php.net/manual/en/migration81.new-features.php#migration81.new-features.mysqli.mysqli_fetch_column * https://wiki.php.net/rfc/mysqli_fetch_column * php/php-src#6798 * php/php-src@54222a6

(mentioned in new features, but not in the new functions list) > `mysqli_result::fetch_column()` has been added to allow fetching a single scalar value from the result set. While only the method is mentioned in the RFC and the Migration guide, a procedural version of the same was also implemented. Refs: * https://www.php.net/manual/en/migration81.new-features.php#migration81.new-features.mysqli.mysqli_fetch_column * https://wiki.php.net/rfc/mysqli_fetch_column * php/php-src#6798 * php/php-src@54222a6

* PHP 8.1 | MigrationGuide/New functions: add missing functions [1] (mentioned in new features, but not in the new functions list) > GD: > * Avif support is now available through the `imagecreatefromavif()` and > `imageavif()` functions, if libgd has been built with avif support. Refs: * https://github.com/php/php-src/blob/f67986a9218f4889d9352a87c29337a5b6eaa4bd/UPGRADING#L245-L247 * php/php-src#7026 * php/php-src@81f6d36 * PHP 8.1 | MigrationGuide/New functions: add missing functions [2] (mentioned in new features, but not in the new functions list) > `mysqli_result::fetch_column()` has been added to allow fetching a single scalar value from the result set. While only the method is mentioned in the RFC and the Migration guide, a procedural version of the same was also implemented. Refs: * https://www.php.net/manual/en/migration81.new-features.php#migration81.new-features.mysqli.mysqli_fetch_column * https://wiki.php.net/rfc/mysqli_fetch_column * php/php-src#6798 * php/php-src@54222a6 Co-authored-by: jrfnl <jrfnl@users.noreply.github.com> ClosesGH-1448.

* PHP 8.1 | MigrationGuide/New functions: add missing functions [1] (mentioned in new features, but not in the new functions list) > GD: > * Avif support is now available through the `imagecreatefromavif()` and > `imageavif()` functions, if libgd has been built with avif support. Refs: * https://github.com/php/php-src/blob/f67986a9218f4889d9352a87c29337a5b6eaa4bd/UPGRADING#L245-L247 * php/php-src#7026 * php/php-src@81f6d36 * PHP 8.1 | MigrationGuide/New functions: add missing functions [2] (mentioned in new features, but not in the new functions list) > `mysqli_result::fetch_column()` has been added to allow fetching a single scalar value from the result set. While only the method is mentioned in the RFC and the Migration guide, a procedural version of the same was also implemented. Refs: * https://www.php.net/manual/en/migration81.new-features.php#migration81.new-features.mysqli.mysqli_fetch_column * https://wiki.php.net/rfc/mysqli_fetch_column * php/php-src#6798 * php/php-src@54222a6 Co-authored-by: jrfnl <jrfnl@users.noreply.github.com> ClosesphpGH-1448.

kamil-tekiela · 2021-03-22T23:51:53Z

This is WIP but I am looking for suggestions to improve.

Is mixed better than null|int|string|false?
How to avoid temporary zval?

This should work almost exactly the same as PDO fetchColumn with the only difference that MySQL doesn't have a boolean type so the function can never return true (it will return false if no more rows are available).

cmb69 · 2021-03-30T12:17:05Z

Accompanying RFC: https://wiki.php.net/rfc/mysqli_fetch_column

nikic · 2021-04-14T08:34:39Z


 function mysqli_fetch_row(mysqli_result $result): array|null|false {}

+function mysqli_fetch_column(mysqli_result $result, int $column = 0): null|int|string|false {}


Can't it also return float in INT_AND_FLOAT native mode?

nikic

Looks good (assuming RFC accepted)

While only the method is mentioned in the RFC and the Migration guide, a procedural version of the same was also implemented. Includes unit tests. Refs: * https://www.php.net/manual/en/migration81.new-features.php#migration81.new-features.mysqli.mysqli_fetch_column * https://wiki.php.net/rfc/mysqli_fetch_column * php/php-src#6798 * php/php-src@54222a6

(mentioned in new features, but not in the new functions list) > `mysqli_result::fetch_column()` has been added to allow fetching a single scalar value from the result set. While only the method is mentioned in the RFC and the Migration guide, a procedural version of the same was also implemented. Refs: * https://www.php.net/manual/en/migration81.new-features.php#migration81.new-features.mysqli.mysqli_fetch_column * https://wiki.php.net/rfc/mysqli_fetch_column * php/php-src#6798 * php/php-src@54222a6

* PHP 8.1 | MigrationGuide/New functions: add missing functions [1] (mentioned in new features, but not in the new functions list) > GD: > * Avif support is now available through the `imagecreatefromavif()` and > `imageavif()` functions, if libgd has been built with avif support. Refs: * https://github.com/php/php-src/blob/f67986a9218f4889d9352a87c29337a5b6eaa4bd/UPGRADING#L245-L247 * php/php-src#7026 * php/php-src@81f6d36 * PHP 8.1 | MigrationGuide/New functions: add missing functions [2] (mentioned in new features, but not in the new functions list) > `mysqli_result::fetch_column()` has been added to allow fetching a single scalar value from the result set. While only the method is mentioned in the RFC and the Migration guide, a procedural version of the same was also implemented. Refs: * https://www.php.net/manual/en/migration81.new-features.php#migration81.new-features.mysqli.mysqli_fetch_column * https://wiki.php.net/rfc/mysqli_fetch_column * php/php-src#6798 * php/php-src@54222a6 Co-authored-by: jrfnl <jrfnl@users.noreply.github.com> ClosesGH-1448.

* PHP 8.1 | MigrationGuide/New functions: add missing functions [1] (mentioned in new features, but not in the new functions list) > GD: > * Avif support is now available through the `imagecreatefromavif()` and > `imageavif()` functions, if libgd has been built with avif support. Refs: * https://github.com/php/php-src/blob/f67986a9218f4889d9352a87c29337a5b6eaa4bd/UPGRADING#L245-L247 * php/php-src#7026 * php/php-src@81f6d36 * PHP 8.1 | MigrationGuide/New functions: add missing functions [2] (mentioned in new features, but not in the new functions list) > `mysqli_result::fetch_column()` has been added to allow fetching a single scalar value from the result set. While only the method is mentioned in the RFC and the Migration guide, a procedural version of the same was also implemented. Refs: * https://www.php.net/manual/en/migration81.new-features.php#migration81.new-features.mysqli.mysqli_fetch_column * https://wiki.php.net/rfc/mysqli_fetch_column * php/php-src#6798 * php/php-src@54222a6 Co-authored-by: jrfnl <jrfnl@users.noreply.github.com> ClosesphpGH-1448.

kamil-tekiela · 2021-03-22T23:51:53Z

This is WIP but I am looking for suggestions to improve.

Is mixed better than null|int|string|false?
How to avoid temporary zval?

This should work almost exactly the same as PDO fetchColumn with the only difference that MySQL doesn't have a boolean type so the function can never return true (it will return false if no more rows are available).

cmb69 · 2021-03-30T12:17:05Z

Accompanying RFC: https://wiki.php.net/rfc/mysqli_fetch_column

nikic · 2021-04-14T08:34:39Z


 function mysqli_fetch_row(mysqli_result $result): array|null|false {}

+function mysqli_fetch_column(mysqli_result $result, int $column = 0): null|int|string|false {}


Can't it also return float in INT_AND_FLOAT native mode?

nikic

Looks good (assuming RFC accepted)

While only the method is mentioned in the RFC and the Migration guide, a procedural version of the same was also implemented. Includes unit tests. Refs: * https://www.php.net/manual/en/migration81.new-features.php#migration81.new-features.mysqli.mysqli_fetch_column * https://wiki.php.net/rfc/mysqli_fetch_column * php/php-src#6798 * php/php-src@54222a6

(mentioned in new features, but not in the new functions list) > `mysqli_result::fetch_column()` has been added to allow fetching a single scalar value from the result set. While only the method is mentioned in the RFC and the Migration guide, a procedural version of the same was also implemented. Refs: * https://www.php.net/manual/en/migration81.new-features.php#migration81.new-features.mysqli.mysqli_fetch_column * https://wiki.php.net/rfc/mysqli_fetch_column * php/php-src#6798 * php/php-src@54222a6

* PHP 8.1 | MigrationGuide/New functions: add missing functions [1] (mentioned in new features, but not in the new functions list) > GD: > * Avif support is now available through the `imagecreatefromavif()` and > `imageavif()` functions, if libgd has been built with avif support. Refs: * https://github.com/php/php-src/blob/f67986a9218f4889d9352a87c29337a5b6eaa4bd/UPGRADING#L245-L247 * php/php-src#7026 * php/php-src@81f6d36 * PHP 8.1 | MigrationGuide/New functions: add missing functions [2] (mentioned in new features, but not in the new functions list) > `mysqli_result::fetch_column()` has been added to allow fetching a single scalar value from the result set. While only the method is mentioned in the RFC and the Migration guide, a procedural version of the same was also implemented. Refs: * https://www.php.net/manual/en/migration81.new-features.php#migration81.new-features.mysqli.mysqli_fetch_column * https://wiki.php.net/rfc/mysqli_fetch_column * php/php-src#6798 * php/php-src@54222a6 Co-authored-by: jrfnl <jrfnl@users.noreply.github.com> ClosesGH-1448.

* PHP 8.1 | MigrationGuide/New functions: add missing functions [1] (mentioned in new features, but not in the new functions list) > GD: > * Avif support is now available through the `imagecreatefromavif()` and > `imageavif()` functions, if libgd has been built with avif support. Refs: * https://github.com/php/php-src/blob/f67986a9218f4889d9352a87c29337a5b6eaa4bd/UPGRADING#L245-L247 * php/php-src#7026 * php/php-src@81f6d36 * PHP 8.1 | MigrationGuide/New functions: add missing functions [2] (mentioned in new features, but not in the new functions list) > `mysqli_result::fetch_column()` has been added to allow fetching a single scalar value from the result set. While only the method is mentioned in the RFC and the Migration guide, a procedural version of the same was also implemented. Refs: * https://www.php.net/manual/en/migration81.new-features.php#migration81.new-features.mysqli.mysqli_fetch_column * https://wiki.php.net/rfc/mysqli_fetch_column * php/php-src#6798 * php/php-src@54222a6 Co-authored-by: jrfnl <jrfnl@users.noreply.github.com> ClosesphpGH-1448.

kamil-tekiela · 2021-03-22T23:51:53Z

This is WIP but I am looking for suggestions to improve.

Is mixed better than null|int|string|false?
How to avoid temporary zval?

This should work almost exactly the same as PDO fetchColumn with the only difference that MySQL doesn't have a boolean type so the function can never return true (it will return false if no more rows are available).

cmb69 · 2021-03-30T12:17:05Z

Accompanying RFC: https://wiki.php.net/rfc/mysqli_fetch_column

nikic · 2021-04-14T08:34:39Z


 function mysqli_fetch_row(mysqli_result $result): array|null|false {}

+function mysqli_fetch_column(mysqli_result $result, int $column = 0): null|int|string|false {}


Can't it also return float in INT_AND_FLOAT native mode?

nikic

Looks good (assuming RFC accepted)

While only the method is mentioned in the RFC and the Migration guide, a procedural version of the same was also implemented. Includes unit tests. Refs: * https://www.php.net/manual/en/migration81.new-features.php#migration81.new-features.mysqli.mysqli_fetch_column * https://wiki.php.net/rfc/mysqli_fetch_column * php/php-src#6798 * php/php-src@54222a6

(mentioned in new features, but not in the new functions list) > `mysqli_result::fetch_column()` has been added to allow fetching a single scalar value from the result set. While only the method is mentioned in the RFC and the Migration guide, a procedural version of the same was also implemented. Refs: * https://www.php.net/manual/en/migration81.new-features.php#migration81.new-features.mysqli.mysqli_fetch_column * https://wiki.php.net/rfc/mysqli_fetch_column * php/php-src#6798 * php/php-src@54222a6

* PHP 8.1 | MigrationGuide/New functions: add missing functions [1] (mentioned in new features, but not in the new functions list) > GD: > * Avif support is now available through the `imagecreatefromavif()` and > `imageavif()` functions, if libgd has been built with avif support. Refs: * https://github.com/php/php-src/blob/f67986a9218f4889d9352a87c29337a5b6eaa4bd/UPGRADING#L245-L247 * php/php-src#7026 * php/php-src@81f6d36 * PHP 8.1 | MigrationGuide/New functions: add missing functions [2] (mentioned in new features, but not in the new functions list) > `mysqli_result::fetch_column()` has been added to allow fetching a single scalar value from the result set. While only the method is mentioned in the RFC and the Migration guide, a procedural version of the same was also implemented. Refs: * https://www.php.net/manual/en/migration81.new-features.php#migration81.new-features.mysqli.mysqli_fetch_column * https://wiki.php.net/rfc/mysqli_fetch_column * php/php-src#6798 * php/php-src@54222a6 Co-authored-by: jrfnl <jrfnl@users.noreply.github.com> ClosesGH-1448.

* PHP 8.1 | MigrationGuide/New functions: add missing functions [1] (mentioned in new features, but not in the new functions list) > GD: > * Avif support is now available through the `imagecreatefromavif()` and > `imageavif()` functions, if libgd has been built with avif support. Refs: * https://github.com/php/php-src/blob/f67986a9218f4889d9352a87c29337a5b6eaa4bd/UPGRADING#L245-L247 * php/php-src#7026 * php/php-src@81f6d36 * PHP 8.1 | MigrationGuide/New functions: add missing functions [2] (mentioned in new features, but not in the new functions list) > `mysqli_result::fetch_column()` has been added to allow fetching a single scalar value from the result set. While only the method is mentioned in the RFC and the Migration guide, a procedural version of the same was also implemented. Refs: * https://www.php.net/manual/en/migration81.new-features.php#migration81.new-features.mysqli.mysqli_fetch_column * https://wiki.php.net/rfc/mysqli_fetch_column * php/php-src#6798 * php/php-src@54222a6 Co-authored-by: jrfnl <jrfnl@users.noreply.github.com> ClosesphpGH-1448.

kamil-tekiela · 2021-03-22T23:51:53Z

This is WIP but I am looking for suggestions to improve.

Is mixed better than null|int|string|false?
How to avoid temporary zval?

This should work almost exactly the same as PDO fetchColumn with the only difference that MySQL doesn't have a boolean type so the function can never return true (it will return false if no more rows are available).

cmb69 · 2021-03-30T12:17:05Z

Accompanying RFC: https://wiki.php.net/rfc/mysqli_fetch_column

nikic · 2021-04-14T08:34:39Z


 function mysqli_fetch_row(mysqli_result $result): array|null|false {}

+function mysqli_fetch_column(mysqli_result $result, int $column = 0): null|int|string|false {}


Can't it also return float in INT_AND_FLOAT native mode?

nikic

Looks good (assuming RFC accepted)

While only the method is mentioned in the RFC and the Migration guide, a procedural version of the same was also implemented. Includes unit tests. Refs: * https://www.php.net/manual/en/migration81.new-features.php#migration81.new-features.mysqli.mysqli_fetch_column * https://wiki.php.net/rfc/mysqli_fetch_column * php/php-src#6798 * php/php-src@54222a6

(mentioned in new features, but not in the new functions list) > `mysqli_result::fetch_column()` has been added to allow fetching a single scalar value from the result set. While only the method is mentioned in the RFC and the Migration guide, a procedural version of the same was also implemented. Refs: * https://www.php.net/manual/en/migration81.new-features.php#migration81.new-features.mysqli.mysqli_fetch_column * https://wiki.php.net/rfc/mysqli_fetch_column * php/php-src#6798 * php/php-src@54222a6

* PHP 8.1 | MigrationGuide/New functions: add missing functions [1] (mentioned in new features, but not in the new functions list) > GD: > * Avif support is now available through the `imagecreatefromavif()` and > `imageavif()` functions, if libgd has been built with avif support. Refs: * https://github.com/php/php-src/blob/f67986a9218f4889d9352a87c29337a5b6eaa4bd/UPGRADING#L245-L247 * php/php-src#7026 * php/php-src@81f6d36 * PHP 8.1 | MigrationGuide/New functions: add missing functions [2] (mentioned in new features, but not in the new functions list) > `mysqli_result::fetch_column()` has been added to allow fetching a single scalar value from the result set. While only the method is mentioned in the RFC and the Migration guide, a procedural version of the same was also implemented. Refs: * https://www.php.net/manual/en/migration81.new-features.php#migration81.new-features.mysqli.mysqli_fetch_column * https://wiki.php.net/rfc/mysqli_fetch_column * php/php-src#6798 * php/php-src@54222a6 Co-authored-by: jrfnl <jrfnl@users.noreply.github.com> ClosesGH-1448.

* PHP 8.1 | MigrationGuide/New functions: add missing functions [1] (mentioned in new features, but not in the new functions list) > GD: > * Avif support is now available through the `imagecreatefromavif()` and > `imageavif()` functions, if libgd has been built with avif support. Refs: * https://github.com/php/php-src/blob/f67986a9218f4889d9352a87c29337a5b6eaa4bd/UPGRADING#L245-L247 * php/php-src#7026 * php/php-src@81f6d36 * PHP 8.1 | MigrationGuide/New functions: add missing functions [2] (mentioned in new features, but not in the new functions list) > `mysqli_result::fetch_column()` has been added to allow fetching a single scalar value from the result set. While only the method is mentioned in the RFC and the Migration guide, a procedural version of the same was also implemented. Refs: * https://www.php.net/manual/en/migration81.new-features.php#migration81.new-features.mysqli.mysqli_fetch_column * https://wiki.php.net/rfc/mysqli_fetch_column * php/php-src#6798 * php/php-src@54222a6 Co-authored-by: jrfnl <jrfnl@users.noreply.github.com> ClosesphpGH-1448.

kamil-tekiela · 2021-03-22T23:51:53Z

This is WIP but I am looking for suggestions to improve.

Is mixed better than null|int|string|false?
How to avoid temporary zval?

This should work almost exactly the same as PDO fetchColumn with the only difference that MySQL doesn't have a boolean type so the function can never return true (it will return false if no more rows are available).

cmb69 · 2021-03-30T12:17:05Z

Accompanying RFC: https://wiki.php.net/rfc/mysqli_fetch_column

nikic · 2021-04-14T08:34:39Z


 function mysqli_fetch_row(mysqli_result $result): array|null|false {}

+function mysqli_fetch_column(mysqli_result $result, int $column = 0): null|int|string|false {}


Can't it also return float in INT_AND_FLOAT native mode?

nikic

Looks good (assuming RFC accepted)

While only the method is mentioned in the RFC and the Migration guide, a procedural version of the same was also implemented. Includes unit tests. Refs: * https://www.php.net/manual/en/migration81.new-features.php#migration81.new-features.mysqli.mysqli_fetch_column * https://wiki.php.net/rfc/mysqli_fetch_column * php/php-src#6798 * php/php-src@54222a6

(mentioned in new features, but not in the new functions list) > `mysqli_result::fetch_column()` has been added to allow fetching a single scalar value from the result set. While only the method is mentioned in the RFC and the Migration guide, a procedural version of the same was also implemented. Refs: * https://www.php.net/manual/en/migration81.new-features.php#migration81.new-features.mysqli.mysqli_fetch_column * https://wiki.php.net/rfc/mysqli_fetch_column * php/php-src#6798 * php/php-src@54222a6

* PHP 8.1 | MigrationGuide/New functions: add missing functions [1] (mentioned in new features, but not in the new functions list) > GD: > * Avif support is now available through the `imagecreatefromavif()` and > `imageavif()` functions, if libgd has been built with avif support. Refs: * https://github.com/php/php-src/blob/f67986a9218f4889d9352a87c29337a5b6eaa4bd/UPGRADING#L245-L247 * php/php-src#7026 * php/php-src@81f6d36 * PHP 8.1 | MigrationGuide/New functions: add missing functions [2] (mentioned in new features, but not in the new functions list) > `mysqli_result::fetch_column()` has been added to allow fetching a single scalar value from the result set. While only the method is mentioned in the RFC and the Migration guide, a procedural version of the same was also implemented. Refs: * https://www.php.net/manual/en/migration81.new-features.php#migration81.new-features.mysqli.mysqli_fetch_column * https://wiki.php.net/rfc/mysqli_fetch_column * php/php-src#6798 * php/php-src@54222a6 Co-authored-by: jrfnl <jrfnl@users.noreply.github.com> ClosesGH-1448.

* PHP 8.1 | MigrationGuide/New functions: add missing functions [1] (mentioned in new features, but not in the new functions list) > GD: > * Avif support is now available through the `imagecreatefromavif()` and > `imageavif()` functions, if libgd has been built with avif support. Refs: * https://github.com/php/php-src/blob/f67986a9218f4889d9352a87c29337a5b6eaa4bd/UPGRADING#L245-L247 * php/php-src#7026 * php/php-src@81f6d36 * PHP 8.1 | MigrationGuide/New functions: add missing functions [2] (mentioned in new features, but not in the new functions list) > `mysqli_result::fetch_column()` has been added to allow fetching a single scalar value from the result set. While only the method is mentioned in the RFC and the Migration guide, a procedural version of the same was also implemented. Refs: * https://www.php.net/manual/en/migration81.new-features.php#migration81.new-features.mysqli.mysqli_fetch_column * https://wiki.php.net/rfc/mysqli_fetch_column * php/php-src#6798 * php/php-src@54222a6 Co-authored-by: jrfnl <jrfnl@users.noreply.github.com> ClosesphpGH-1448.

kamil-tekiela · 2021-03-22T23:51:53Z

This is WIP but I am looking for suggestions to improve.

Is mixed better than null|int|string|false?
How to avoid temporary zval?

This should work almost exactly the same as PDO fetchColumn with the only difference that MySQL doesn't have a boolean type so the function can never return true (it will return false if no more rows are available).

cmb69 · 2021-03-30T12:17:05Z

Accompanying RFC: https://wiki.php.net/rfc/mysqli_fetch_column

nikic · 2021-04-14T08:34:39Z


 function mysqli_fetch_row(mysqli_result $result): array|null|false {}

+function mysqli_fetch_column(mysqli_result $result, int $column = 0): null|int|string|false {}


Can't it also return float in INT_AND_FLOAT native mode?

nikic

Looks good (assuming RFC accepted)

While only the method is mentioned in the RFC and the Migration guide, a procedural version of the same was also implemented. Includes unit tests. Refs: * https://www.php.net/manual/en/migration81.new-features.php#migration81.new-features.mysqli.mysqli_fetch_column * https://wiki.php.net/rfc/mysqli_fetch_column * php/php-src#6798 * php/php-src@54222a6

(mentioned in new features, but not in the new functions list) > `mysqli_result::fetch_column()` has been added to allow fetching a single scalar value from the result set. While only the method is mentioned in the RFC and the Migration guide, a procedural version of the same was also implemented. Refs: * https://www.php.net/manual/en/migration81.new-features.php#migration81.new-features.mysqli.mysqli_fetch_column * https://wiki.php.net/rfc/mysqli_fetch_column * php/php-src#6798 * php/php-src@54222a6

* PHP 8.1 | MigrationGuide/New functions: add missing functions [1] (mentioned in new features, but not in the new functions list) > GD: > * Avif support is now available through the `imagecreatefromavif()` and > `imageavif()` functions, if libgd has been built with avif support. Refs: * https://github.com/php/php-src/blob/f67986a9218f4889d9352a87c29337a5b6eaa4bd/UPGRADING#L245-L247 * php/php-src#7026 * php/php-src@81f6d36 * PHP 8.1 | MigrationGuide/New functions: add missing functions [2] (mentioned in new features, but not in the new functions list) > `mysqli_result::fetch_column()` has been added to allow fetching a single scalar value from the result set. While only the method is mentioned in the RFC and the Migration guide, a procedural version of the same was also implemented. Refs: * https://www.php.net/manual/en/migration81.new-features.php#migration81.new-features.mysqli.mysqli_fetch_column * https://wiki.php.net/rfc/mysqli_fetch_column * php/php-src#6798 * php/php-src@54222a6 Co-authored-by: jrfnl <jrfnl@users.noreply.github.com> ClosesGH-1448.

* PHP 8.1 | MigrationGuide/New functions: add missing functions [1] (mentioned in new features, but not in the new functions list) > GD: > * Avif support is now available through the `imagecreatefromavif()` and > `imageavif()` functions, if libgd has been built with avif support. Refs: * https://github.com/php/php-src/blob/f67986a9218f4889d9352a87c29337a5b6eaa4bd/UPGRADING#L245-L247 * php/php-src#7026 * php/php-src@81f6d36 * PHP 8.1 | MigrationGuide/New functions: add missing functions [2] (mentioned in new features, but not in the new functions list) > `mysqli_result::fetch_column()` has been added to allow fetching a single scalar value from the result set. While only the method is mentioned in the RFC and the Migration guide, a procedural version of the same was also implemented. Refs: * https://www.php.net/manual/en/migration81.new-features.php#migration81.new-features.mysqli.mysqli_fetch_column * https://wiki.php.net/rfc/mysqli_fetch_column * php/php-src#6798 * php/php-src@54222a6 Co-authored-by: jrfnl <jrfnl@users.noreply.github.com> ClosesphpGH-1448.

kocsismate reviewed Mar 23, 2021
View reviewed changes

Comment threadext/mysqli/mysqli_nonapi.c Outdated

kamil-tekiela force-pushed the Mysqli-fetch-column branch 4 times, most recently from d6e8caf to 243d14fCompare March 24, 2021 12:50

cmb69 added the RFC label Mar 30, 2021

kamil-tekiela force-pushed the Mysqli-fetch-column branch 2 times, most recently from 0eb8c61 to 757d1fdCompare April 4, 2021 22:52

nikic reviewed Apr 14, 2021
View reviewed changes

kamil-tekiela force-pushed the Mysqli-fetch-column branch from 757d1fd to 05ad183Compare April 14, 2021 12:19

nikic approved these changes Apr 26, 2021
View reviewed changes

kamil-tekiela added 2 commits May 1, 2021 20:04

Implement mysqli_fetch_column
a99ff69

UPGRADING
73969d4

kamil-tekiela force-pushed the Mysqli-fetch-column branch from 2ca3539 to 73969d4Compare May 1, 2021 19:10

kamil-tekiela merged commit 54222a6 into php:masterMay 1, 2021

jrfnl mentioned this pull request Mar 9, 2022
PHP 8.1 | NewFunctions: account for PHP 8.1 changes PHPCompatibility/PHPCompatibility#1325
Merged

jrfnl mentioned this pull request Mar 11, 2022
PHP 8.1 | MigrationGuide/New functions: add missing functions php/doc-en#1448
Merged

kocsismate reviewed Mar 23, 2021
View reviewed changes

Comment threadext/mysqli/mysqli_nonapi.c Outdated

kamil-tekiela force-pushed the Mysqli-fetch-column branch 4 times, most recently from d6e8caf to 243d14fCompare March 24, 2021 12:50

cmb69 added the RFC label Mar 30, 2021

kamil-tekiela force-pushed the Mysqli-fetch-column branch 2 times, most recently from 0eb8c61 to 757d1fdCompare April 4, 2021 22:52

nikic reviewed Apr 14, 2021
View reviewed changes

kamil-tekiela force-pushed the Mysqli-fetch-column branch from 757d1fd to 05ad183Compare April 14, 2021 12:19

nikic approved these changes Apr 26, 2021
View reviewed changes

kamil-tekiela added 2 commits May 1, 2021 20:04

Implement mysqli_fetch_column
a99ff69

UPGRADING
73969d4

kamil-tekiela force-pushed the Mysqli-fetch-column branch from 2ca3539 to 73969d4Compare May 1, 2021 19:10

kamil-tekiela merged commit 54222a6 into php:masterMay 1, 2021

jrfnl mentioned this pull request Mar 9, 2022
PHP 8.1 | NewFunctions: account for PHP 8.1 changes PHPCompatibility/PHPCompatibility#1325
Merged

jrfnl mentioned this pull request Mar 11, 2022
PHP 8.1 | MigrationGuide/New functions: add missing functions php/doc-en#1448
Merged

kocsismate reviewed Mar 23, 2021
View reviewed changes

Comment threadext/mysqli/mysqli_nonapi.c Outdated

kamil-tekiela force-pushed the Mysqli-fetch-column branch 4 times, most recently from d6e8caf to 243d14fCompare March 24, 2021 12:50

cmb69 added the RFC label Mar 30, 2021

kamil-tekiela force-pushed the Mysqli-fetch-column branch 2 times, most recently from 0eb8c61 to 757d1fdCompare April 4, 2021 22:52

nikic reviewed Apr 14, 2021
View reviewed changes

kamil-tekiela force-pushed the Mysqli-fetch-column branch from 757d1fd to 05ad183Compare April 14, 2021 12:19

nikic approved these changes Apr 26, 2021
View reviewed changes

kamil-tekiela added 2 commits May 1, 2021 20:04

Implement mysqli_fetch_column
a99ff69

UPGRADING
73969d4

kamil-tekiela force-pushed the Mysqli-fetch-column branch from 2ca3539 to 73969d4Compare May 1, 2021 19:10

kamil-tekiela merged commit 54222a6 into php:masterMay 1, 2021

jrfnl mentioned this pull request Mar 9, 2022
PHP 8.1 | NewFunctions: account for PHP 8.1 changes PHPCompatibility/PHPCompatibility#1325
Merged

jrfnl mentioned this pull request Mar 11, 2022
PHP 8.1 | MigrationGuide/New functions: add missing functions php/doc-en#1448
Merged

kocsismate reviewed Mar 23, 2021
View reviewed changes

Comment threadext/mysqli/mysqli_nonapi.c Outdated

kamil-tekiela force-pushed the Mysqli-fetch-column branch 4 times, most recently from d6e8caf to 243d14fCompare March 24, 2021 12:50

cmb69 added the RFC label Mar 30, 2021

kamil-tekiela force-pushed the Mysqli-fetch-column branch 2 times, most recently from 0eb8c61 to 757d1fdCompare April 4, 2021 22:52

nikic reviewed Apr 14, 2021
View reviewed changes

kamil-tekiela force-pushed the Mysqli-fetch-column branch from 757d1fd to 05ad183Compare April 14, 2021 12:19

nikic approved these changes Apr 26, 2021
View reviewed changes

kamil-tekiela added 2 commits May 1, 2021 20:04

Implement mysqli_fetch_column
a99ff69

UPGRADING
73969d4

kamil-tekiela force-pushed the Mysqli-fetch-column branch from 2ca3539 to 73969d4Compare May 1, 2021 19:10

kamil-tekiela merged commit 54222a6 into php:masterMay 1, 2021

jrfnl mentioned this pull request Mar 9, 2022
PHP 8.1 | NewFunctions: account for PHP 8.1 changes PHPCompatibility/PHPCompatibility#1325
Merged

jrfnl mentioned this pull request Mar 11, 2022
PHP 8.1 | MigrationGuide/New functions: add missing functions php/doc-en#1448
Merged

kocsismate reviewed Mar 23, 2021
View reviewed changes

Comment threadext/mysqli/mysqli_nonapi.c Outdated

kamil-tekiela force-pushed the Mysqli-fetch-column branch 4 times, most recently from d6e8caf to 243d14fCompare March 24, 2021 12:50

cmb69 added the RFC label Mar 30, 2021

kamil-tekiela force-pushed the Mysqli-fetch-column branch 2 times, most recently from 0eb8c61 to 757d1fdCompare April 4, 2021 22:52

nikic reviewed Apr 14, 2021
View reviewed changes

kamil-tekiela force-pushed the Mysqli-fetch-column branch from 757d1fd to 05ad183Compare April 14, 2021 12:19

nikic approved these changes Apr 26, 2021
View reviewed changes

kamil-tekiela added 2 commits May 1, 2021 20:04

Implement mysqli_fetch_column
a99ff69

UPGRADING
73969d4

kamil-tekiela force-pushed the Mysqli-fetch-column branch from 2ca3539 to 73969d4Compare May 1, 2021 19:10

kamil-tekiela merged commit 54222a6 into php:masterMay 1, 2021

jrfnl mentioned this pull request Mar 9, 2022
PHP 8.1 | NewFunctions: account for PHP 8.1 changes PHPCompatibility/PHPCompatibility#1325
Merged

jrfnl mentioned this pull request Mar 11, 2022
PHP 8.1 | MigrationGuide/New functions: add missing functions php/doc-en#1448
Merged

kocsismate reviewed Mar 23, 2021
View reviewed changes

Comment threadext/mysqli/mysqli_nonapi.c Outdated

kamil-tekiela force-pushed the Mysqli-fetch-column branch 4 times, most recently from d6e8caf to 243d14fCompare March 24, 2021 12:50

cmb69 added the RFC label Mar 30, 2021

kamil-tekiela force-pushed the Mysqli-fetch-column branch 2 times, most recently from 0eb8c61 to 757d1fdCompare April 4, 2021 22:52

nikic reviewed Apr 14, 2021
View reviewed changes

kamil-tekiela force-pushed the Mysqli-fetch-column branch from 757d1fd to 05ad183Compare April 14, 2021 12:19

nikic approved these changes Apr 26, 2021
View reviewed changes

kamil-tekiela added 2 commits May 1, 2021 20:04

Implement mysqli_fetch_column
a99ff69

UPGRADING
73969d4

kamil-tekiela force-pushed the Mysqli-fetch-column branch from 2ca3539 to 73969d4Compare May 1, 2021 19:10

kamil-tekiela merged commit 54222a6 into php:masterMay 1, 2021

jrfnl mentioned this pull request Mar 9, 2022
PHP 8.1 | NewFunctions: account for PHP 8.1 changes PHPCompatibility/PHPCompatibility#1325
Merged

jrfnl mentioned this pull request Mar 11, 2022
PHP 8.1 | MigrationGuide/New functions: add missing functions php/doc-en#1448
Merged

kocsismate reviewed Mar 23, 2021
View reviewed changes

Comment threadext/mysqli/mysqli_nonapi.c Outdated

kamil-tekiela force-pushed the Mysqli-fetch-column branch 4 times, most recently from d6e8caf to 243d14fCompare March 24, 2021 12:50

cmb69 added the RFC label Mar 30, 2021

kamil-tekiela force-pushed the Mysqli-fetch-column branch 2 times, most recently from 0eb8c61 to 757d1fdCompare April 4, 2021 22:52

nikic reviewed Apr 14, 2021
View reviewed changes

kamil-tekiela force-pushed the Mysqli-fetch-column branch from 757d1fd to 05ad183Compare April 14, 2021 12:19

nikic approved these changes Apr 26, 2021
View reviewed changes

kamil-tekiela added 2 commits May 1, 2021 20:04

Implement mysqli_fetch_column
a99ff69

UPGRADING
73969d4

kamil-tekiela force-pushed the Mysqli-fetch-column branch from 2ca3539 to 73969d4Compare May 1, 2021 19:10

kamil-tekiela merged commit 54222a6 into php:masterMay 1, 2021

jrfnl mentioned this pull request Mar 9, 2022
PHP 8.1 | NewFunctions: account for PHP 8.1 changes PHPCompatibility/PHPCompatibility#1325
Merged

jrfnl mentioned this pull request Mar 11, 2022
PHP 8.1 | MigrationGuide/New functions: add missing functions php/doc-en#1448
Merged

kocsismate reviewed Mar 23, 2021
View reviewed changes

Comment threadext/mysqli/mysqli_nonapi.c Outdated

kamil-tekiela force-pushed the Mysqli-fetch-column branch 4 times, most recently from d6e8caf to 243d14fCompare March 24, 2021 12:50

cmb69 added the RFC label Mar 30, 2021

kamil-tekiela force-pushed the Mysqli-fetch-column branch 2 times, most recently from 0eb8c61 to 757d1fdCompare April 4, 2021 22:52

nikic reviewed Apr 14, 2021
View reviewed changes

kamil-tekiela force-pushed the Mysqli-fetch-column branch from 757d1fd to 05ad183Compare April 14, 2021 12:19

nikic approved these changes Apr 26, 2021
View reviewed changes

kamil-tekiela added 2 commits May 1, 2021 20:04

Implement mysqli_fetch_column
a99ff69

UPGRADING
73969d4

kamil-tekiela force-pushed the Mysqli-fetch-column branch from 2ca3539 to 73969d4Compare May 1, 2021 19:10

kamil-tekiela merged commit 54222a6 into php:masterMay 1, 2021

jrfnl mentioned this pull request Mar 9, 2022
PHP 8.1 | NewFunctions: account for PHP 8.1 changes PHPCompatibility/PHPCompatibility#1325
Merged

jrfnl mentioned this pull request Mar 11, 2022
PHP 8.1 | MigrationGuide/New functions: add missing functions php/doc-en#1448
Merged


		function mysqli_fetch_row(mysqli_result $result): array\|null\|false {}

		function mysqli_fetch_column(mysqli_result $result, int $column = 0): null\|int\|string\|false {}

Uh oh!

Conversation

kamil-tekiela commented Mar 22, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

cmb69 commented Mar 30, 2021

Uh oh!

nikicApr 14, 2021

Choose a reason for hiding this comment

Uh oh!

nikic left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

kamil-tekiela commented Mar 22, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

cmb69 commented Mar 30, 2021

Uh oh!

nikicApr 14, 2021

Choose a reason for hiding this comment

Uh oh!

nikic left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

kamil-tekiela commented Mar 22, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

cmb69 commented Mar 30, 2021

Uh oh!

nikicApr 14, 2021

Choose a reason for hiding this comment

Uh oh!

nikic left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

kamil-tekiela commented Mar 22, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

cmb69 commented Mar 30, 2021

Uh oh!

nikicApr 14, 2021

Choose a reason for hiding this comment

Uh oh!

nikic left a comment

Choose a reason for hiding this comment

Uh oh!

kamil-tekiela commented Mar 22, 2021•
edited
Loading

kamil-tekiela commented Mar 22, 2021•
edited
Loading

kamil-tekiela commented Mar 22, 2021•
edited
Loading

kamil-tekiela commented Mar 22, 2021•
edited
Loading

kamil-tekiela commented Mar 22, 2021•
edited
Loading

kamil-tekiela commented Mar 22, 2021•
edited
Loading