Uh oh!
There was an error while loading. Please reload this page.
Fix ZTS build for Alpine (musl libc) - #8180
Closed
mvorisek wants to merge 2 commits into
Closed
Conversation
ContributorAuthor
@cmb69 please see the 2nd commit it seems the JIT/ASM code use the 2nd commit fixes the ZTS build issues on Alpine, however if such fix is correct (I am not quite sure), then the condition must be exactly the same in all places which is not the case, compare: Line 150 in abd9529 and Line 739 in abd9529 and php-src/ext/opcache/jit/zend_jit_x86.dasc Line 2977 in abd9529 |
mvorisek
commented
Mar 7, 2022
ContributorAuthor
@dstogov, you are the author of TSRM/JIT code, can you please review this PR? |
mvorisek
commented
Mar 8, 2022
ContributorAuthor
based on docker-library/php#1076 (comment) comment, this patch is tested to be working on Alpine/musl |
dstogov
commented
Mar 11, 2022
Member
Looks good. Please merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix#8160
credits go to @cmb69, thanks!
discussion 804420b#r68129969