Uh oh!
There was an error while loading. Please reload this page.
Fix #8952: std streams can not be deliberately closed - #8953
Merged
Conversation
arnaud-lb
marked this pull request as ready for review
July 8, 2022 13:42
arnaud-lb
commented
Jul 8, 2022
MemberAuthor
The FreeBSD build failure is unrelated |
cmb69
approved these changes
Jul 8, 2022
cmb69
left a comment
Member
There was a problem hiding this comment.
Thank you very much! Looks good to me. Maybe @fds242 and @moonlitbugs want to double-check.
bukka
commented
Jul 9, 2022
Member
LGTM too, please commit it. I will modify my changes in #8833 to be correctly applied. |
arnaud-lb
commented
Jul 9, 2022
MemberAuthor
@bukka I've just merged 👍 |
moonlitbugs
commented
Jul 12, 2022
Patch tested here, and working fine. Streams closed as expected. |
adrian-enspired pushed a commit
to adrian-enspired/php-src
that referenced
this pull request
Aug 4, 2026
adrian-enspired pushed a commit
to adrian-enspired/php-src
that referenced
this pull request
Aug 4, 2026
* PHP-8.1: [ci skip] NEWS FixphpGH-8952: std streams can not be deliberately closed (php#8953) intl extension, build fix for icu >= 69.x release. ubrk/ucnv_safeClone had been deprecated in favor of ubrk/ucnv_clone which does not use user provided stacks but remain thread safe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#8827 has been fixed in 8.0, but the fix was incomplete for 8.1 (see #8952).