Skip to content

Make pestr[n]dup infallible - #9295

Merged
iluuu1994 merged 1 commit into
php:masterfrom
iluuu1994:infallible-pestrdup
Aug 12, 2022
Merged

Make pestr[n]dup infallible#9295
iluuu1994 merged 1 commit into
php:masterfrom
iluuu1994:infallible-pestrdup

Conversation

@iluuu1994

@iluuu1994iluuu1994 commented Aug 11, 2022

Copy link
Copy Markdown
Member

FixesGH-9128

@iluuu1994
iluuu1994 requested a review from cmb69August 11, 2022 09:46
@iluuu1994

iluuu1994 commented Aug 11, 2022

Copy link
Copy Markdown
MemberAuthor

Alternatively we could make zend_strndup infallible itself, which would probably not be a bad idea.

@cmb69

cmb69 commented Aug 11, 2022

Copy link
Copy Markdown
Member

Alternatively we could make zend_strndup infallible itself, which would probably not be a bad idea.

I tend to agree.

@devnexen

devnexen commented Aug 11, 2022

Copy link
Copy Markdown
Member

Alternatively we could make zend_strndup infallible itself, which would probably not be a bad idea.

I tend to agree.

seconded.

@iluuu1994
iluuu1994 merged commit 98bdb7f into php:masterAug 12, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmb69cmb69Awaiting requested review from cmb69

Assignees

No one assigned

Labels

Category: EngineExtension: standardSAPI: cli

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

pestr(n)dup() is not infallible

3 participants

@iluuu1994@cmb69@devnexen