Fix syntax error when using readonly with dnf

[iluuu1994]

FixesGH-9500

[Girgias]

Other than the one question LGTM!
Thanks for helping this was really a head scratcher as I had forgotten the BC layer

[Girgias]

Does using readonly () with the whitespace now break? Or is it unnecessary due to the move to the parser?

[iluuu1994]

It's just unnecessary since this is no longer special-cased. This should still work. I can keep it if you prefer.

[Girgias]

No harm keeping it then :)

[iluuu1994]

I have absolutely no clue why the pipeline failed. I could run that script locally with no problem. Rebased to try again.

[Girgias]

Is there maybe some caching issue on Travis?

[cmb69]

Did you run ext/tokenizer/tokenizer_data_gen.php?

[iluuu1994]

Did you run ext/tokenizer/tokenizer_data_gen.php?

No changes are generated as no token has been added/removed. This script works fine in the CI too. However, build/gen_stub.php fails on line 572.

if ($nodeinstanceofNode\NullableType) {
returnnewType(
[
...Type::fromNode($node->type)->types, // <-- Here
SimpleType::null(),
],
false
);
}

PHP Parse error: syntax error, unexpected '...' (T_ELLIPSIS), expecting ']'

Which is very strange because array_pair has not been touched, nor anything else that looks relevant. I'll reset the grammar just to see if this is actually caused by my changes, although it would be a big coincidence if it wasn't.

Edit: Yep, definitely cause by my changes 😅

[nikic]

Ultimately, the core problem here is that gen_stub.php is required to be PHP 7.1 compatible, and someone introduced PHP 7.4 syntax into it. It needs to be changed to either be PHP 7.1 compatible, or the build system needs to be adjusted to not run gen_stub.php if the host PHP version is older than PHP 7.4.

[iluuu1994]

@nikic Ah, thanks. I guess Travis caches the zend_language_parser.c and only generates it when the grammar has changed. But that still poses the question, how was it generated the first time when non-PHP-7.1 syntax was used? Anyway, this is probably not worth further investigating. @kocsismate Should we bump to PHP-7.4 or remove the ...?

Edit: Ah, of course. The grammar just hasn't been changed since the ... was introduced.

[nikic]

I'd suggest bumping to 7.4 at this point. One must be two LTS versions behind to have something older.

Though in that case we'd also want to make more thorough use of it (yay property types).

[cmb69]

Regardless of whether we bump the PHP version requirement for gen_stubs.php, it probably makes sense to add an explicit version check, and fail fast for too old PHP versions.

[kocsismate]

My plan was to bump the version requirement of gen_stub.php only for master as soon as I finish the PHP 8.2 related changes. That's why my preference would be to just replace the ... for now. But I don't mind either if we immediately require PHP 7.4 at least for the PHP-8.2 branch as well.

it probably makes sense to add an explicit version check, and fail fast for too old PHP versions.

Very good idea, 100% agreed!

[nikic]

LG

[SpacePossum]

Thank you all :) 🚀

[SpacePossum]

<?phpclass A
{
readonlystatic (A&B)|C$b; // validstaticreadonly (A&B)|C$a; // invalid
}

these more simple static forms are not in the test, I haven't tested it on this PR, but just to let you know :)

[iluuu1994]

FixesGH-9500

[Girgias]

Other than the one question LGTM!
Thanks for helping this was really a head scratcher as I had forgotten the BC layer

[Girgias]

Does using readonly () with the whitespace now break? Or is it unnecessary due to the move to the parser?

[iluuu1994]

It's just unnecessary since this is no longer special-cased. This should still work. I can keep it if you prefer.

[Girgias]

No harm keeping it then :)

[iluuu1994]

I have absolutely no clue why the pipeline failed. I could run that script locally with no problem. Rebased to try again.

[Girgias]

Is there maybe some caching issue on Travis?

[cmb69]

Did you run ext/tokenizer/tokenizer_data_gen.php?

[iluuu1994]

Did you run ext/tokenizer/tokenizer_data_gen.php?

No changes are generated as no token has been added/removed. This script works fine in the CI too. However, build/gen_stub.php fails on line 572.

if ($nodeinstanceofNode\NullableType) {
returnnewType(
[
...Type::fromNode($node->type)->types, // <-- Here
SimpleType::null(),
],
false
);
}

PHP Parse error: syntax error, unexpected '...' (T_ELLIPSIS), expecting ']'

Which is very strange because array_pair has not been touched, nor anything else that looks relevant. I'll reset the grammar just to see if this is actually caused by my changes, although it would be a big coincidence if it wasn't.

Edit: Yep, definitely cause by my changes 😅

[nikic]

Ultimately, the core problem here is that gen_stub.php is required to be PHP 7.1 compatible, and someone introduced PHP 7.4 syntax into it. It needs to be changed to either be PHP 7.1 compatible, or the build system needs to be adjusted to not run gen_stub.php if the host PHP version is older than PHP 7.4.

[iluuu1994]

@nikic Ah, thanks. I guess Travis caches the zend_language_parser.c and only generates it when the grammar has changed. But that still poses the question, how was it generated the first time when non-PHP-7.1 syntax was used? Anyway, this is probably not worth further investigating. @kocsismate Should we bump to PHP-7.4 or remove the ...?

Edit: Ah, of course. The grammar just hasn't been changed since the ... was introduced.

[nikic]

I'd suggest bumping to 7.4 at this point. One must be two LTS versions behind to have something older.

Though in that case we'd also want to make more thorough use of it (yay property types).

[cmb69]

Regardless of whether we bump the PHP version requirement for gen_stubs.php, it probably makes sense to add an explicit version check, and fail fast for too old PHP versions.

[kocsismate]

My plan was to bump the version requirement of gen_stub.php only for master as soon as I finish the PHP 8.2 related changes. That's why my preference would be to just replace the ... for now. But I don't mind either if we immediately require PHP 7.4 at least for the PHP-8.2 branch as well.

it probably makes sense to add an explicit version check, and fail fast for too old PHP versions.

Very good idea, 100% agreed!

[nikic]

LG

[SpacePossum]

Thank you all :) 🚀

[SpacePossum]

<?phpclass A
{
readonlystatic (A&B)|C$b; // validstaticreadonly (A&B)|C$a; // invalid
}

these more simple static forms are not in the test, I haven't tested it on this PR, but just to let you know :)

[iluuu1994]

FixesGH-9500

[Girgias]

Other than the one question LGTM!
Thanks for helping this was really a head scratcher as I had forgotten the BC layer

[Girgias]

Does using readonly () with the whitespace now break? Or is it unnecessary due to the move to the parser?

[iluuu1994]

It's just unnecessary since this is no longer special-cased. This should still work. I can keep it if you prefer.

[Girgias]

No harm keeping it then :)

[iluuu1994]

I have absolutely no clue why the pipeline failed. I could run that script locally with no problem. Rebased to try again.

[Girgias]

Is there maybe some caching issue on Travis?

[cmb69]

Did you run ext/tokenizer/tokenizer_data_gen.php?

[iluuu1994]

Did you run ext/tokenizer/tokenizer_data_gen.php?

No changes are generated as no token has been added/removed. This script works fine in the CI too. However, build/gen_stub.php fails on line 572.

if ($nodeinstanceofNode\NullableType) {
returnnewType(
[
...Type::fromNode($node->type)->types, // <-- Here
SimpleType::null(),
],
false
);
}

PHP Parse error: syntax error, unexpected '...' (T_ELLIPSIS), expecting ']'

Which is very strange because array_pair has not been touched, nor anything else that looks relevant. I'll reset the grammar just to see if this is actually caused by my changes, although it would be a big coincidence if it wasn't.

Edit: Yep, definitely cause by my changes 😅

[nikic]

Ultimately, the core problem here is that gen_stub.php is required to be PHP 7.1 compatible, and someone introduced PHP 7.4 syntax into it. It needs to be changed to either be PHP 7.1 compatible, or the build system needs to be adjusted to not run gen_stub.php if the host PHP version is older than PHP 7.4.

[iluuu1994]

@nikic Ah, thanks. I guess Travis caches the zend_language_parser.c and only generates it when the grammar has changed. But that still poses the question, how was it generated the first time when non-PHP-7.1 syntax was used? Anyway, this is probably not worth further investigating. @kocsismate Should we bump to PHP-7.4 or remove the ...?

Edit: Ah, of course. The grammar just hasn't been changed since the ... was introduced.

[nikic]

I'd suggest bumping to 7.4 at this point. One must be two LTS versions behind to have something older.

Though in that case we'd also want to make more thorough use of it (yay property types).

[cmb69]

Regardless of whether we bump the PHP version requirement for gen_stubs.php, it probably makes sense to add an explicit version check, and fail fast for too old PHP versions.

[kocsismate]

My plan was to bump the version requirement of gen_stub.php only for master as soon as I finish the PHP 8.2 related changes. That's why my preference would be to just replace the ... for now. But I don't mind either if we immediately require PHP 7.4 at least for the PHP-8.2 branch as well.

it probably makes sense to add an explicit version check, and fail fast for too old PHP versions.

Very good idea, 100% agreed!

[nikic]

LG

[SpacePossum]

Thank you all :) 🚀

[SpacePossum]

<?phpclass A
{
readonlystatic (A&B)|C$b; // validstaticreadonly (A&B)|C$a; // invalid
}

these more simple static forms are not in the test, I haven't tested it on this PR, but just to let you know :)

[iluuu1994]

FixesGH-9500

[Girgias]

Other than the one question LGTM!
Thanks for helping this was really a head scratcher as I had forgotten the BC layer

[Girgias]

Does using readonly () with the whitespace now break? Or is it unnecessary due to the move to the parser?

[iluuu1994]

It's just unnecessary since this is no longer special-cased. This should still work. I can keep it if you prefer.

[Girgias]

No harm keeping it then :)

[iluuu1994]

I have absolutely no clue why the pipeline failed. I could run that script locally with no problem. Rebased to try again.

[Girgias]

Is there maybe some caching issue on Travis?

[cmb69]

Did you run ext/tokenizer/tokenizer_data_gen.php?

[iluuu1994]

Did you run ext/tokenizer/tokenizer_data_gen.php?

No changes are generated as no token has been added/removed. This script works fine in the CI too. However, build/gen_stub.php fails on line 572.

if ($nodeinstanceofNode\NullableType) {
returnnewType(
[
...Type::fromNode($node->type)->types, // <-- Here
SimpleType::null(),
],
false
);
}

PHP Parse error: syntax error, unexpected '...' (T_ELLIPSIS), expecting ']'

Which is very strange because array_pair has not been touched, nor anything else that looks relevant. I'll reset the grammar just to see if this is actually caused by my changes, although it would be a big coincidence if it wasn't.

Edit: Yep, definitely cause by my changes 😅

[nikic]

Ultimately, the core problem here is that gen_stub.php is required to be PHP 7.1 compatible, and someone introduced PHP 7.4 syntax into it. It needs to be changed to either be PHP 7.1 compatible, or the build system needs to be adjusted to not run gen_stub.php if the host PHP version is older than PHP 7.4.

[iluuu1994]

@nikic Ah, thanks. I guess Travis caches the zend_language_parser.c and only generates it when the grammar has changed. But that still poses the question, how was it generated the first time when non-PHP-7.1 syntax was used? Anyway, this is probably not worth further investigating. @kocsismate Should we bump to PHP-7.4 or remove the ...?

Edit: Ah, of course. The grammar just hasn't been changed since the ... was introduced.

[nikic]

I'd suggest bumping to 7.4 at this point. One must be two LTS versions behind to have something older.

Though in that case we'd also want to make more thorough use of it (yay property types).

[cmb69]

Regardless of whether we bump the PHP version requirement for gen_stubs.php, it probably makes sense to add an explicit version check, and fail fast for too old PHP versions.

[kocsismate]

My plan was to bump the version requirement of gen_stub.php only for master as soon as I finish the PHP 8.2 related changes. That's why my preference would be to just replace the ... for now. But I don't mind either if we immediately require PHP 7.4 at least for the PHP-8.2 branch as well.

it probably makes sense to add an explicit version check, and fail fast for too old PHP versions.

Very good idea, 100% agreed!

[nikic]

LG

[SpacePossum]

Thank you all :) 🚀

[SpacePossum]

<?phpclass A
{
readonlystatic (A&B)|C$b; // validstaticreadonly (A&B)|C$a; // invalid
}

these more simple static forms are not in the test, I haven't tested it on this PR, but just to let you know :)

[iluuu1994]

FixesGH-9500

[Girgias]

Other than the one question LGTM!
Thanks for helping this was really a head scratcher as I had forgotten the BC layer

[Girgias]

Does using readonly () with the whitespace now break? Or is it unnecessary due to the move to the parser?

[iluuu1994]

It's just unnecessary since this is no longer special-cased. This should still work. I can keep it if you prefer.

[Girgias]

No harm keeping it then :)

[iluuu1994]

I have absolutely no clue why the pipeline failed. I could run that script locally with no problem. Rebased to try again.

[Girgias]

Is there maybe some caching issue on Travis?

[cmb69]

Did you run ext/tokenizer/tokenizer_data_gen.php?

[iluuu1994]

Did you run ext/tokenizer/tokenizer_data_gen.php?

No changes are generated as no token has been added/removed. This script works fine in the CI too. However, build/gen_stub.php fails on line 572.

if ($nodeinstanceofNode\NullableType) {
returnnewType(
[
...Type::fromNode($node->type)->types, // <-- Here
SimpleType::null(),
],
false
);
}

PHP Parse error: syntax error, unexpected '...' (T_ELLIPSIS), expecting ']'

Which is very strange because array_pair has not been touched, nor anything else that looks relevant. I'll reset the grammar just to see if this is actually caused by my changes, although it would be a big coincidence if it wasn't.

Edit: Yep, definitely cause by my changes 😅

[nikic]

Ultimately, the core problem here is that gen_stub.php is required to be PHP 7.1 compatible, and someone introduced PHP 7.4 syntax into it. It needs to be changed to either be PHP 7.1 compatible, or the build system needs to be adjusted to not run gen_stub.php if the host PHP version is older than PHP 7.4.

[iluuu1994]

@nikic Ah, thanks. I guess Travis caches the zend_language_parser.c and only generates it when the grammar has changed. But that still poses the question, how was it generated the first time when non-PHP-7.1 syntax was used? Anyway, this is probably not worth further investigating. @kocsismate Should we bump to PHP-7.4 or remove the ...?

Edit: Ah, of course. The grammar just hasn't been changed since the ... was introduced.

[nikic]

I'd suggest bumping to 7.4 at this point. One must be two LTS versions behind to have something older.

Though in that case we'd also want to make more thorough use of it (yay property types).

[cmb69]

Regardless of whether we bump the PHP version requirement for gen_stubs.php, it probably makes sense to add an explicit version check, and fail fast for too old PHP versions.

[kocsismate]

My plan was to bump the version requirement of gen_stub.php only for master as soon as I finish the PHP 8.2 related changes. That's why my preference would be to just replace the ... for now. But I don't mind either if we immediately require PHP 7.4 at least for the PHP-8.2 branch as well.

it probably makes sense to add an explicit version check, and fail fast for too old PHP versions.

Very good idea, 100% agreed!

[nikic]

LG

[SpacePossum]

Thank you all :) 🚀

[SpacePossum]

<?phpclass A
{
readonlystatic (A&B)|C$b; // validstaticreadonly (A&B)|C$a; // invalid
}

these more simple static forms are not in the test, I haven't tested it on this PR, but just to let you know :)

[iluuu1994]

FixesGH-9500

[Girgias]

Other than the one question LGTM!
Thanks for helping this was really a head scratcher as I had forgotten the BC layer

[Girgias]

Does using readonly () with the whitespace now break? Or is it unnecessary due to the move to the parser?

[iluuu1994]

It's just unnecessary since this is no longer special-cased. This should still work. I can keep it if you prefer.

[Girgias]

No harm keeping it then :)

[iluuu1994]

I have absolutely no clue why the pipeline failed. I could run that script locally with no problem. Rebased to try again.

[Girgias]

Is there maybe some caching issue on Travis?

[cmb69]

Did you run ext/tokenizer/tokenizer_data_gen.php?

[iluuu1994]

Did you run ext/tokenizer/tokenizer_data_gen.php?

No changes are generated as no token has been added/removed. This script works fine in the CI too. However, build/gen_stub.php fails on line 572.

if ($nodeinstanceofNode\NullableType) {
returnnewType(
[
...Type::fromNode($node->type)->types, // <-- Here
SimpleType::null(),
],
false
);
}

PHP Parse error: syntax error, unexpected '...' (T_ELLIPSIS), expecting ']'

Which is very strange because array_pair has not been touched, nor anything else that looks relevant. I'll reset the grammar just to see if this is actually caused by my changes, although it would be a big coincidence if it wasn't.

Edit: Yep, definitely cause by my changes 😅

[nikic]

Ultimately, the core problem here is that gen_stub.php is required to be PHP 7.1 compatible, and someone introduced PHP 7.4 syntax into it. It needs to be changed to either be PHP 7.1 compatible, or the build system needs to be adjusted to not run gen_stub.php if the host PHP version is older than PHP 7.4.

[iluuu1994]

@nikic Ah, thanks. I guess Travis caches the zend_language_parser.c and only generates it when the grammar has changed. But that still poses the question, how was it generated the first time when non-PHP-7.1 syntax was used? Anyway, this is probably not worth further investigating. @kocsismate Should we bump to PHP-7.4 or remove the ...?

Edit: Ah, of course. The grammar just hasn't been changed since the ... was introduced.

[nikic]

I'd suggest bumping to 7.4 at this point. One must be two LTS versions behind to have something older.

Though in that case we'd also want to make more thorough use of it (yay property types).

[cmb69]

Regardless of whether we bump the PHP version requirement for gen_stubs.php, it probably makes sense to add an explicit version check, and fail fast for too old PHP versions.

[kocsismate]

My plan was to bump the version requirement of gen_stub.php only for master as soon as I finish the PHP 8.2 related changes. That's why my preference would be to just replace the ... for now. But I don't mind either if we immediately require PHP 7.4 at least for the PHP-8.2 branch as well.

it probably makes sense to add an explicit version check, and fail fast for too old PHP versions.

Very good idea, 100% agreed!

[nikic]

LG

[SpacePossum]

Thank you all :) 🚀

[SpacePossum]

<?phpclass A
{
readonlystatic (A&B)|C$b; // validstaticreadonly (A&B)|C$a; // invalid
}

these more simple static forms are not in the test, I haven't tested it on this PR, but just to let you know :)

[iluuu1994]

FixesGH-9500

[Girgias]

Other than the one question LGTM!
Thanks for helping this was really a head scratcher as I had forgotten the BC layer

[Girgias]

Does using readonly () with the whitespace now break? Or is it unnecessary due to the move to the parser?

[iluuu1994]

It's just unnecessary since this is no longer special-cased. This should still work. I can keep it if you prefer.

[Girgias]

No harm keeping it then :)

[iluuu1994]

I have absolutely no clue why the pipeline failed. I could run that script locally with no problem. Rebased to try again.

[Girgias]

Is there maybe some caching issue on Travis?

[cmb69]

Did you run ext/tokenizer/tokenizer_data_gen.php?

[iluuu1994]

Did you run ext/tokenizer/tokenizer_data_gen.php?

No changes are generated as no token has been added/removed. This script works fine in the CI too. However, build/gen_stub.php fails on line 572.

if ($nodeinstanceofNode\NullableType) {
returnnewType(
[
...Type::fromNode($node->type)->types, // <-- Here
SimpleType::null(),
],
false
);
}

PHP Parse error: syntax error, unexpected '...' (T_ELLIPSIS), expecting ']'

Which is very strange because array_pair has not been touched, nor anything else that looks relevant. I'll reset the grammar just to see if this is actually caused by my changes, although it would be a big coincidence if it wasn't.

Edit: Yep, definitely cause by my changes 😅

[nikic]

Ultimately, the core problem here is that gen_stub.php is required to be PHP 7.1 compatible, and someone introduced PHP 7.4 syntax into it. It needs to be changed to either be PHP 7.1 compatible, or the build system needs to be adjusted to not run gen_stub.php if the host PHP version is older than PHP 7.4.

[iluuu1994]

@nikic Ah, thanks. I guess Travis caches the zend_language_parser.c and only generates it when the grammar has changed. But that still poses the question, how was it generated the first time when non-PHP-7.1 syntax was used? Anyway, this is probably not worth further investigating. @kocsismate Should we bump to PHP-7.4 or remove the ...?

Edit: Ah, of course. The grammar just hasn't been changed since the ... was introduced.

[nikic]

I'd suggest bumping to 7.4 at this point. One must be two LTS versions behind to have something older.

Though in that case we'd also want to make more thorough use of it (yay property types).

[cmb69]

Regardless of whether we bump the PHP version requirement for gen_stubs.php, it probably makes sense to add an explicit version check, and fail fast for too old PHP versions.

[kocsismate]

My plan was to bump the version requirement of gen_stub.php only for master as soon as I finish the PHP 8.2 related changes. That's why my preference would be to just replace the ... for now. But I don't mind either if we immediately require PHP 7.4 at least for the PHP-8.2 branch as well.

it probably makes sense to add an explicit version check, and fail fast for too old PHP versions.

Very good idea, 100% agreed!

[nikic]

LG

[SpacePossum]

Thank you all :) 🚀

[SpacePossum]

<?phpclass A
{
readonlystatic (A&B)|C$b; // validstaticreadonly (A&B)|C$a; // invalid
}

these more simple static forms are not in the test, I haven't tested it on this PR, but just to let you know :)

[iluuu1994]

FixesGH-9500

[Girgias]

Other than the one question LGTM!
Thanks for helping this was really a head scratcher as I had forgotten the BC layer

[Girgias]

Does using readonly () with the whitespace now break? Or is it unnecessary due to the move to the parser?

[iluuu1994]

It's just unnecessary since this is no longer special-cased. This should still work. I can keep it if you prefer.

[Girgias]

No harm keeping it then :)

[iluuu1994]

I have absolutely no clue why the pipeline failed. I could run that script locally with no problem. Rebased to try again.

[Girgias]

Is there maybe some caching issue on Travis?

[cmb69]

Did you run ext/tokenizer/tokenizer_data_gen.php?

[iluuu1994]

Did you run ext/tokenizer/tokenizer_data_gen.php?

No changes are generated as no token has been added/removed. This script works fine in the CI too. However, build/gen_stub.php fails on line 572.

if ($nodeinstanceofNode\NullableType) {
returnnewType(
[
...Type::fromNode($node->type)->types, // <-- Here
SimpleType::null(),
],
false
);
}

PHP Parse error: syntax error, unexpected '...' (T_ELLIPSIS), expecting ']'

Which is very strange because array_pair has not been touched, nor anything else that looks relevant. I'll reset the grammar just to see if this is actually caused by my changes, although it would be a big coincidence if it wasn't.

Edit: Yep, definitely cause by my changes 😅

[nikic]

Ultimately, the core problem here is that gen_stub.php is required to be PHP 7.1 compatible, and someone introduced PHP 7.4 syntax into it. It needs to be changed to either be PHP 7.1 compatible, or the build system needs to be adjusted to not run gen_stub.php if the host PHP version is older than PHP 7.4.

[iluuu1994]

@nikic Ah, thanks. I guess Travis caches the zend_language_parser.c and only generates it when the grammar has changed. But that still poses the question, how was it generated the first time when non-PHP-7.1 syntax was used? Anyway, this is probably not worth further investigating. @kocsismate Should we bump to PHP-7.4 or remove the ...?

Edit: Ah, of course. The grammar just hasn't been changed since the ... was introduced.

[nikic]

I'd suggest bumping to 7.4 at this point. One must be two LTS versions behind to have something older.

Though in that case we'd also want to make more thorough use of it (yay property types).

[cmb69]

Regardless of whether we bump the PHP version requirement for gen_stubs.php, it probably makes sense to add an explicit version check, and fail fast for too old PHP versions.

[kocsismate]

My plan was to bump the version requirement of gen_stub.php only for master as soon as I finish the PHP 8.2 related changes. That's why my preference would be to just replace the ... for now. But I don't mind either if we immediately require PHP 7.4 at least for the PHP-8.2 branch as well.

it probably makes sense to add an explicit version check, and fail fast for too old PHP versions.

Very good idea, 100% agreed!

[nikic]

LG

[SpacePossum]

Thank you all :) 🚀

[SpacePossum]

<?phpclass A
{
readonlystatic (A&B)|C$b; // validstaticreadonly (A&B)|C$a; // invalid
}

these more simple static forms are not in the test, I haven't tested it on this PR, but just to let you know :)