Uh oh!
There was an error while loading. Please reload this page.
feat: node 24 update - #10
Merged
Merged
Conversation
asgrim
commented
Jun 6, 2026
Contributor
This is an enormous diff, so not sure when I can get to it... if you can simplify this, it might be better... |
ContributorAuthor
I can remove that from diff but you have to run it afterwards and commit. That's sadly how Javascript actions work. You can also ignore the dist files as there is a CI Job which verifies that the generated dist does not drift out |
shyim
commented
Jun 7, 2026
ContributorAuthor
I split into two commits for better review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Got some deprecations inside GHA using this action. Therefore updated runtime to Node 24, and replaced Jest with Vite (Jest with ESM is weird).
Tested against real project 🙂
