[0.9.0] bash completion broken by pie banner

[remicollet]

The file generated by bin/pie completion bash
start with the pie banner, which make it unusable

[remicollet]

Notice, that this banner is probably also uneeded for --version

Output seems redundant

$ pie --version 
🥧 PHP Installer for Extensions (PIE), 0.9.0.0, from The PHP Foundation
🥧 PHP Installer for Extensions (PIE) 0.9.0.0

[GromNaN]

The command event should probably be used for displaying the message. The event object has access to the command object so you can filter which commands display this info.

[llaville]

There is also another alternative. Use an AbstractCommand class that will display this banner only if you decide to extends a base class.

With

<?php

declare(strict_types=1);

namespace Php\Pie\Command;

use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;

abstract class AbstractCommand extends Command
{
 protected function execute(InputInterface $input, OutputInterface $output)
 {
 $output->writeln($this->getApplication()->getLongVersion());
 }
}

And a base application that will support the getLongVersion() method

<?php

declare(strict_types=1);

namespace Php\Pie;

class Application extends \Symfony\Component\Console\Application
{
 public function getLongVersion()
 {
 return $this->getName() . ', <info>' . $this->getVersion() . '</info>, from The PHP Foundation';
 }
}

And following patch on current version 0.9 source code

diff --git a/bin/pie b/bin/pie
index e458eb4..f54ba2a 100755
--- a/bin/pie
+++ b/bin/pie
@@ -17,7 +17,6 @@ use Php\Pie\Command\SelfUpdateCommand;
 use Php\Pie\Command\ShowCommand;
 use Php\Pie\Command\UninstallCommand;
 use Php\Pie\Util\PieVersion;
-use Symfony\Component\Console\Application;
 use Symfony\Component\Console\CommandLoader\ContainerCommandLoader;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
@@ -30,7 +29,6 @@ $container = Container::factory();
 $pieAppName = '🥧 PHP Installer for Extensions (PIE)';
 $pieVersion = PieVersion::get();
 $application = new Application($pieAppName, $pieVersion);
-echo $pieAppName . ', ' . $pieVersion . ", from The PHP Foundation\n";
 
 $application->setCommandLoader(new ContainerCommandLoader(
 $container,
diff --git a/src/Command/RepositoryListCommand.php b/src/Command/RepositoryListCommand.php
index a2d6ddd..2ea5930 100644
--- a/src/Command/RepositoryListCommand.php
+++ b/src/Command/RepositoryListCommand.php
@@ -16,7 +16,7 @@ use Symfony\Component\Console\Output\OutputInterface;
 name: 'repository:list',
 description: 'List the package repositories that PIE uses.',
 )]
-final class RepositoryListCommand extends Command
+final class RepositoryListCommand extends AbstractCommand
 {
 public function __construct(
 private readonly ContainerInterface $container,
@@ -33,6 +33,8 @@ final class RepositoryListCommand extends Command
 
 public function execute(InputInterface $input, OutputInterface $output): int
 {
+ parent::execute($input, $output);
+
 CommandHelper::listRepositories(
 PieComposerFactory::createPieComposer(
 $this->container,

I did it only on one command repository:list for demo purpose only

Here are some output prints examples

[asgrim]

Thanks - we are already on the case folks! No further feedback needed.