self-update does update, but displays class not found error and PHP output due to PHAR content changing

[asgrim]

We introduced the EventDispatcher in #219 to handle the banner, but this has introduced a side-effect when the PHAR is overwritten (by SelfUpdateCommand), in that the PHAR content has changed and so the subsequent class loads will fail.

Reproducer:

$ php box.phar compile && php pie.phar self-update --nightly
<box compile snipped>
🥧 PHP Installer for Extensions (PIE) 0.11.0@5d7fa4f, from The PHP Foundation
You are running PHP 8.4.6
Target PHP installation: 8.4.6 nts, on Linux/OSX/etc x86_64 (from /usr/bin/php8.4)
Downloading the latest nightly release.
✅ Verified the new PIE version
✅ PIE has been upgraded to nightly
icense information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Composer\Util;

use Composer\XdebugHandler\XdebugHandler;

/**
 * Provides ini file location functions that work with and without a restart.
 * When the process has restarted it uses a tmp ini and stores the original
 * ini locations in an environment variable.
 *
 * @author John Stevenson <john-stevenson@blueyonder.co.uk>
 */
class IniHelper
{
 /**
 * Returns an array of php.ini locations with at least one entry
 *
 * The equivalent of calling php_ini_loaded_file then php_ini_scanned_files.
 * The loaded ini location is the first entry and may be empty.
 *
 * @return string[]
 */
 public static function getAll(): array
 {
 return XdebugHandler::getAllIniFiles();
 }

 /**
 * Describes the location of the loaded php.ini file(s)
 */
 public static function getMessage(): string
 {
 $paths = self::getAll();

 if (empty($paths[0])) {
 array_shift($paths);
 }

 $ini = array_shift($paths);

 if (empty($ini)) {
 return 'A php.ini file does not exist. You will have to create one.';
 }

 if (!ePHP Fatal error: Uncaught Error: Class "Symfony\Component\Console\Event\ConsoleTerminateEvent" not found in phar:///home/james/workspace/phpf/pie/pie.phar/vendor/symfony/console/Application.php:1110
Stack trace:
#0 phar:///home/james/workspace/phpf/pie/pie.phar/vendor/symfony/console/Application.php(324): Symfony\Component\Console\Application->doRunCommand()
#1 phar:///home/james/workspace/phpf/pie/pie.phar/vendor/symfony/console/Application.php(175): Symfony\Component\Console\Application->doRun()
#2 phar:///home/james/workspace/phpf/pie/pie.phar/bin/pie(53): Symfony\Component\Console\Application->run()
#3 /home/james/workspace/phpf/pie/pie.phar(15): require('...')
#4 {main}
 thrown in phar:///home/james/workspace/phpf/pie/pie.phar/vendor/symfony/console/Application.php on line 1110

[TimWolla]

see php/php-src#17125

[asgrim]

Ahh, thanks @TimWolla for linking to that; yes that's exactly the issue we have (Composer also had the same issue)

I think for now as a quick fix, I'm going to PR asgrim@5d7fa4f but keep this issue open.

Couple of things discussed/considered:

• "Preloading" the classes needed afterwards (e.g. in Composer ). In this case there is an event dispatched; so theoretically, if someone else (or we ourselves) extends PIE to add an additional event handler on terminate, or Symfony adds additional post-event-dispatcher code in a newer version, and forget about this issue, that would break if it loaded other classes we're not aware of. Bit of an edge case "what-about-ism" but may be possible.
• Make the overwrite of the PHAR into an event handler itself, and ensure it runs "last" in the event dispatcher. In theory, if Symfony Console adds further code that triggers class loads AFTER the event dispatcher, we are still potentially vulnerable though.
• Wait for an upstream php-src fix (may not be any time soon) and live with the exit(0); workaround, or an improved solution above.

[pronskiy]

I have the following error when trying to self-update on macOS, not sure if it's related:

$ pie self-update 
🥧 PHP Installer for Extensions (PIE) 1.0.0, from The PHP Foundation
You are running PHP 8.4.10
Target PHP installation: 8.4.10 nts, on Linux/OSX/etc arm64 (from /opt/homebrew/Cellar/php/8.4.10/bin/php)
You are currently running PIE version 1.0.0
✅ Verified the new PIE version
Password:

In Process.php line 269:
 
 The command "'/usr/bin/sudo' 'chmod' '--reference=/opt/homebrew/bin/pie' '/private/var/folders/89/dyv9lh291b7dmhx3gt7_0hqr0000gn/T 
 /pie_tmp_442n8f56nm5v7M2T12g'" failed. 
 
 Exit Code: 1(General error) 
 
 Working directory: /Users/pronskiy/projects/redditjs 
 
 Output: 
 ================ 
 
 
 Error Output: 
 ================ 
 chmod: illegal option -- - 
 usage: chmod [-fhv] [-R [-H | -L | -P]] [-a | +a | =a [i][# [ n]]] mode|entry file ... 
 chmod [-fhv] [-R [-H | -L | -P]] [-E | -C | -N | -i | -I] file ... 

[asgrim]

I have the following error when trying to self-update on macOS, not sure if it's related:

@pronskiy thanks - it is not related, I have made a new issue #320