Skip to content

(feat) : Enhance UnixBuild with proper cleanup and improved test organization - #130

Merged
asgrim merged 2 commits into
mainfrom
unknown repository
Nov 26, 2024
Merged

(feat) : Enhance UnixBuild with proper cleanup and improved test organization#130
asgrim merged 2 commits into
mainfrom
unknown repository

Conversation

@ghost

@ghostghost commented Nov 23, 2024•
edited by asgrim
Loading

Copy link
Copy Markdown

Fixes#93

This PR enhances the UnixBuild class and its tests with the following improvements:

Changes

  • Added cleanup functionality to UnixBuild to remove build artifacts
  • Refactored UnixBuildTest for better organization and maintainability
  • Added explicit tests for cleanup behavior
  • Improved error handling and verbose output

Technical Details

  • Added cleanup() method to handle make clean and phpize --clean
  • Reorganized tests with proper setup and helper methods
  • Added test cases for verbose output and cleanup scenarios
  • Improved error handling with proper cleanup in failure cases

asgrim
asgrim requested changes Nov 25, 2024
View reviewed changes
Comment threadsrc/Building/UnixBuild.php Outdated
Comment threadsrc/Building/UnixBuild.php Outdated
Comment threadtest/integration/Building/UnixBuildTest.php Outdated
Comment threadtest/integration/Building/UnixBuildTest.php
@asgrimasgrim self-assigned this Nov 25, 2024
@asgrimasgrim added the enhancement New feature or request label Nov 25, 2024
@asgrimasgrim mentioned this pull request Nov 26, 2024
Closed
@asgrimasgrim added the maintainer investigating This ticket is being investigated by maintainers. Please check with us before contributing PRs etc! label Nov 26, 2024
@asgrimasgrim removed the maintainer investigating This ticket is being investigated by maintainers. Please check with us before contributing PRs etc! label Nov 26, 2024
@asgrimasgrim added this to the 0.3.0 milestone Nov 26, 2024
@asgrim
asgrim merged commit 3abe8f5 into php:mainNov 26, 2024
@asgrim

asgrim commented Nov 26, 2024

Copy link
Copy Markdown
Contributor

Thank you @tal7aouy

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@asgrimasgrim

Labels

enhancementNew feature or request

Projects

None yet

Milestone

0.3.0

Development

Successfully merging this pull request may close these issues.

Changing configure flags for pie build does not result in a full rebuild

1 participant

@asgrim