Skip to content

Add self-update functionality - #205

Merged
asgrim merged 15 commits into
php:mainfrom
asgrim:pie-self-update
Apr 2, 2025
Merged

Add self-update functionality#205
asgrim merged 15 commits into
php:mainfrom
asgrim:pie-self-update

Conversation

@asgrim

@asgrimasgrim commented Mar 24, 2025

Copy link
Copy Markdown
Contributor

Fixes#66

@asgrimasgrim added the enhancement New feature or request label Mar 24, 2025
@asgrimasgrim added this to the 0.9.0 milestone Mar 24, 2025
@asgrimasgrim self-assigned this Mar 24, 2025
@asgrim
asgrim marked this pull request as draft March 24, 2025 10:24
TimWolla
TimWolla reviewed Apr 1, 2025
View reviewed changes
Comment threadsrc/SelfManage/Verify/FallbackVerificationUsingOpenSsl.php Outdated
Comment threadsrc/SelfManage/Verify/FallbackVerificationUsingOpenSsl.php Outdated
Comment threadsrc/SelfManage/Verify/FallbackVerificationUsingOpenSsl.php Outdated
Comment threadsrc/SelfManage/Verify/FallbackVerificationUsingOpenSsl.php Outdated
Comment threadsrc/SelfManage/Verify/FallbackVerificationUsingOpenSsl.php Outdated
@asgrim
asgrimforce-pushed the pie-self-update branch 2 times, most recently from e4f7a41 to 42a4665CompareApril 1, 2025 19:32
asgrimand others added 14 commits April 1, 2025 21:00
@asgrim
Initial structure of self-update command with skeleton of verification
2b91430
@asgrim@TimWolla
Added fallback approach for verifying downloaded PIE phar provenance
ac3e795
Co-authored-by: Tim Düsterhus <tim@tideways-gmbh.com>
@asgrim
Ensure we are running in PHAR mode before attempting self-update
9bf1174
@asgrim
Write new pie.phar to script location
a9487e9
@asgrim
Improve attestation shape verification
002c58d
@asgrim
Extract Attestation parsing into simpler VO
19fc37e
@asgrim
Split verification into method-specific classes
c3b3f83
@asgrim
Introduce VerifyPieReleaseUsingAttestation factory
19095eb
@asgrim
Added GH CLI verification using gh
4cb4923
@asgrim
Handle logic for nightly releases if requested
5876718
@asgrim
Unit tests for the new verify/update methods
bdf6e42
@asgrim
Use BAT files for Windows tests for exit differences
08f5ef5
@asgrim
Verify facts about the attestation certificate and its authenticity u…
37807de
…sing a trusted root store
@asgrim@TimWolla
Improvements for readability and correctness from PR review
5ddde91
Co-authored-by: Tim Düsterhus <tim@tideways-gmbh.com>
@asgrim
asgrim marked this pull request as ready for review April 1, 2025 20:02
@asgrim
asgrim requested a review from TimWollaApril 1, 2025 20:18
@asgrimasgrim mentioned this pull request Apr 1, 2025
Closed
TimWolla
TimWolla reviewed Apr 2, 2025
View reviewed changes

@TimWollaTimWolla left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for the two small remarks.

Comment threadsrc/SelfManage/Verify/FallbackVerificationUsingOpenSsl.php Outdated
Comment threadsrc/SelfManage/Verify/FallbackVerificationUsingOpenSsl.php Outdated
TimWolla
TimWolla reviewed Apr 2, 2025
View reviewed changes
Comment threadsrc/SelfManage/Verify/FallbackVerificationUsingOpenSsl.php Outdated
@asgrim@TimWolla
Split out and improve attestation verification from PR discussion
69e34e1
Co-authored-by: Tim Düsterhus <tim@tideways-gmbh.com>
@asgrim
asgrim merged commit bd03d4a into php:mainApr 2, 2025
@asgrim
asgrim deleted the pie-self-update branch April 2, 2025 19:43
@asgrimasgrim mentioned this pull request Sep 16, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TimWollaTimWollaTimWolla approved these changes

Assignees

@asgrimasgrim

Labels

enhancementNew feature or request

Projects

None yet

Milestone

0.9.0

Development

Successfully merging this pull request may close these issues.

PIE self-update command

2 participants

@asgrim@TimWolla