Uh oh!
There was an error while loading. Please reload this page.
Add granular publish tags for "-bin" docker image - #614
Conversation
asgrim
commented
May 15, 2026
glensc
commented
May 19, 2026
@asgrim ✅ |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
jnoordsij
commented
May 26, 2026
This fixed #480, right? However, I wonder if this implementation is entirely correct: for e.g. 1.5.0-alpha.1, this would now also update the Likely you'd want to distinguish stable and non-stable tags in some way, similar to how it's done for the floating |
asgrim
commented
May 26, 2026
yep |
glensc
commented
May 27, 2026
I suppose similar guard can added there: ${{ ((!contains(github.ref, 'alpha') && !contains(github.ref, 'beta') && !contains(github.ref, 'rc')) && 'type=raw,value=bin') || '' }} |
glensc
commented
May 27, 2026
This also needs to be backported to 1.4.x branch? |
TimWolla
commented
May 27, 2026
Besides the obvious bug with pre-release versions, I wonder what problem this is attempting to solve. Is there ever a good reason to intentionally stay on an outdated branch of PIE? |
glensc
commented
May 27, 2026
Well, this is merged to 1.5, but there are no 1.5 releases. I'm new to pie, so i'm not aware when will be 1.5.0 is released, and i would like to update my Dockerfile to 1.x branch, be it 1.4 or 1.5, not really relevant to me. i'm assuming the project follows basic semver. |
glensc
commented
May 27, 2026
Fix: It maybe not loking the nicest, it follows the same pattern, so should be easy to review |
TimWolla
commented
May 29, 2026
Yes. I am asking why we need a |
Since there is no 1.5-bin (no 1.5.x stable releases), i'd use what's available, as 1.4 seems active, so 1.4-bin Correction:
|
Implement TODO:
pie/.github/workflows/release.yml
Lines 90 to 96 in 5c3fa89
See:
PR submitter checklist
I have added appropriate testsFuture TODO
After this is merged and verified working also update documentation (another PR):