Skip to content

Adjust timeouts for invoked processes - #75

Merged
asgrim merged 1 commit into
php:mainfrom
asgrim:adjust-timeouts-for-process-invokations
Oct 24, 2024
Merged

Adjust timeouts for invoked processes#75
asgrim merged 1 commit into
php:mainfrom
asgrim:adjust-timeouts-for-process-invokations

Conversation

@asgrim

Copy link
Copy Markdown
Contributor

Fixes#72

Defaulted to 5s for all commands executed, except:

  • phpize - 1 minute
  • ./configure - 2 minutes
  • make - 10 minutes
  • make install - 1 minute

I think these are reasonable maximums, but we can adjust accordingly with the constants defined going forward, should we need to.

@asgrimasgrim added the bug Something isn't working label Oct 24, 2024
@asgrimasgrim added this to the 0.1.1 milestone Oct 24, 2024
@asgrim
asgrim merged commit c80f425 into php:mainOct 24, 2024
@asgrim
asgrim deleted the adjust-timeouts-for-process-invokations branch October 24, 2024 09:58
@asgrimasgrim modified the milestones: 0.1.1, 0.2.0Oct 24, 2024
@remicollet

Copy link
Copy Markdown
Member

make - 10 minutes

This seems short to me
Try ones of grpc, couchbase or datadog_trace on a slow computer (especially without -j option, see #73)

@asgrim

Copy link
Copy Markdown
ContributorAuthor

make - 10 minutes

This seems short to me Try ones of grpc, couchbase or datadog_trace on a slow computer (especially without -j option, see #73)

Would you be able to suggest a safer limit please?

@remicollet

Copy link
Copy Markdown
Member

Would you be able to suggest a safer limit please?

No, IMHO, this should be unlimited
Even if quite confusing, especially because of no output by default.

For me, "stalled" means no output for a few minutes (build are usually very verbose), nothing related to the whole process duration.

@asgrim

Copy link
Copy Markdown
ContributorAuthor

Thanks - I've adjusted it to be unlimited in #76

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugSomething isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The process "'make'" exceeded the timeout of 60 seconds

2 participants

@asgrim@remicollet