Uh oh!
There was an error while loading. Please reload this page.
Adjust timeouts for invoked processes - #75
Merged
Conversation
remicollet
commented
Oct 24, 2024
Member
This seems short to me |
asgrim
commented
Oct 24, 2024
ContributorAuthor
Would you be able to suggest a safer limit please? |
remicollet
commented
Oct 24, 2024
Member
No, IMHO, this should be unlimited For me, "stalled" means no output for a few minutes (build are usually very verbose), nothing related to the whole process duration. |
asgrim
commented
Oct 24, 2024
ContributorAuthor
Thanks - I've adjusted it to be unlimited in #76 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#72
Defaulted to 5s for all commands executed, except:
phpize- 1 minute./configure- 2 minutesmake- 10 minutesmake install- 1 minuteI think these are reasonable maximums, but we can adjust accordingly with the constants defined going forward, should we need to.