Skip to content

Add extension-src directive - #82

Closed
zeriyoshi wants to merge 1 commit into
php:mainfrom
zeriyoshi:add_extension_dir_support
Closed

Add extension-src directive#82
zeriyoshi wants to merge 1 commit into
php:mainfrom
zeriyoshi:add_extension_dir_support

Conversation

@zeriyoshi

Copy link
Copy Markdown
Contributor

Add extension-src directive to the php-ext section in composer.json.

This enables support for patterns where extension source code is not located in the project root, which is commonly seen in third-party extensions.

https://github.com/protocolbuffers/protobuf/tree/main/php/ext/google/protobuf

{
"name": "google/protobuf",
"type": "php-ext",
"description": "protocolbuffers php extension",
"php-ext": {
"extension-name": "protobuf",
"extension-src": "php/ext/google/protobuf"
}
}

@zeriyoshizeriyoshi changed the title Add extension-source directiveAdd extension-src directiveNov 7, 2024
@zeriyoshi

Copy link
Copy Markdown
ContributorAuthor

I don't think this test failure was caused by the change, but I'm not familiar enough with Windows to know...
https://github.com/php/pie/actions/runs/11720819724/job/32646969527?pr=82#step:6:25

@asgrim

Copy link
Copy Markdown
Contributor

@zeriyoshi thank you for this! However, I wish you had reported an issue first to discuss the requirement 😅 a lot of this code is currently being reworked at the moment to use a new pattern using the Composer Installer; it is absolutely feasible for us to accommodate this, but I'll need to take this on and rework this 😁

@asgrimasgrim self-assigned this Nov 7, 2024
@asgrimasgrim added the enhancement New feature or request label Nov 7, 2024
@asgrim
asgrim marked this pull request as draft November 7, 2024 10:59
@zeriyoshi

Copy link
Copy Markdown
ContributorAuthor

@asgrim
My apologies! I thought if you were going to make a suggestion, it would be better to have an example first (bad habit of mine).
I'm glad to know what's going on! Thank you very much!

@asgrim

Copy link
Copy Markdown
Contributor

No worries at all :) it is still useful, and not wasted effort; I'll just need to rework it a bit shortly, so I'll hold off merging for now. I should be able to take a look next week. Thank you again 🙏

@asgrim

Copy link
Copy Markdown
Contributor

Re-opened PR #115 to cover this - thanks @zeriyoshi !

@asgrimasgrim closed this Nov 19, 2024
@zeriyoshi
zeriyoshi deleted the add_extension_dir_support branch November 22, 2024 02:33
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancementNew feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@zeriyoshi@asgrim