Uh oh!
There was an error while loading. Please reload this page.
Conversation
zeriyoshi
commented
Nov 7, 2024
I don't think this test failure was caused by the change, but I'm not familiar enough with Windows to know... |
asgrim
commented
Nov 7, 2024
@zeriyoshi thank you for this! However, I wish you had reported an issue first to discuss the requirement 😅 a lot of this code is currently being reworked at the moment to use a new pattern using the Composer Installer; it is absolutely feasible for us to accommodate this, but I'll need to take this on and rework this 😁 |
zeriyoshi
commented
Nov 8, 2024
@asgrim |
asgrim
commented
Nov 8, 2024
No worries at all :) it is still useful, and not wasted effort; I'll just need to rework it a bit shortly, so I'll hold off merging for now. I should be able to take a look next week. Thank you again 🙏 |
asgrim
commented
Nov 19, 2024
Re-opened PR #115 to cover this - thanks @zeriyoshi ! |
Add
extension-srcdirective to thephp-extsection incomposer.json.This enables support for patterns where extension source code is not located in the project root, which is commonly seen in third-party extensions.
https://github.com/protocolbuffers/protobuf/tree/main/php/ext/google/protobuf