Skip to content

Canonicalises feed base URL handling - #41

Merged
derickr merged 2 commits into
php:masterfrom
NickSdot:feed-base-url
Aug 10, 2026
Merged

Canonicalises feed base URL handling#41
derickr merged 2 commits into
php:masterfrom
NickSdot:feed-base-url

Conversation

@NickSdot

@NickSdotNickSdot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Private fork follow up. Uses the configured base URL for RSS/RDF links instead of the request host header.

@NickSdotNickSdot mentioned this pull request Aug 7, 2026
Merged
jimwins
jimwins approved these changes Aug 8, 2026
View reviewed changes
Comment threadlib/config.php Outdated
@derickr
derickr merged commit 3242085 into php:masterAug 10, 2026
@NickSdot
NickSdot deleted the feed-base-url branch August 10, 2026 15:44
@jimwins

jimwins commented Aug 10, 2026

Copy link
Copy Markdown
Member

The change in README.md is not correct, news.php.net is still the correct NNTP_HOST, it's the NEWS_WEB_BASE_URL that needs to be news-web.php.net.

@NickSdotNickSdot mentioned this pull request Aug 10, 2026
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@derickrderickrderickr left review comments
@jimwinsjimwinsjimwins approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NickSdot@jimwins@derickr