Skip to content

Fix local deployement and add a new doc page - #1181

Merged
saundefined merged 3 commits into
masterfrom
fix-local-manual
Dec 11, 2024
Merged

Fix local deployement and add a new doc page#1181
saundefined merged 3 commits into
masterfrom
fix-local-manual

Conversation

@Girgias

Copy link
Copy Markdown
Member

This mainly fixes the usage of <?php manual_footer([]); ?> which doesn't pass [].

Split from #1180

And fix HTML to be readable
This page has examples with output to test the interactive code runner
@github-actions

github-actionsBot commented Dec 5, 2024

Copy link
Copy Markdown
Contributor

🚀 Regression report for commit 850039a is at https://web-php-regression-report-pr-1181.preview.thephp.foundation

@github-actions

github-actionsBot commented Dec 5, 2024

Copy link
Copy Markdown
Contributor

🚀 Preview for commit 850039a can be found at https://web-php-pr-1181.preview.thephp.foundation

@Girgias

Copy link
Copy Markdown
MemberAuthor

@saundefined can you have a look at this PR?

@saundefined

Copy link
Copy Markdown
Member

@Girgias at first glance, it's nice!

I'll look at (and probably update) the screenshot for the regression bit later, and I guess we can merge it

@saundefinedsaundefined left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@saundefined
saundefined merged commit 50202bb into masterDec 11, 2024
@saundefined
saundefined deleted the fix-local-manual branch December 11, 2024 09:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Girgias@saundefined@sy-records