Uh oh!
There was an error while loading. Please reload this page.
Enhancement: Document platform requirement in composer.json - #408
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
aaf5f14 to
009dae2Comparecomposer.json009dae2 to
cb9068aComparelocalheinz
commented
Jun 17, 2022
Are there any objections to merging this pull request? |
kamil-tekiela
commented
Jun 17, 2022
Why is composer.lock committed? |
localheinz
commented
Jun 17, 2022
cb9068a to
2de9a9cCompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
cmb69
left a comment
There was a problem hiding this comment.
I'm generally in favor of adding a composer.json, and if we declare config.platform.php, committing composer.lock appears to be a good idea as well.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
cmb69
commented
Jul 8, 2022
Thank you! |
localheinz
commented
Jul 8, 2022
Thank you, @carusogabriel, @cmb69, @Girgias, and @kamil-tekiela! |

This pull request
composer.jsonFollows #606 (comment).
💁♂️ This project currently does not use
composerto manage its dependencies, but it does not need to stay that way. Apart from usingcomposerto manage dependencies,composer.jsonalso serves documentation purposes. For a start, I propose to addcomposer.jsonwith platform requirements - we can take it from there, if that make sense for you.