Skip to content

Enhancement: Document platform requirement in composer.json - #408

Merged
cmb69 merged 1 commit into
php:masterfrom
localheinz:feature/composer
Jul 8, 2022
Merged

Enhancement: Document platform requirement in composer.json#408
cmb69 merged 1 commit into
php:masterfrom
localheinz:feature/composer

Conversation

@localheinz

@localheinzlocalheinz commented May 25, 2021

Copy link
Copy Markdown
Contributor

This pull request

  • documents the platform requirement in composer.json

Follows #606 (comment).

💁‍♂️ This project currently does not use composer to manage its dependencies, but it does not need to stay that way. Apart from using composer to manage dependencies, composer.json also serves documentation purposes. For a start, I propose to add composer.json with platform requirements - we can take it from there, if that make sense for you.

Comment threadcomposer.json Outdated
Comment threadcomposer.json Outdated
@localheinz
localheinzforce-pushed the feature/composer branch 2 times, most recently from aaf5f14 to 009dae2CompareMay 25, 2021 16:20
@localheinzlocalheinz changed the title Enhancement: Document platform requirement in composer.jsonEnhancement: Document platform requirement in composer.jsonDec 21, 2021
@localheinz

Copy link
Copy Markdown
ContributorAuthor

Are there any objections to merging this pull request?

@kamil-tekiela

Copy link
Copy Markdown
Member

Why is composer.lock committed?

@localheinz

Copy link
Copy Markdown
ContributorAuthor

Comment threadcomposer.json Outdated
Comment threadcomposer.json Outdated

@cmb69cmb69 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm generally in favor of adding a composer.json, and if we declare config.platform.php, committing composer.lock appears to be a good idea as well.

Comment threadcomposer.json
Comment threadcomposer.json Outdated
Comment threadcomposer.json Outdated
Comment threadcomposer.json

@cmb69cmb69 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This is fine for me.

Comment threadcomposer.json
@cmb69
cmb69 merged commit d47ac32 into php:masterJul 8, 2022
@cmb69

cmb69 commented Jul 8, 2022

Copy link
Copy Markdown
Member

Thank you!

@localheinz
localheinz deleted the feature/composer branch July 8, 2022 18:36
@localheinz

Copy link
Copy Markdown
ContributorAuthor

Thank you, @carusogabriel, @cmb69, @Girgias, and @kamil-tekiela!

@localheinzlocalheinz mentioned this pull request Jul 8, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@localheinz@kamil-tekiela@cmb69@Girgias@carusogabriel