Skip to content

Enhancement: Add CONTRIBUTING.md - #615

Merged
cmb69 merged 1 commit into
php:masterfrom
localheinz:feature/contributing
Jul 8, 2022
Merged

Enhancement: Add CONTRIBUTING.md#615
cmb69 merged 1 commit into
php:masterfrom
localheinz:feature/contributing

Conversation

@localheinz

Copy link
Copy Markdown
Contributor

@localheinz
localheinzforce-pushed the feature/contributing branch 2 times, most recently from f053207 to f63017aCompareJuly 5, 2022 12:32
Comment thread.github/CONTRIBUTING.md Outdated
Comment thread.github/CONTRIBUTING.md Outdated
@localheinz
localheinzforce-pushed the feature/contributing branch from f63017a to 533908cCompareJuly 5, 2022 12:43
@cmb69

cmb69 commented Jul 5, 2022

Copy link
Copy Markdown
Member

Thank you! This is certainly a good start, but what about:

  • Steps for creating good issues or pull requests.
  • Links to external documentation, mailing lists, or a code of conduct.
  • Community and behavioral expectations.

I think at least the first item should be addressed right away.

@localheinz

Copy link
Copy Markdown
ContributorAuthor

@localheinz

Copy link
Copy Markdown
ContributorAuthor

@kamil-tekiela

Copy link
Copy Markdown
Member

It would be good to have a guide similar to https://github.com/php/php-src/blob/master/CONTRIBUTING.md but shorter.

@cmb69

cmb69 commented Jul 5, 2022

Copy link
Copy Markdown
Member

Issue templates might be useful, but some more general info (like in php-src's CONTRIBUTING.md as @kamil-tekiela pointed out) should be good for now.

Regarding a CoC: IIRC that was discussed quite a while ago for php-src, but went nowhere. I'm afraid the situation would be the same for web-php.

@localheinz
localheinzforce-pushed the feature/contributing branch from 533908c to b79dcccCompareJuly 8, 2022 12:00
@localheinz

Copy link
Copy Markdown
ContributorAuthor

@cmb69@kamil-tekiela

Updated CONTRIBUTING.md based on CONTRIBUTING.md of php/php-src!

@localheinzlocalheinz mentioned this pull request Jul 8, 2022
1 task
- Run

```
php tests/run-tests.php -q --show-diff

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also see #621.

5. Test your changes before committing them. We mean it. Really. To do so use

```
php tests/run-tests.php -q --show-diff`.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also see #621.

@cmb69cmb69 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Much better, in my opinion, but still a few tweaks could be applied.

Comment thread.github/CONTRIBUTING.md Outdated
Comment thread.github/CONTRIBUTING.md Outdated
Comment thread.github/CONTRIBUTING.md Outdated
Comment thread.github/CONTRIBUTING.md Outdated
Co-authored-by: Andreas Möller <am@localheinz.com>
Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de>
@localheinz
localheinzforce-pushed the feature/contributing branch from ad07c94 to cc4ce07CompareJuly 8, 2022 20:37
@localheinz

Copy link
Copy Markdown
ContributorAuthor

@cmb69@kamil-tekiela

Adjusted!

@cmb69
cmb69 merged commit 83ef234 into php:masterJul 8, 2022
@cmb69

cmb69 commented Jul 8, 2022

Copy link
Copy Markdown
Member

Thank you, @localheinz! Wrt. #621, we can adjust CONTRIBUTING.md later.

@localheinz
localheinz deleted the feature/contributing branch July 8, 2022 21:33
@localheinz

Copy link
Copy Markdown
ContributorAuthor

Thank you, @cmb69 and @kamil-tekiela!

@localheinzlocalheinz mentioned this pull request Jul 8, 2022
1 task
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@localheinz@cmb69@kamil-tekiela