Uh oh!
There was an error while loading. Please reload this page.
Enhancement: Add CONTRIBUTING.md - #615
Conversation
f053207 to
f63017aCompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
f63017a to
533908cComparecmb69
commented
Jul 5, 2022
Thank you! This is certainly a good start, but what about:
I think at least the first item should be addressed right away. |
localheinz
commented
Jul 5, 2022
Perhaps the first item could be better addressed with https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/about-issue-and-pull-request-templates? |
localheinz
commented
Jul 5, 2022
For the third item, this probably helps: https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/adding-a-code-of-conduct-to-your-project. |
kamil-tekiela
commented
Jul 5, 2022
It would be good to have a guide similar to https://github.com/php/php-src/blob/master/CONTRIBUTING.md but shorter. |
cmb69
commented
Jul 5, 2022
Issue templates might be useful, but some more general info (like in php-src's CONTRIBUTING.md as @kamil-tekiela pointed out) should be good for now. Regarding a CoC: IIRC that was discussed quite a while ago for php-src, but went nowhere. I'm afraid the situation would be the same for web-php. |
533908c to
b79dcccComparelocalheinz
commented
Jul 8, 2022
Updated |
| - Run | ||
| ``` | ||
| php tests/run-tests.php -q --show-diff |
| 5. Test your changes before committing them. We mean it. Really. To do so use | ||
| ``` | ||
| php tests/run-tests.php -q --show-diff`. |
cmb69
left a comment
There was a problem hiding this comment.
Thank you! Much better, in my opinion, but still a few tweaks could be applied.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Andreas Möller <am@localheinz.com> Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de>
ad07c94 to
cc4ce07Comparelocalheinz
commented
Jul 8, 2022
Adjusted! |
Thank you, @localheinz! Wrt. #621, we can adjust CONTRIBUTING.md later. |
localheinz
commented
Jul 8, 2022
Thank you, @cmb69 and @kamil-tekiela! |
This pull request
CONTRIBUTING.md💁♂️ For reference, see https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/setting-guidelines-for-repository-contributors#adding-a-contributing-file.