Uh oh!
There was an error while loading. Please reload this page.
Enhancement: Enable method_argument_space fixer - #648
Closed
localheinz wants to merge 2 commits into
Closed
Conversation
localheinz
commented
Jul 12, 2022
Uh oh!
There was an error while loading. Please reload this page.
cmb69
reviewed
Jul 12, 2022
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Comment on lines
-47
to
+49
| 'htmlspecialchars($string, ENT_COMPAT | ENT_HTML401, \'UTF-8\', false);' | ||
| );?> | ||
| 'htmlspecialchars($string, ENT_COMPAT | ENT_HTML401, \'UTF-8\', false);' | ||
| );?> |
Member
There was a problem hiding this comment.
Note sure about that, and the next one in this file.
Comment on lines
-46
to
+48
| 'htmlspecialchars($string, ENT_COMPAT | ENT_HTML401, \'UTF-8\', false);' | ||
| );?> | ||
| 'htmlspecialchars($string, ENT_COMPAT | ENT_HTML401, \'UTF-8\', false);' | ||
| );?> |
Comment on lines
-45
to
+47
| 'htmlspecialchars($string, ENT_COMPAT | ENT_HTML401, \'UTF-8\', false);' | ||
| );?> | ||
| 'htmlspecialchars($string, ENT_COMPAT | ENT_HTML401, \'UTF-8\', false);' | ||
| );?> |
Comment on lines
-48
to
+50
| 'htmlspecialchars($string, ENT_COMPAT | ENT_HTML401, \'UTF-8\', false);' | ||
| );?> | ||
| 'htmlspecialchars($string, ENT_COMPAT | ENT_HTML401, \'UTF-8\', false);' | ||
| );?> |
Comment on lines
-47
to
+49
| 'htmlspecialchars($string, ENT_COMPAT | ENT_HTML401, \'UTF-8\', false);' | ||
| );?> | ||
| 'htmlspecialchars($string, ENT_COMPAT | ENT_HTML401, \'UTF-8\', false);' | ||
| );?> |
Comment on lines
-44
to
+46
| 'htmlspecialchars($string, ENT_COMPAT | ENT_HTML401, \'UTF-8\', false);' | ||
| );?> | ||
| 'htmlspecialchars($string, ENT_COMPAT | ENT_HTML401, \'UTF-8\', false);' | ||
| );?> |
Comment on lines
-44
to
+46
| 'htmlspecialchars($string, ENT_COMPAT | ENT_HTML401, \'UTF-8\', false);' | ||
| );?> | ||
| 'htmlspecialchars($string, ENT_COMPAT | ENT_HTML401, \'UTF-8\', false);' | ||
| );?> |
ContributorAuthor
There was a problem hiding this comment.
Yes, they look all off - hmm.
Member
There was a problem hiding this comment.
A possibly working quick fix might be to unindent the <?php highlight_php_trimmed( lines. Although it would probably be better to move the highlighting to JS.
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Jul 12, 2022
localheinzforce-pushed
the
feature/method-argument-space
branch
from
July 12, 2022 12:49
100e339 to
cedd04cComparelocalheinzforce-pushed
the
feature/method-argument-space
branch
from
August 21, 2022 21:21
5d7fbd6 to
0dd4966Comparederickr
commented
Nov 29, 2023
Member
This has many conflicts. |
localheinzforce-pushed
the
feature/method-argument-space
branch
from
December 5, 2023 12:33
d13a435 to
e012211Comparelocalheinzforce-pushed
the
feature/method-argument-space
branch
3 times, most recently
from
December 5, 2023 15:20
9cf26ab to
e075a20Comparelocalheinzforce-pushed
the
feature/method-argument-space
branch
from
December 5, 2023 15:20
e075a20 to
29484f9Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request
method_argument_spacefixermake coding-standardsFollows #559.
💁♂️ For reference, see https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/v3.40.2/doc/rules/function_notation/method_argument_space.rst.