Skip to content

Enhancement: Enable blank_line_after_opening_tag fixer - #875

Merged
kamil-tekiela merged 2 commits into
php:masterfrom
localheinz:feature/blank-line-after-opening-tag
Dec 7, 2023
Merged

Enhancement: Enable blank_line_after_opening_tag fixer#875
kamil-tekiela merged 2 commits into
php:masterfrom
localheinz:feature/blank-line-after-opening-tag

Conversation

@localheinz

@localheinzlocalheinz commented Dec 7, 2023

Copy link
Copy Markdown
Contributor

This pull request

  • enables the blank_line_after_opening_tag fixer
  • runs make coding-standards

Follows #559.

💁‍♂️ For reference, see https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/blob/v3.40.2/doc/rules/php_tag/blank_line_after_opening_tag.rst.

@localheinzlocalheinz mentioned this pull request Dec 7, 2023
1 task
@derickr

Copy link
Copy Markdown
Member

I don't understand why you'd want the blank line here? It seems useless.

@localheinz
localheinzforce-pushed the feature/blank-line-after-opening-tag branch from b704bb7 to 4fba76dCompareDecember 7, 2023 11:50
Comment threadindex.php Outdated
@localheinz
localheinzforce-pushed the feature/blank-line-after-opening-tag branch from 5bebc58 to 1a51c97CompareDecember 7, 2023 15:46
@kamil-tekiela
kamil-tekiela merged commit 59c070f into php:masterDec 7, 2023
@localheinz
localheinz deleted the feature/blank-line-after-opening-tag branch December 7, 2023 16:02
@localheinz

Copy link
Copy Markdown
ContributorAuthor

Thank you, @derickr and @kamil-tekiela!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@localheinz@derickr@kamil-tekiela