Skip to content

Improve the conversion of arrays to strings - #274

Merged
jaapio merged 5 commits into
phpDocumentor:2.xfrom
mspirkov:improve-array-to-string-conversion
Dec 22, 2025
Merged

Improve the conversion of arrays to strings#274
jaapio merged 5 commits into
phpDocumentor:2.xfrom
mspirkov:improve-array-to-string-conversion

Conversation

@mspirkov

@mspirkovmspirkov commented Dec 12, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@mspirkov
mspirkov marked this pull request as ready for review December 12, 2025 10:41
@mspirkovmspirkov mentioned this pull request Dec 12, 2025
Closed
jaapio
jaapio reviewed Dec 13, 2025
View reviewed changes
Comment threadsrc/Types/AbstractList.php Outdated
Comment on lines +91 to +92
!preg_match('/[^\w\\\\]/', (string) $this->valueType) ||
substr((string) $this->valueType, -2, 2) === '[]'

@jaapiojaapioDec 13, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to match on [] in the middle of a type?

@mspirkovmspirkovDec 13, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't quite understand the question

@mspirkovmspirkovDec 13, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this to handle multidimensional arrays correctly. For example, string[][]

@mspirkov

mspirkov commented Dec 13, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

I suggest moving all this logic to Array_ before releasing the second version.
It doesn't seem right to me to keep this logic here, when it's only needed for Array_

@mspirkov
mspirkov marked this pull request as draft December 13, 2025 19:58
@mspirkov
mspirkov marked this pull request as ready for review December 13, 2025 20:06
@mspirkov

mspirkov commented Dec 13, 2025

Copy link
Copy Markdown
ContributorAuthor

I suggest moving all this logic to Array_ before releasing the second version.

Done.

@mspirkov

mspirkov commented Dec 16, 2025

Copy link
Copy Markdown
ContributorAuthor

Ready for review

@mspirkov

mspirkov commented Dec 18, 2025

Copy link
Copy Markdown
ContributorAuthor

@jaapio Please take a look

@jaapio
jaapio merged commit 04298b7 into phpDocumentor:2.xDec 22, 2025
29 checks passed
@jaapio

jaapio commented Dec 22, 2025

Copy link
Copy Markdown
Member

Sorry this took longer than you are used to. Thanks for this change!

@xabbuhxabbuh mentioned this pull request Dec 29, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaapiojaapiojaapio left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mspirkov@jaapio