Uh oh!
There was an error while loading. Please reload this page.
[BUGFIX] Load an existing config file in the unit tests - #32
Merged
Conversation
48 tasks
michield
commented
Feb 3, 2017
Member
Can you redo this one? It doesn't merge cleanly currently. |
The unit tests still do not pass completely as they cannot connect to any DB on Travis yet. This will be part of a separate PR. (And unit tests should not connect to a real database.)
oliverklee
commented
Feb 3, 2017
ContributorAuthor
I've rebased, resolved the conflicts, and repushed. |
oliverklee
commented
Feb 3, 2017
ContributorAuthor
@michield When merging, I propose using the "squash and merge" option instead of "create a merge commit". This will help keep the history clean. Thanks! |
michield
commented
Feb 3, 2017
Member
ok, will do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unit tests still do not pass completely as they cannot connect to any
DB on Travis yet. This will be part of a separate PR.
(And unit tests should not connect to a real database.)