Skip to content

[CLEANUP] Use environment variables for the DB credentials - #75

Merged
samtuke merged 1 commit into
masterfrom
cleanup/db-env
Jun 23, 2017
Merged

[CLEANUP] Use environment variables for the DB credentials#75
samtuke merged 1 commit into
masterfrom
cleanup/db-env

Conversation

@oliverklee

@oliverkleeoliverklee commented Jun 22, 2017

Copy link
Copy Markdown
Contributor

No description provided.

@oliverkleeoliverklee self-assigned this Jun 22, 2017
@oliverklee
oliverklee requested a review from samtukeJune 22, 2017 16:32
@oliverklee

oliverklee commented Jun 22, 2017

Copy link
Copy Markdown
ContributorAuthor

I'm not quite sure about the syntax (both of the .travis.yml as well as the usage of environment variables) and will appreciate a critical pair of eyes!

@samtuke

samtuke commented Jun 22, 2017

Copy link
Copy Markdown
Collaborator

The best way to check the syntax is to see if travis will run it, it seems to me. I'm not a Travis config expert, so either we merge this and take the risk or wait for Michiel to review. I vote for the first option. Any risks I've overlooked?

@oliverklee

oliverklee commented Jun 22, 2017

Copy link
Copy Markdown
ContributorAuthor

Well, it's green on Travis (we can see this without merging). But please wait, I'll read up on YAML syntax first to make sure I really understand what I'm doing here.

@oliverkleeoliverklee changed the title [CLEANUP] Use environment variables for the DB credentials[WIP][CLEANUP] Use environment variables for the DB credentialsJun 22, 2017
@oliverklee

oliverklee commented Jun 23, 2017•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

According to https://docs.travis-ci.com/user/environment-variables/ , this syntax is correct. So if the gets a positive review, it can be merged.

@oliverkleeoliverklee changed the title [WIP][CLEANUP] Use environment variables for the DB credentials[CLEANUP] Use environment variables for the DB credentialsJun 23, 2017
@oliverkleeoliverklee mentioned this pull request Jun 23, 2017
Merged
@samtuke
samtuke merged commit 118cc7f into masterJun 23, 2017
@samtuke
samtuke deleted the cleanup/db-env branch June 23, 2017 11:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samtukesamtukesamtuke approved these changes

Assignees

@oliverkleeoliverklee

Labels

cleanup

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oliverklee@samtuke