Skip to content

Do not pass --with-icu-dir to PHP 7.4 - #1032

Merged
morozov merged 1 commit into
phpbrew:masterfrom
morozov:php74-icu
Jul 29, 2019
Merged

Do not pass --with-icu-dir to PHP 7.4#1032
morozov merged 1 commit into
phpbrew:masterfrom
morozov:php74-icu

Conversation

@morozov

@morozovmorozov commented Jul 25, 2019

Copy link
Copy Markdown
Contributor

PHP 7.4 no longer supports --with-icu-dir (php/php-src#3701).

@coveralls

coveralls commented Jul 25, 2019

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.004%) to 40.974% when pulling 7ccf95e on morozov:php74-icu into e5cf9af on phpbrew:master.

@morozov
morozov requested review from c9s and jhdxrJuly 26, 2019 15:41
jhdxr
jhdxr approved these changes Jul 29, 2019
View reviewed changes

@jhdxrjhdxr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morozov
morozov merged commit bceaee1 into phpbrew:masterJul 29, 2019
@morozov
morozov deleted the php74-icu branch July 29, 2019 07:55
@morozovmorozov self-assigned this Nov 1, 2019
@morozovmorozov added this to the Release 1.24 milestone Nov 27, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhdxrjhdxrjhdxr approved these changes
@c9sc9sAwaiting requested review from c9s

Assignees

@morozovmorozov

Labels

ImprovementPHP 7.4

Projects

None yet

Milestone

Release 1.24.0

Development

Successfully merging this pull request may close these issues.

3 participants

@morozov@coveralls@jhdxr