Skip to content

Insufficient space export exception - #20017

Merged
williamdes merged 3 commits into
phpmyadmin:masterfrom
kamil-tekiela:InsufficientSpaceExportException
Jan 17, 2026
Merged

Insufficient space export exception#20017
williamdes merged 3 commits into
phpmyadmin:masterfrom
kamil-tekiela:InsufficientSpaceExportException

Conversation

@kamil-tekiela

Copy link
Copy Markdown
Contributor

This refactors all Export plugins. All methods now return void instead of bool. There were only two reasons when any of these methods would return false:

  • when OutputHandler has insufficient disk space to save file
  • when ExportJson cannot json_encode the output

ExportException exception was reused to handle these two cases. In the next PR, json_encode handling can be improved.

Comment threadsrc/Plugins/Export/ExportJson.php
Comment threadsrc/Plugins/Export/ExportPhparray.php
Comment threadsrc/Plugins/Export/ExportTexytext.php
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
@kamil-tekiela
kamil-tekielaforce-pushed the InsufficientSpaceExportException branch from 04a214a to a3744fdCompareJanuary 15, 2026 21:29

@williamdeswilliamdes left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you !

@williamdeswilliamdes added this to the 6.0.0 milestone Jan 17, 2026
@williamdeswilliamdes self-assigned this Jan 17, 2026
@williamdes
williamdes merged commit 79061b5 into phpmyadmin:masterJan 17, 2026
37 of 42 checks passed
@kamil-tekiela
kamil-tekiela deleted the InsufficientSpaceExportException branch January 17, 2026 16:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@kamil-tekiela@williamdes@liviuconcioiu