Skip to content

Remove getModels suppression and enrich identity misses - #21

Merged
alexstandiford merged 2 commits into
mainfrom
fix/strict-create-reread-errors
Apr 16, 2026
Merged

Remove getModels suppression and enrich identity misses#21
alexstandiford merged 2 commits into
mainfrom
fix/strict-create-reread-errors

Conversation

@alexstandiford

@alexstandifordalexstandiford commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

Summary

  • remove the getModels() suppression path so datastore reread failures throw directly
  • keep create() from degrading reread failures into follow-on null states
  • enrich compound-identity misses with the table name and requested identity payload
  • add unit coverage for the reread failure and missing-record identity paths

Why

The hidden obligation failure on Siren showed that swallowing datastore reread errors was the wrong behavior. If the reread fails, that should be the failure. And if an identity lookup misses, the exception should say which table and identity were involved.

Testing

  • vendor/bin/phpunit tests/Unit/Traits/WithDatastoreHandlerMethodsTest.php

@alexstandifordalexstandiford changed the title Rethrow create hydration reread failures before RecordCreatedRemove getModels suppression and enrich identity missesApr 16, 2026
@alexstandiford
alexstandiford merged commit 7608934 into mainApr 16, 2026
1 of 3 checks passed
@alexstandiford
alexstandiford deleted the fix/strict-create-reread-errors branch April 16, 2026 04:29
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@alexstandiford