Uh oh!
There was an error while loading. Please reload this page.
Remove Reflector from StubFilesExtensionLoader - #747
Merged
Conversation
xificurkforce-pushed
the
stub-loader-without-reflection
branch
3 times, most recently
from
May 7, 2026 22:37
56efd04 to
27635c4CompareUh oh!
There was an error while loading. Please reload this page.
staabm
commented
May 9, 2026
Contributor
please remove the test again. we will cover it in phpstan/phpstan-src#5617 |
Replace the expensive `reflectClass('...ServiceEntityRepository')` call with a
cheap `InstalledVersions::getVersion('doctrine/doctrine-bundle')` + `version_compare`
check. LazyServiceEntityRepository became ServiceEntityRepository's parent in
DoctrineBundle 2.8.1, so the version threshold is exact.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>xificurkforce-pushed
the
stub-loader-without-reflection
branch
from
May 9, 2026 08:07
70c5abf to
fe4eefaComparexificurk
commented
May 9, 2026
ContributorAuthor
Done, PR is fix only now. |
Uh oh!
There was an error while loading. Please reload this page.
staabm
commented
May 9, 2026
Contributor
thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the expensive
reflectClass('...ServiceEntityRepository')call with a cheapInstalledVersions::getVersion('doctrine/doctrine-bundle')+version_comparecheck. LazyServiceEntityRepository became ServiceEntityRepository's parent in DoctrineBundle 2.8.1 and was removed in 3.0.0, so the version threshold is exact.Add StubFilesExtensionLoaderTest with ThrowingSourceLocator registered as
betterReflectionSourceLocatorin the test container — any future attempt to re-introduce reflectClass() in getFiles() will immediately throw.--
Related:
phpstan/phpstan-src#5577
phpstan/phpstan-src#5538 (comment)