Skip to content

Html: proper types for setHtml and addHtml methods – same as insert() method - #128

Open
vitkutny wants to merge 2 commits into
phpstan:1.1.xfrom
vilgain:html-stub-update
Open

Html: proper types for setHtml and addHtml methods – same as insert() method#128
vitkutny wants to merge 2 commits into
phpstan:1.1.xfrom
vilgain:html-stub-update

Conversation

@vitkutny

Copy link
Copy Markdown

fixes Nette\Utils\Html::insert(): Argument #2 ($child) must be of type Nette\HtmlStringable|string, XY given

@ondrejmirtes

Copy link
Copy Markdown
Member

Please show a piece of code for which "Nette\Utils\Html::insert(): Argument #2 ($child) must be of type Nette\HtmlStringable|string, XY given" is currently reported and which this PR should fix.

Also - did you first try to send a PR to https://github.com/nette/utils?

@vitkutny

Copy link
Copy Markdown
Author

Please show a piece of code for which "Nette\Utils\Html::insert(): Argument #2 ($child) must be of type Nette\HtmlStringable|string, XY given" is currently reported and which this PR should fix.

addHtml method only calls insert method with parameter type HtmlStringable|string. This stub update prevents from passing only \Stringable (or any other type than HtmlStringable|string) into addHtml

namespaceNette\Utils;
class Html implements \ArrayAccess, \Countable, \IteratorAggregate, HtmlStringable
{
/** * Adds new element's child. */finalpublicfunctionaddHtml(mixed$child): static
{
return$this->insert(null, $child);
}
/** * Inserts child node. */publicfunctioninsert(?int$index, HtmlStringable|string$child, bool$replace = false): static
{
}
}

Also - did you first try to send a PR to https://github.com/nette/utils?

Right, I did not. I will :-)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@vitkutny@ondrejmirtes