Memoize expensive calls to docComments.

[pyguerder]

I ran multiple tests using Blackfire. Memoizing these expensive calls reduces both RAM consumption & execution time.

This is an example with running on https://github.com/pyguerder/phpstan-propel2-example/blob/master/generated-classes/App/AnalyzeMe2.php only: https://blackfire.io/profiles/compare/7f25525d-0676-40b8-a809-a92692106be6/graph

And this is an example running on my main project (154 classes): https://blackfire.io/profiles/compare/7cc0ea82-3727-4a95-b948-112678bc0991/graph

@ondrejmirtes can you please have a look at this?

Thanks in advance, best regards

[ondrejmirtes]

Hi, this looks promising, thanks!

[ondrejmirtes]

I'd like to use a control structure (an if) here instead of just ?? on a single line. Like this:

if ($this->reflectionDocComment !== null) {
$docComment = $this->reflectionDocComment;
} else {
$docComment = $this->reflection->getDocComment();
$this->reflectionDocComment = $docComment;
}

[ondrejmirtes]

And the same here.

[pyguerder]

@ondrejmirtes thanks for your feedback! Can you please look at it again?

I don't understand why some tests fail. I'm not sure it is related to my changes... Can you please advise?

[ondrejmirtes]

Master is broken, it's not your fault 😊

[ondrejmirtes]

Thank you!