[ReturnTypeExtension] add test case for narrow typed json_decode by TomasVotruba · Pull Request #993 · phpstan/phpstan-src

TomasVotruba · 2022-02-04T14:15:22Z

Port of https://github.com/phpstan/phpstan-nette/pull/89/files for json_decode()

Any feedback appreciated 👍

How to test?

vendor/bin/phpunit tests/PHPStan/Analyser/NodeScopeResolverTest.php --filter "json"

TomasVotruba · 2022-02-06T14:29:47Z

I'm working on the static errors...

ondrejmirtes · 2022-03-24T13:27:44Z

Feel free to open a new PR if you ever decide to work on this again 👍 Thanks.

TomasVotruba · 2022-03-24T14:00:49Z

It's ready from my side 👍

I'm actually waiting for feedback last 2 months:

ondrejmirtes · 2022-03-24T14:02:53Z

It is not - there were conflicts and build failures.

ondrejmirtes

and please fix the conflict by cleanly rebasing the branch on top of 1.5.x. I'll review it once the build is green. Thanks.

TomasVotruba · 2022-03-24T14:05:11Z

I'm on it 👍

TomasVotruba · 2022-03-24T14:18:40Z

I've rebased. Tests, PHPStan and coding standards are passing localy.

Seems GitHub Actions are crashing now because cache is stuck: https://github.com/phpstan/phpstan-src/runs/5677735280?check_suite_focus=true

I'll check it today/tomorrow

TomasVotruba · 2022-03-26T22:44:56Z

CI is passing 👍
What is now missing from my side?

…e from contssant string value

Co-authored-by: Martin Herndl <martin@herndl.org>

ondrejmirtes · 2022-05-04T06:37:48Z

Thank you!

TomasVotruba · 2022-05-04T06:49:33Z

👍

@herndlm Thank you for finishing 👏

herndlm · 2022-05-04T06:55:49Z

Nice, thank you too. I was waiting for this getting merged, have a tiny follow-up idea :)

TomasVotruba marked this pull request as ready for review February 4, 2022 14:15

ondrejmirtes requested changes Feb 4, 2022
View reviewed changes

Comment threadsrc/Type/Php/JsonThrowOnErrorDynamicReturnTypeExtension.php Outdated

TomasVotruba force-pushed the tv-json-decode-narrow-type branch from 96ca0b7 to f682afaCompare February 4, 2022 16:29

ondrejmirtes requested changes Feb 6, 2022
View reviewed changes

Comment threadsrc/Type/Php/JsonThrowOnErrorDynamicReturnTypeExtension.php Outdated
Comment threadtests/PHPStan/Analyser/data/json-decode/narrow_type_with_force_array.php Outdated
Comment threadtests/PHPStan/Analyser/data/json-decode/narrow_type_with_force_array.php Outdated

TomasVotruba force-pushed the tv-json-decode-narrow-type branch 3 times, most recently from 5547fb8 to 55cc2d4Compare February 6, 2022 12:40

TomasVotruba requested a review from ondrejmirtes February 7, 2022 00:18

ondrejmirtes force-pushed the 1.5.x branch 3 times, most recently from ddd20b4 to 95d480bCompare March 18, 2022 19:53

ondrejmirtes closed this Mar 24, 2022

ondrejmirtes reopened this Mar 24, 2022

ondrejmirtes requested changes Mar 24, 2022
View reviewed changes

Comment threadcomposer.json Outdated

TomasVotruba force-pushed the tv-json-decode-narrow-type branch 3 times, most recently from 2e46788 to aafd2a3Compare March 24, 2022 14:14

TomasVotruba force-pushed the tv-json-decode-narrow-type branch 5 times, most recently from 1cac3b6 to 834eff1Compare March 24, 2022 17:39

ondrejmirtes force-pushed the tv-json-decode-narrow-type branch from 834eff1 to 2aa201aCompare March 25, 2022 06:31

herndlm force-pushed the tv-json-decode-narrow-type branch from b8357ff to 961f9c2Compare May 2, 2022 08:43

TomasVotrubaand others added 21 commits May 3, 2022 17:56

add test case for narrow typed json_decode
c4e495a

Extend JsonThrowOnErrorDynamicReturnTypeExtension to detect knonw typ…
38ca032
…e from contssant string value

update type in LegacyNodeScopeResolverTest
6d4e3b3

return mixed type
581f51a

add json_decode false
d665722

check for JSON_OBJECT_AS_ARRAY, in case of null and array
b2b979b

add test case for invalid json string
665e9da

add test for multiple flags
66e3aa0

decopule type resolution to static
1a124ea

check if JSON_THROW_ON_ERROR exists before infer
bea4f29

[ci] add json to composer require checker json
8748e9c

use bitwiseFlagAnalyser
43eb542

fixup! use bitwiseFlagAnalyser
99debb9

Update src/Type/Php/JsonThrowOnErrorDynamicReturnTypeExtension.php
d707038
Co-authored-by: Martin Herndl <martin@herndl.org>

Update src/Type/Php/JsonThrowOnErrorDynamicReturnTypeExtension.php
0255425
Co-authored-by: Martin Herndl <martin@herndl.org>

fixup! fixup! use bitwiseFlagAnalyser
d586c6e

fixup! fixup! fixup! use bitwiseFlagAnalyser
98abc6f

fixup! fixup! fixup! fixup! use bitwiseFlagAnalyser
8a841fe

Simplify isForceArrayWithoutStdClass
3ad68aa

Simplify fallback type handling
741abd2

Remove unneeded var in narrowTypeForJsonDecode
7d306fb

ondrejmirtes force-pushed the tv-json-decode-narrow-type branch from 961f9c2 to 7d306fbCompare May 3, 2022 15:56

ondrejmirtes approved these changes May 3, 2022
View reviewed changes

ondrejmirtes merged commit 231990a into phpstan:1.6.xMay 4, 2022

TomasVotruba deleted the tv-json-decode-narrow-type branch May 4, 2022 06:49

herndlm mentioned this pull request May 4, 2022
Specifiy json_decode default return type #1283
Closed

Uh oh!

Conversation

TomasVotruba commented Feb 4, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to test?

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TomasVotruba commented Feb 6, 2022

Uh oh!

ondrejmirtes commented Mar 24, 2022

Uh oh!

TomasVotruba commented Mar 24, 2022

Uh oh!

ondrejmirtes commented Mar 24, 2022

Uh oh!

ondrejmirtes left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

TomasVotruba commented Mar 24, 2022

Uh oh!

TomasVotruba commented Mar 24, 2022

Uh oh!

TomasVotruba commented Mar 26, 2022

Uh oh!

ondrejmirtes commented May 4, 2022

Uh oh!

TomasVotruba commented May 4, 2022

Uh oh!

herndlm commented May 4, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

TomasVotruba commented Feb 4, 2022•
edited
Loading