Skip to content

Load more form stubs conditionally - #485

Merged
staabm merged 1 commit into
phpstan:2.0.xfrom
stof:conditional_form_stubs
Apr 24, 2026
Merged

Load more form stubs conditionally#485
staabm merged 1 commit into
phpstan:2.0.xfrom
stof:conditional_form_stubs

Conversation

@stof

@stofstof commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

The FormView has upstream types. (needed as dependencies of form type stubs)
The exception stubs are only needed as dependencies of the DataTransformerInterface stubs.

I missed those in #481.

@VincentLangletVincentLanglet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FormView stub is used in the generics

See phpstan build

@stof

stof commented Apr 22, 2026

Copy link
Copy Markdown
ContributorAuthor

I'll revert that part then. Seems like I did not actually missed it in the previous PR.

@stof
stofforce-pushed the conditional_form_stubs branch from 6247922 to b05e4ccCompareApril 24, 2026 09:15
The exception stubs are only needed as dependencies of the
`DataTransformerInterface` stubs.
@stof
stofforce-pushed the conditional_form_stubs branch from b05e4cc to 9087e0cCompareApril 24, 2026 09:16
@stof

stof commented Apr 24, 2026

Copy link
Copy Markdown
ContributorAuthor

@VincentLanglet I updated the PR to keep the FormView stub

@staabm
staabm merged commit 809c1e6 into phpstan:2.0.xApr 24, 2026
43 checks passed
@staabm

Copy link
Copy Markdown
Contributor

Thank you

@stof
stof deleted the conditional_form_stubs branch April 24, 2026 11:44
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@stof@staabm@VincentLanglet