Skip to content

Added checks around trick#2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gilescope wants to merge 9 commits into from
Closed

Added checks around trick #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1bbaae2
musings on scailing up trick2
gilescope Mar 31, 2021
b5413b1
adding in checks.
gilescope Mar 31, 2021
ee3fe21
Added checks to make sure digits between 0-9.
gilescope Apr 2, 2021
21e8be8
better naming
gilescope Apr 2, 2021
85c4378
removing the other way to not confuse things.
gilescope Apr 2, 2021
340a627
Oops this one was commented out.
gilescope Apr 2, 2021
bcaa087
Prev version was unsafe using uninitialised memory.
gilescope Apr 2, 2021
96f11bd
sign checks for '+' in u64
gilescope Apr 3, 2021
4505409
bugfix / simplification.
gilescope Apr 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
181 changes: 103 additions & 78 deletions benches/bench.rs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,82 +7,83 @@ use test::{black_box, Bencher};
const EXAMPLE_TIMESTAMP: &str = "1585201087123789";
const EXPECTED_TIMESTAMP: u64 = 1585201087123789;

#[bench]
fn bench_str_parse(b: &mut Bencher) {
assert_eq!(str_parse(EXAMPLE_TIMESTAMP), EXPECTED_TIMESTAMP);
b.bytes = EXAMPLE_TIMESTAMP.len() as u64;
b.iter(|| str_parse(black_box(EXAMPLE_TIMESTAMP)));
}

#[bench]
fn bench_naive_chars(b: &mut Bencher) {
assert_eq!(naive_chars(EXAMPLE_TIMESTAMP), EXPECTED_TIMESTAMP);
b.bytes = EXAMPLE_TIMESTAMP.len() as u64;
b.iter(|| naive_chars(black_box(EXAMPLE_TIMESTAMP)));
}
// #[bench]
// fn bench_str_parse(b: &mut Bencher) {
//assert_eq!(str_parse(EXAMPLE_TIMESTAMP), EXPECTED_TIMESTAMP);
// b.bytes = EXAMPLE_TIMESTAMP.len() as u64;
//b.iter(|| str_parse(black_box(EXAMPLE_TIMESTAMP)));
// }

#[bench]
fn bench_naive_chars_iter(b: &mut Bencher) {
assert_eq!(naive_chars_iter(EXAMPLE_TIMESTAMP), EXPECTED_TIMESTAMP);
b.bytes = EXAMPLE_TIMESTAMP.len() as u64;
b.iter(|| naive_chars_iter(black_box(EXAMPLE_TIMESTAMP)));
}
// #[bench]
// fn bench_naive_chars(b: &mut Bencher) {
//assert_eq!(naive_chars(EXAMPLE_TIMESTAMP), EXPECTED_TIMESTAMP);
// b.bytes = EXAMPLE_TIMESTAMP.len() as u64;
//b.iter(|| naive_chars(black_box(EXAMPLE_TIMESTAMP)));
// }

#[bench]
fn bench_naive_chars_and(b: &mut Bencher) {
assert_eq!(naive_chars_and(EXAMPLE_TIMESTAMP), EXPECTED_TIMESTAMP);
b.bytes = EXAMPLE_TIMESTAMP.len() as u64;
b.iter(|| naive_chars_and(black_box(EXAMPLE_TIMESTAMP)));
}
// #[bench]
// fn bench_naive_chars_iter(b: &mut Bencher) {
//assert_eq!(naive_chars_iter(EXAMPLE_TIMESTAMP), EXPECTED_TIMESTAMP);
// b.bytes = EXAMPLE_TIMESTAMP.len() as u64;
//b.iter(|| naive_chars_iter(black_box(EXAMPLE_TIMESTAMP)));
// }

#[bench]
fn bench_naive_bytes(b: &mut Bencher) {
assert_eq!(naive_bytes(EXAMPLE_TIMESTAMP), EXPECTED_TIMESTAMP);
b.bytes = EXAMPLE_TIMESTAMP.len() as u64;
b.iter(|| naive_bytes(black_box(EXAMPLE_TIMESTAMP)));
}
// #[bench]
// fn bench_naive_chars_and(b: &mut Bencher) {
//assert_eq!(naive_chars_and(EXAMPLE_TIMESTAMP), EXPECTED_TIMESTAMP);
// b.bytes = EXAMPLE_TIMESTAMP.len() as u64;
//b.iter(|| naive_chars_and(black_box(EXAMPLE_TIMESTAMP)));
// }

#[bench]
fn bench_naive_bytes_iter(b: &mut Bencher) {
assert_eq!(naive_bytes_iter(EXAMPLE_TIMESTAMP), EXPECTED_TIMESTAMP);
b.bytes = EXAMPLE_TIMESTAMP.len() as u64;
b.iter(|| naive_bytes_iter(black_box(EXAMPLE_TIMESTAMP)));
}
// #[bench]
// fn bench_naive_bytes(b: &mut Bencher) {
//assert_eq!(naive_bytes(EXAMPLE_TIMESTAMP), EXPECTED_TIMESTAMP);
// b.bytes = EXAMPLE_TIMESTAMP.len() as u64;
//b.iter(|| naive_bytes(black_box(EXAMPLE_TIMESTAMP)));
// }

#[bench]
fn bench_naive_bytes_and(b: &mut Bencher) {
assert_eq!(naive_bytes_and(EXAMPLE_TIMESTAMP), EXPECTED_TIMESTAMP);
b.bytes = EXAMPLE_TIMESTAMP.len() as u64;
b.iter(|| naive_bytes_and(black_box(EXAMPLE_TIMESTAMP)));
}
// #[bench]
// fn bench_naive_bytes_iter(b: &mut Bencher) {
//assert_eq!(naive_bytes_iter(EXAMPLE_TIMESTAMP), EXPECTED_TIMESTAMP);
// b.bytes = EXAMPLE_TIMESTAMP.len() as u64;
//b.iter(|| naive_bytes_iter(black_box(EXAMPLE_TIMESTAMP)));
// }

#[bench]
fn bench_naive_bytes_and_c16(b: &mut Bencher) {
assert_eq!(naive_bytes_and_c16(EXAMPLE_TIMESTAMP), EXPECTED_TIMESTAMP);
b.bytes = EXAMPLE_TIMESTAMP.len() as u64;
b.iter(|| naive_bytes_and_c16(black_box(EXAMPLE_TIMESTAMP)));
}
// #[bench]
// fn bench_naive_bytes_and(b: &mut Bencher) {
//assert_eq!(naive_bytes_and(EXAMPLE_TIMESTAMP), EXPECTED_TIMESTAMP);
// b.bytes = EXAMPLE_TIMESTAMP.len() as u64;
//b.iter(|| naive_bytes_and(black_box(EXAMPLE_TIMESTAMP)));
// }

#[bench]
fn bench_unrolled(b: &mut Bencher) {
assert_eq!(unrolled(EXAMPLE_TIMESTAMP), EXPECTED_TIMESTAMP);
b.bytes = EXAMPLE_TIMESTAMP.len() as u64;
b.iter(|| unrolled(black_box(EXAMPLE_TIMESTAMP)));
}
// #[bench]
// fn bench_naive_bytes_and_c16(b: &mut Bencher) {
//assert_eq!(naive_bytes_and_c16(EXAMPLE_TIMESTAMP), EXPECTED_TIMESTAMP);
// b.bytes = EXAMPLE_TIMESTAMP.len() as u64;
//b.iter(|| naive_bytes_and_c16(black_box(EXAMPLE_TIMESTAMP)));
// }

#[bench]
fn bench_unrolled_unsafe(b: &mut Bencher) {
assert_eq!(unrolled_unsafe(EXAMPLE_TIMESTAMP), EXPECTED_TIMESTAMP);
b.bytes = EXAMPLE_TIMESTAMP.len() as u64;
b.iter(|| unrolled_unsafe(black_box(EXAMPLE_TIMESTAMP)));
}
// #[bench]
// fn bench_unrolled(b: &mut Bencher) {
//assert_eq!(unrolled(EXAMPLE_TIMESTAMP), EXPECTED_TIMESTAMP);
// b.bytes = EXAMPLE_TIMESTAMP.len() as u64;
//b.iter(|| unrolled(black_box(EXAMPLE_TIMESTAMP)));
// }

#[bench]
fn bench_unrolled_safe(b: &mut Bencher) {
assert_eq!(unrolled_safe(EXAMPLE_TIMESTAMP), EXPECTED_TIMESTAMP);
b.bytes = EXAMPLE_TIMESTAMP.len() as u64;
b.iter(|| unrolled_safe(black_box(EXAMPLE_TIMESTAMP)));
}
// #[bench]
// fn bench_unrolled_unsafe(b: &mut Bencher) {
// assert_eq!(unrolled_unsafe(EXAMPLE_TIMESTAMP), EXPECTED_TIMESTAMP);
// b.bytes = EXAMPLE_TIMESTAMP.len() as u64;
// b.iter(|| unrolled_unsafe(black_box(EXAMPLE_TIMESTAMP)));
// }

// #[bench]
// fn bench_unrolled_safe(b: &mut Bencher) {
// assert_eq!(unrolled_safe(EXAMPLE_TIMESTAMP), EXPECTED_TIMESTAMP);
// b.bytes = EXAMPLE_TIMESTAMP.len() as u64;
// b.iter(|| unrolled_safe(black_box(EXAMPLE_TIMESTAMP)));
// }

#[bench]
fn bench_trick(b: &mut Bencher) {
Expand All@@ -92,29 +93,53 @@ fn bench_trick(b: &mut Bencher) {
}

#[bench]
fn bench_trick_128(b: &mut Bencher) {
assert_eq!(trick_128(EXAMPLE_TIMESTAMP), EXPECTED_TIMESTAMP);
fn bench_trick_with_checks(b: &mut Bencher) {
assert_eq!(trick_with_checks(EXAMPLE_TIMESTAMP), EXPECTED_TIMESTAMP);
b.bytes = EXAMPLE_TIMESTAMP.len() as u64;
b.iter(|| trick_128(black_box(EXAMPLE_TIMESTAMP)));
b.iter(|| trick_with_checks(black_box(EXAMPLE_TIMESTAMP)));
}

#[bench]
fn bench_trick_simd(b: &mut Bencher) {
assert_eq!(trick_simd(EXAMPLE_TIMESTAMP), EXPECTED_TIMESTAMP);
fn bench_trick_with_checks_small_u64(b: &mut Bencher) {
assert_eq!(parse_u64(":1234"), Err(()));
assert_eq!(parse_u64("12345"), Ok(12345u64));
assert_eq!(parse_u64("1234/"), Err(()));
assert_eq!(trick_with_checks("1234"), 1234u64);
b.bytes = "1234".len() as u64;
b.iter(|| trick_with_checks(black_box("1234")));
}

#[bench]
fn bench_trick_with_checks_i64(b: &mut Bencher) {
assert_eq!(trick_with_checks_i64(EXAMPLE_TIMESTAMP), EXPECTED_TIMESTAMP as i64);
b.bytes = EXAMPLE_TIMESTAMP.len() as u64;
b.iter(|| trick_simd(black_box(EXAMPLE_TIMESTAMP)));
b.iter(|| trick_with_checks_i64(black_box(EXAMPLE_TIMESTAMP)));
}

// #[bench]
// fn bench_trick_128(b: &mut Bencher) {
// assert_eq!(trick_128(EXAMPLE_TIMESTAMP), EXPECTED_TIMESTAMP);
// b.bytes = EXAMPLE_TIMESTAMP.len() as u64;
// b.iter(|| trick_128(black_box(EXAMPLE_TIMESTAMP)));
// }

// #[bench]
// fn bench_trick_simd(b: &mut Bencher) {
// assert_eq!(trick_simd(EXAMPLE_TIMESTAMP), EXPECTED_TIMESTAMP);
// b.bytes = EXAMPLE_TIMESTAMP.len() as u64;
// b.iter(|| trick_simd(black_box(EXAMPLE_TIMESTAMP)));
// }

// #[bench]
// fn bench_trick_simd_8(b: &mut Bencher) {
// assert_eq!(trick_simd_8(EXAMPLE_TIMESTAMP), EXPECTED_TIMESTAMP);
// b.bytes = EXAMPLE_TIMESTAMP.len() as u64;
// b.iter(|| trick_simd_8(black_box(EXAMPLE_TIMESTAMP)));
// }

#[bench]
fn bench_trick_simd_c16(b: &mut Bencher) {
assert_eq!(trick_simd_c16(EXAMPLE_TIMESTAMP), EXPECTED_TIMESTAMP);
b.bytes = EXAMPLE_TIMESTAMP.len() as u64;
b.iter(|| trick_simd_c16(black_box(EXAMPLE_TIMESTAMP)));
}
// #[bench]
// fn bench_trick_simd_c16(b: &mut Bencher) {
// assert_eq!(trick_simd_c16(EXAMPLE_TIMESTAMP), EXPECTED_TIMESTAMP);
// b.bytes = EXAMPLE_TIMESTAMP.len() as u64;
// b.iter(|| trick_simd_c16(black_box(EXAMPLE_TIMESTAMP)));
// }
Loading