Uh oh!
There was an error while loading. Please reload this page.
Added basic fan status logging - #65
Conversation
Added basic fan status logging for use with external metrics collectors (such as Telegraf)
Gadgetoid
commented
Feb 24, 2020
Thanks for taking the time to PR this. It seems like a worthwhile addition, but should probably be paired with a new argument that disables logging by default and allows users to enable it. Something like: parser.add_argument('--logging', action='store_true', help='Enable logging')Additionally it could be worth using Python's A complete implementation, I think, would use If you're up for turning this PR into a more concerted learning effort (I'm making assumptions - based on this being your first PR - that Python might be new to you!) then I'm happy to guide you through these changes. |
Sure, these are good points! This was initially very basic, as for my own purpose I really only needed to know when the fan was on or off for Telegram, I tried to add as little code as possible. But your ideas are definitely needed for a more public implementation, yes. I'm totally up for improving this PR, I'll do that as soon as I have some time. PS - no worries, Python is not new to me, it'll be fine :) But thanks! |
Added basic fan status logging for use with external metrics collectors.
Example for Telegraf: