Skip to content

Fix stale Parquet references and drop intro flow diagram - #618

Merged
arjunpatel7 merged 4 commits into
mainfrom
fix-parquet-language
Sep 4, 2026
Merged

Fix stale Parquet references and drop intro flow diagram#618
arjunpatel7 merged 4 commits into
mainfrom
fix-parquet-language

Conversation

@jennapederson

@jennapedersonjennapederson commented Sep 3, 2026

Copy link
Copy Markdown
Contributor
  • Update intro step list from Parquet to JSONL to match the schema-based/Documents API flow already used elsewhere in the notebook
  • Remove the outdated "data flow" image and its lead-in sentence
  • Fixed an issue with link checker so docs urls pointing to "latest" won't fail

Note

Low Risk
Documentation and CI allowlist changes only; no runtime product or auth logic.

Overview
Updates docs/pinecone-import.ipynb so the intro matches the notebook’s actual Documents API / JSONL bulk-import path: solution steps 3–5 now say JSONL instead of Parquet, the imports guide link points to guides/index-data/import-data, and the outdated data-flow diagram (embedded image + lead-in) is removed. pandas is added to the install cell so dependencies match the code that already uses a DataFrame.

In .github/actions/check-links/check-links.py, docs.pinecone.io/reference/api/latest/ is added to ignore_links so CI does not fail on Pinecone’s intentional “latest” API permalink redirects (scoped to that path only).

Reviewed by Cursor Bugbot for commit 4b4578b. Bugbot is set up for automated code reviews on this repo. Configure here.

- Update intro step list from Parquet to JSONL to match the
schema-based/Documents API flow already used elsewhere in the notebook
- Remove the outdated "data flow" image and its lead-in sentence
@jennapederson
jennapederson marked this pull request as ready for review September 3, 2026 22:12
@jennapederson
jennapederson requested a review from a team as a code ownerSeptember 3, 2026 22:12
The old /guides/data/understanding-imports URL is superseded by
/guides/index-data/import-data.
HEAD requests don't follow redirects by default, and this path is an
intentional 308 permalink to the current API version so links don't
need updating on every doc release. Scoped narrowly to this path only
— not a general allowance for redirecting links.
The notebook uses pd.DataFrame but the install cell never listed
pandas, so a clean environment (like the run-notebook CI action)
fails with ModuleNotFoundError. Pinned to 3.0.5 to match
docs/pinecone-reranker.ipynb.
@jennapederson

Copy link
Copy Markdown
ContributorAuthor

These failures are expected at this point as the failing link is valid and there is nothing setup to set against a storage integration with S3.

@arjunpatel7arjunpatel7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@arjunpatel7
arjunpatel7 merged commit d12615d into mainSep 4, 2026
10 of 12 checks passed
@arjunpatel7
arjunpatel7 deleted the fix-parquet-language branch September 4, 2026 21:19
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jennapederson@arjunpatel7