Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Jul 24, 2024. It is now read-only.
log_restore: refactor write and ingest logic. - #645
Merged
Conversation
3pointer
commented
Dec 15, 2020
CollaboratorAuthor
/run-integration-test |
glorv
reviewed
Dec 16, 2020
Uh oh!
There was an error while loading. Please reload this page.
glorv
reviewed
Dec 16, 2020
Uh oh!
There was an error while loading. Please reload this page.
glorv
reviewed
Dec 16, 2020
Uh oh!
There was an error while loading. Please reload this page.
glorv
reviewed
Dec 16, 2020
Uh oh!
There was an error while loading. Please reload this page.
glorv
reviewed
Dec 16, 2020
| } | ||
| switch retryTy { | ||
| case retryNone: | ||
| log.L().Warn("ingest failed and do not retry", zap.Error(err), zap.Reflect("meta", meta), |
glorv
reviewed
Dec 16, 2020
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: glorv <glorvs@163.com>
glorv
reviewed
Jan 12, 2021
Uh oh!
There was an error while loading. Please reload this page.
| // Error return current error on this iter. | ||
| Error() error | ||
| // First return the first key in this iter. | ||
| First() []byte |
Collaborator
There was a problem hiding this comment.
Suggested change
| First() []byte | |
| First() bool |
Return a bool to indicate if the key is valid
| // First return the first key in this iter. | ||
| First() []byte | ||
| // Last return the last key in this iter. | ||
| Last() []byte |
Co-authored-by: glorv <glorvs@163.com>
glorv
commented
Jan 12, 2021
Collaborator
LGTM |
kennytm
reviewed
Jan 27, 2021
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| // Copyright 2020 PingCAP, Inc. Licensed under Apache-2.0. | ||
| package restore_test | ||
| package restore |
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: kennytm <kennytm@gmail.com>
Co-authored-by: kennytm <kennytm@gmail.com>
3pointer
commented
Jan 29, 2021
CollaboratorAuthor
/run-all-tests |
kennytm
commented
Jan 29, 2021
Collaborator
/lgtm |
ti-srebot
approved these changes
Jan 29, 2021
ti-srebot pushed a commit
to ti-srebot/br
that referenced
this pull request
Jan 31, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
ti-srebot
commented
Jan 31, 2021
Contributor
cherry pick to release-4.0 in PR #729 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Both Lightning and BR have a similar logic. write and ingest kv as well as retry policy. This abstract Ingest method for BR and Lightning easy to use.
What is changed and how it works?
Ingestser.Check List
Tests
Related changes
Release Note