CI failing on syntax errors

[ottok]

Hi,

The latest CI run from 2025 failed with:

go: downloading go.uber.org/multierr v1.10.0
go: downloading github.com/davecgh/go-spew v1.1.1
go: downloading github.com/pmezard/go-difflib v1.0.0
go: downloading gopkg.in/yaml.v3 v3.0.1
# go.uber.org/multierr
Error: ../../../go/pkg/mod/go.uber.org/multierr@v1.10.0/error.go:224:13: undefined: atomic.Bool
note: module requires Go 1.19
# go.uber.org/zap/internal/pool
Error: ../../../go/pkg/mod/go.uber.org/zap@v1.27.1/internal/pool/pool.go:34:13: syntax error: unexpected any, expecting ]
Error: ../../../go/pkg/mod/go.uber.org/zap@v1.27.1/internal/pool/pool.go:40:6: missing function body
Error: ../../../go/pkg/mod/go.uber.org/zap@v1.27.1/internal/pool/pool.go:40:9: syntax error: unexpected [, expecting (
Error: ../../../go/pkg/mod/go.uber.org/zap@v1.27.1/internal/pool/pool.go:40:27: method has no receiver
Error: ../../../go/pkg/mod/go.uber.org/zap@v1.27.1/internal/pool/pool.go:43:16: method has no receiver
Error: ../../../go/pkg/mod/go.uber.org/zap@v1.27.1/internal/pool/pool.go:43:20: syntax error: unexpected {, expecting (
Error: ../../../go/pkg/mod/go.uber.org/zap@v1.27.1/internal/pool/pool.go:44:5: syntax error: unexpected return, expecting )
Error: ../../../go/pkg/mod/go.uber.org/zap@v1.27.1/internal/pool/pool.go:45:4: syntax error: non-declaration statement outside function body
Error: ../../../go/pkg/mod/go.uber.org/zap@v1.27.1/internal/pool/pool.go:51:14: syntax error: unexpected [, expecting comma or )
Error: ../../../go/pkg/mod/go.uber.org/zap@v1.27.1/internal/pool/pool.go:56:14: syntax error: unexpected [, expecting comma or )
Error: ../../../go/pkg/mod/go.uber.org/zap@v1.27.1/internal/pool/pool.go:40:6: too many errors
note: module requires Go 1.19
FAIL	github.com/pingcap/log [build failed]
FAIL
Error: Process completed with exit code 2.

Is someone planning to fix this?

Should this repository have a policy that prevents pushing commits on the main branch if CI hasn't been proven to pass for that commit first?

CC: @dveeden

[dveeden]

CI was configured to use Go 1.16 instead of the version that's in go.mod.
And I think #45 might have updated zap to a version that doesn't support Go 1.16 anymore.

Go upstream only supports Go 1.26 and Go 1.25 currently, so let's update this to the oldest of the two and follow the version that is set in go.mod. It also seems to be time to update various other things.