Uh oh!
There was an error while loading. Please reload this page.
support gbk charset - #808
Conversation
Codecov Report
@@ Coverage Diff @@## master #808 +/- ##
==========================================
- Coverage 78.35% 78.27% -0.09%
==========================================
Files 40 40 Lines 14773 14707 -66 ==========================================
- Hits 11576 11512 -64 - Misses 2509 2515 +6 + Partials 688 680 -8 |
kennytm
left a comment
There was a problem hiding this comment.
Rest LGTM.
Why do we support GBK rather than its superset GB18030?
Uh oh!
There was an error while loading. Please reload this page.
Co-Authored-By: kennytm <kennytm@gmail.com>
@kennytm Because we just met |
tiancaiamao
commented
Apr 20, 2020
PTAL @bb7133@wjhuang2016 |
Uh oh!
There was an error while loading. Please reload this page.
wjhuang2016
left a comment
There was a problem hiding this comment.
GetSupportedCharsets need to change too.
spongedu
commented
Jun 4, 2020
@wjhuang2016 PTAL :) |
ti-chi-bot
commented
Sep 15, 2021
@spongedu: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
codecov-commenter
commented
Apr 6, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Please upload reports for the commit 73b534d to get more accurate results. Additional details and impacted files@@ Coverage Diff @@## master #808 +/- ##
==========================================
- Coverage 78.35% 78.27% -0.09%
==========================================
Files 40 40 Lines 14773 14707 -66 ==========================================
- Hits 11576 11512 -64 - Misses 2509 2515 +6 + Partials 688 680 -8 🚀 New features to boost your workflow:
|
What problem does this PR solve?
We're using parser to develop some our systems and found that charset gbk is not supported yet in parser, which makes some SQL fail to work.
As a MySQL compatible parser, I think we should support gbk as MySQL's parser do, and leave the charset-compatible issues to
TiDBlayer.What is changed and how it works?
Add gbk into supported charsets, and add related tests
Check List
Tests