Uh oh!
There was an error while loading. Please reload this page.
[Test for AI review]*: Add enable_distance_proj to ANNQueryInfo to indicate if reading distance column from vector index - #352
Conversation
Signed-off-by: “EricZequan” <zequany33@gmail.com>
|
EricZequan
commented
Jan 15, 2025
/retest |
Uh oh!
There was an error while loading. Please reload this page.
…ctor index is not built Signed-off-by: “EricZequan” <zequany33@gmail.com>
Signed-off-by: “EricZequan” <zequany33@gmail.com>
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: “EricZequan” <zequany33@gmail.com>
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: “EricZequan” <zequany33@gmail.com>
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new boolean field (enable_distance_proj) to the ANNQueryInfo message to indicate whether to read a distance column from the vector index and adjusts associated field numbering and deprecation.
- Introduces enable_distance_proj to control distance projection behavior.
- Deprecates the original column_id field and adds a new ColumnInfo column field for schema metadata persistence.
- Renumbers ref_vec_f32 and index_id fields to accommodate the new fields while reserving space for future changes.
| optional uint32 hnsw_ef_search = 20 [(gogoproto.nullable) = false]; // Only for HNSW indexes | ||
| // If enabled, the content of TableScan's vector output column (whose ID is column.id) will be removed and | ||
| // TableScan will read an distance column (whose id must be -2000) as replacement, tiflash persistent layer |
There was a problem hiding this comment.
Typographical error: 'an distance column' should be 'a distance column'.
| // TableScan will read an distance column (whose id must be -2000) as replacement, tiflash persistent layer | |
| // TableScan will read a distance column (whose id must be -2000) as replacement, tiflash persistent layer |
| optional uint32 hnsw_ef_search = 20 [(gogoproto.nullable) = false]; // Only for HNSW indexes | ||
| // If enabled, the content of TableScan's vector output column (whose ID is column.id) will be removed and | ||
| // TableScan will read an distance column (whose id must be -2000) as replacement, tiflash persistent layer |
There was a problem hiding this comment.
[nitpick] Typographical error: 'tiflash' should likely be 'TiFlash' to match standard capitalization.
| // TableScan will read an distance column (whose id must be -2000) as replacement, tiflash persistent layer | |
| // TableScan will read an distance column (whose id must be -2000) as replacement, TiFlash persistent layer |
| optional string column_name = 4 [(gogoproto.nullable) = false]; // For debug purpose only. Currently only used in explain. | ||
| optional int64 column_id = 5 [(gogoproto.nullable) = false]; | ||
| // deprecated field, we use column to get the id first, and this field will not be set again. | ||
| // Retain this field to be compatible with older versions of tidb |
There was a problem hiding this comment.
[nitpick] Typographical error: 'tidb' should be capitalized as 'TiDB'.
| // Retain this field to be compatible with older versions of tidb | |
| // Retain this field to be compatible with older versions of TiDB |
EricZequan
commented
Mar 26, 2025
This PR is used for large model review and testing. New PR are moved to: #358 |
What problem does this PR solve?
Issue Number: ref pingcap/tidb#54245
Problem Summary:
What is changed and how it works?
Proposal: xxx
What's Changed:
How it Works:
Related changes
pingcap/docs/pingcap/docs-cn: