Uh oh!
There was an error while loading. Please reload this page.
Move pending approval derivation and thread visit tracking to shared session logic - #16
Merged
Conversation
- Moved pending-approval extraction to `session-logic` and reused it in `Sidebar` status rendering - Added `lastVisitedAt` threading persistence through schema, types, hydrate/serialize paths, and tests - Updated sidebar thread pills for completed/approval states and pulsing working status - Marked active thread visits and completion visibility timestamps on selection and `turn/completed` - Co-authored-by: codex <codex@users.noreply.github.com>
Caution Review failedThe pull request is closed. WalkthroughAdds thread visit-time tracking, moves pending-approval derivation into session-logic as a shared exported function, and replaces Sidebar's status label with a pill-based status UI; updates store and persistence to surface and persist Changes
Sequence Diagram(s)sequenceDiagram
participant Provider as Provider (events)
participant Store as Store (state)
participant Session as session-logic
participant UI as Sidebar / ChatView
Provider->>Store: append events to thread.events
Store->>Session: expose thread.events (derive)
Session->>Session: derivePendingApprovals(events)
Session-->>Store: pending approvals (derived)
Store->>UI: expose pendingApprovalByThreadId and thread data
UI->>UI: render ThreadStatusPill / pending approvals list
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
Greptile OverviewGreptile SummaryMoved pending approval derivation logic from
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant Sidebar
participant Store
participant Thread
participant SessionLogic
User->>Sidebar: Select thread
Sidebar->>Store: SET_ACTIVE_THREAD
Store->>Thread: Update lastVisitedAt (current timestamp)
User->>ChatView: Send message / Turn starts
ChatView->>Store: APPLY_EVENT (turn/started)
Store->>Thread: Add event, update session status
Note over Thread,SessionLogic: During turn execution
ChatView->>Store: APPLY_EVENT (approval request)
Store->>Thread: Add approval request event
Sidebar->>SessionLogic: derivePendingApprovals(thread.events)
SessionLogic-->>Sidebar: Returns pending approvals
Sidebar->>Sidebar: Show "Awaiting response" pill
User->>ChatView: Approve/Deny action
ChatView->>Store: APPLY_EVENT (decision)
Store->>Thread: Add decision event
Note over Thread,SessionLogic: Turn completes
ChatView->>Store: APPLY_EVENT (turn/completed)
Store->>Thread: Update latestTurnCompletedAt
Store->>Thread: Update lastVisitedAt (active thread only)
Sidebar->>SessionLogic: derivePendingApprovals(thread.events)
SessionLogic->>SessionLogic: Clear pending on turn/completed
SessionLogic-->>Sidebar: Returns empty array
Sidebar->>Sidebar: Check hasUnseenCompletion
Note over Sidebar: completedAt > lastVisitedAt
Sidebar->>Sidebar: Show "Completed" pill (if inactive)
User->>Sidebar: Select thread again
Sidebar->>Store: SET_ACTIVE_THREAD
Store->>Thread: Update lastVisitedAt
Sidebar->>Sidebar: Hide "Completed" pill
Last reviewed commit: 1b7abe5 |
Contributor
Move pending approval derivation to |
Uh oh!
There was an error while loading. Please reload this page.
5 tasks
aorwall added a commit
to aorwall/t3code
that referenced
this pull request
Aug 2, 2026
Merge upstream t3code main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ChatViewinto sharedapps/web/src/session-logic.tsand added a dedicatedPendingApprovaltype.derivePendingApprovalstests to cover request, decision, and turn-completion clearing behavior.lastVisitedAtto thread persistence (persistenceSchema.ts) and threaded it through hydration/serialization round-trip.Working,Connecting,Completed,Awaiting response) and derive completion visibility fromlatestTurnCompletedAtvslastVisitedAt.ChatViewand switched to derived session-logic path.Testing
apps/web/src/session-logic.test.tsforderivePendingApprovals.apps/web/src/persistenceSchema.test.tsforlastVisitedAthydration/persistence.apps/web/src/store.test.tsfor active-thread visit updates and completion-seen timestamps.Summary by CodeRabbit
New Features
Bug Fixes
Refactor