Uh oh!
There was an error while loading. Please reload this page.
Migrate build and test pipeline to vite-plus - #1616
Conversation
- Replace tsdown and Turbo build wiring with vite-plus tasks - Switch server, desktop, and web tests to vite-plus test imports - Tighten related Effect types and update CI/docs for the new workflow
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Workspace scan no longer ignores Turbo cache
- Restored
.turboto IGNORED_DIRECTORY_NAMES alongside the newly added.vite, since the migration accidentally replaced it instead of adding.viteas an additional entry.
- Restored
Or push these changes by commenting:
@cursor push 2d90d516bd
Preview (2d90d516bd)
diff --git a/apps/server/src/workspace/Layers/WorkspaceEntries.ts b/apps/server/src/workspace/Layers/WorkspaceEntries.ts--- a/apps/server/src/workspace/Layers/WorkspaceEntries.ts+++ b/apps/server/src/workspace/Layers/WorkspaceEntries.ts@@ -21,6 +21,7 @@
".convex",
"node_modules",
".next",
+ ".turbo",
".vite",
"dist",
"build",You can send follow-ups to this agent here.
| "node_modules", | ||
| ".next", | ||
| ".turbo", | ||
| ".vite", |
There was a problem hiding this comment.
Workspace scan no longer ignores Turbo cache
Medium Severity
Replacing ".turbo" with ".vite" in IGNORED_DIRECTORY_NAMES makes WorkspaceEntries recurse into old Turbo caches. When Git filtering is unavailable or the folder is outside a Git worktree, .turbo contents can flood indexing, hit WORKSPACE_INDEX_MAX_ENTRIES, and hide real project files from search results.
Additional Locations (1)
- Remove tsconfig path aliases and Vite aliases - Point contracts/shared packages at source entrypoints - Update dev runner imports to use package specifiers
- switch workspace checks and tests to `vp` - fold Vitest browser config into `vite.config.ts` - add `electron-builder` for desktop packaging
Co-authored-by: codex <codex@users.noreply.github.com>
adammansfield
commented
Apr 12, 2026
This change will fix bug #1968 as it removes |
juliusmarminge
commented
Apr 12, 2026
it doesn't really remove it. tsdown is used by |
Sorry I didn't realize. But this change will still fix #1968 because Tested with this PR: irm https://vite.plus/ps1 | iex # re-open terminal so vp in PATH
git fetch upstream pull/1616/merge:pull/1616
git switch pull/1616
vp install vp run dev:desktop |
Summary
tsdown/vitestworkflow withvite-plusacross desktop, server, web, and shared packages.vite.config.tsfiles and removed Turbo/tsdown config.Testing
vite-plus: https://viteplus.dev/guide/#install-vpbun fmtbun lintbun typecheckbun run testNote
Medium Risk
Build/test infrastructure is replaced across desktop/server/web, so failures may surface in CI or local workflows despite mostly mechanical changes. Runtime logic changes are minor, but the new bundling/aliasing config affects how packages resolve and ship.
Overview
Switches the workspace build + test toolchain to
vite-plus. Desktop/server bundling moves fromtsdowntovp packwith newvite.config.tsfiles, Turbo app configs are removed, and package scripts are updated to usevpfor build/dev/test.Adjusts repo plumbing to match the new flow. CI caching drops
.turboand only caches Bun, docs update the meaning ofbun run build, and TypeScript configs now include source-package paths (and exclude their tests) to support the new bundling/TS resolution.Includes small correctness/type cleanups uncovered by the migration. Many
Effect.Effect<..., never>/fiber signatures are loosened, workspace scanning ignores.viteinstead of.turbo, and a few UI/test assertions and casts are simplified for stricter typing and more reliable browser tests.Written by Cursor Bugbot for commit 881c649. This will update automatically on new commits. Configure here.
Note
Migrate build, test, and dev pipeline from vitest/turbo/tsdown to vite-plus
vitestimports withvite-plus/testacross all test files inapps/,packages/, andscripts/.turbowithvp(vite-plus CLI) for monorepo task orchestration in root and per-packagepackage.jsonscripts (dev,build,test,lint,fmt).tsdownwithvp packfor bundling desktop and shared packages; adds vite.config.ts files forapps/desktop,apps/server,apps/web,packages/shared, andpackages/contracts.@t3tools/*workspace packages to source files across all vite configs andtsconfig.base.json, removing the need for pre-built outputs during development.WorkspaceEntries.tsnow ignores.viteinstead of.turbo.bun.lockonly.Effect.Effectand related types drop explicitnevererror/environment type parameters throughout the codebase, aligning with updated Effect library conventions.Macroscope summarized 881c649. (Automatic summaries will resume when PR exits draft mode or review begins).