add configurable worktree location settings - #1926

Closed
tarik02 wants to merge 8 commits into
pingdotgg:mainfrom
tarik02-org:add-worktree-location-settings
Closed

add configurable worktree location settings#1926
tarik02 wants to merge 8 commits into
pingdotgg:mainfrom
tarik02-org:add-worktree-location-settings

Conversation

@tarik02

@tarik02tarik02 commented Apr 11, 2026

Copy link
Copy Markdown
Contributor

Fixes#1878

What Changed

This adds configurable worktree location settings so T3 Code does not have to create worktrees in one fixed global layout.

Specifically, this PR:

  • adds built-in worktree location modes for the default global layout, a project subdirectory layout, and a project sibling layout
  • adds a custom template option for users who need a different absolute path layout
  • updates server-side worktree creation flows to resolve the target path before creating a worktree
  • centralizes path sanitization, template validation, resolution, and preview rendering in shared helpers
  • adds settings UI for selecting the mode, editing a custom template, previewing the final path, and showing inline validation errors
  • adds tests for shared helpers, server plumbing, and settings panel behavior
  • GitCore no longer depends on ServerConfig

Why

Some projects depend on folder-scoped local tooling and parent-directory configuration.

Examples from the issue include setups like direnv, flakes, and similar tooling that only work when the worktree lives under the expected project directory tree. The current global worktree location breaks those setups because the new worktree ends up outside the folder hierarchy those tools rely on.

This change lets users keep the existing global behavior, place worktrees under the project, or define a custom layout when their environment has stricter path requirements.

UI Changes

Before:

  • worktrees were created in the default global location only
  • there was no setting to change that behavior
image

After:

  • General Settings includes a Worktree location setting
  • users can choose a built-in location mode or a custom template
  • the UI shows a live preview of the resolved path and inline validation for invalid custom templates
imageimage
_20260411_131122.webm

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Medium Risk
Changes where worktrees are created on disk (filesystem layout) and threads on paths that depend on project-adjacent tooling; invalid templates fail worktree creation explicitly rather than silently using the old default.

Overview
Adds configurable worktree paths so server-driven worktree creation (new worktree threads, PR worktree prep, and createWorktree without an explicit path) no longer always uses Git’s default layout.

Server: Introduces WorktreeLocationResolver, wired into GitManager and GitWorkflowService, which reads worktreeLocation from server settings and resolves a path before git worktree add. Invalid custom templates surface as WorktreeLocationResolverError (also included in git manager / VCS create-worktree error unions).

Contracts & shared:ServerSettings gains worktreeLocation (mode + template); shared worktreeLocation helpers handle template validation, variable substitution ($T3_HOME, $PROJECT_DIRNAME, $PROJECT_NAME, $WORKTREE_NAME), resolution for default / project-subdirectory / project-sibling / custom modes, and previews.

UI: General Settings adds a Worktree location control (mode selector, custom template field with variable hints, live preview, validation) and includes it in restore-defaults.

Tests: Coverage for shared resolution, resolver layers in git/server tests, and updated expectations when paths are auto-resolved (e.g. mock .mock-worktrees/... in tests).

Reviewed by Cursor Bugbot for commit 49b653e. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add configurable worktree location settings with UI controls and live preview

  • Adds a new WorktreeLocationResolver service that resolves where git worktrees are created, supporting four modes: default, project-subdirectory, project-sibling, and custom template.
  • Adds worktreeLocation (mode + template) to ServerSettings with defaults, patch support, and a new WorktreeLocationResolverError error type in contracts.
  • Wires the live resolver into GitManager and GitWorkflowService so worktrees are created at the resolved path instead of an unspecified location.
  • Adds a settings UI row in GeneralSettingsPanel with a mode selector, optional custom template input, variable chips, and a live preview/validation message.
  • Behavioral Change: createWorktree and preparePullRequestThread now use a resolved path rather than null; the WsVcsCreateWorktreeRpc RPC may now fail with WorktreeLocationResolverError in addition to GitCommandError.

Macroscope summarized 49b653e.


Open in Devin Review

@coderabbitai

coderabbitaiBot commented Apr 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 182a8ecd-bf74-4bc9-8f9b-673b11651c9d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actionsgithub-actionsBot added size:XL 500-999 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Apr 11, 2026
Comment threadpackages/shared/src/worktreeLocation.ts
Comment threadpackages/shared/src/worktreeLocation.ts Outdated
@macroscopeapp

macroscopeappBot commented Apr 11, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

This PR introduces a new feature (configurable worktree locations) with substantial new code across services, shared utilities, UI components, and settings schema. New user-facing capabilities and runtime behavior changes warrant human review.

You can customize Macroscope's approvability policy. Learn more.

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit c34be34. Configure here.

Comment threadapps/server/src/server.test.ts Outdated
@fredericmorin-flare

Copy link
Copy Markdown

bump! would love to have that feature. currently blocked from using t3code on a project that requires worktree to be in a specific location for some other integration to work.

@tarik02

Copy link
Copy Markdown
ContributorAuthor

bump! would love to have that feature. currently blocked from using t3code on a project that requires worktree to be in a specific location for some other integration to work.

@fredericmorin-flare actually you can create worktrees on your own and they become available in t3code branch picker

pretty good workaround

@juliusmarminge

Copy link
Copy Markdown
Member

Closing after product review: configurable worktree location is not planned in this form against the current workspace lifecycle.

@tarik02
tarik02 deleted the add-worktree-location-settings branch August 20, 2026 08:27
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL500-999 changed lines (additions + deletions).vouch:unvouchedPR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: configurable worktree location

3 participants

@tarik02@fredericmorin-flare@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

add configurable worktree location settings - #1926

Closed
tarik02 wants to merge 8 commits into
pingdotgg:mainfrom
tarik02-org:add-worktree-location-settings
Closed

add configurable worktree location settings#1926
tarik02 wants to merge 8 commits into
pingdotgg:mainfrom
tarik02-org:add-worktree-location-settings

Conversation

@tarik02

@tarik02tarik02 commented Apr 11, 2026

Copy link
Copy Markdown
Contributor

Fixes#1878

What Changed

This adds configurable worktree location settings so T3 Code does not have to create worktrees in one fixed global layout.

Specifically, this PR:

  • adds built-in worktree location modes for the default global layout, a project subdirectory layout, and a project sibling layout
  • adds a custom template option for users who need a different absolute path layout
  • updates server-side worktree creation flows to resolve the target path before creating a worktree
  • centralizes path sanitization, template validation, resolution, and preview rendering in shared helpers
  • adds settings UI for selecting the mode, editing a custom template, previewing the final path, and showing inline validation errors
  • adds tests for shared helpers, server plumbing, and settings panel behavior
  • GitCore no longer depends on ServerConfig

Why

Some projects depend on folder-scoped local tooling and parent-directory configuration.

Examples from the issue include setups like direnv, flakes, and similar tooling that only work when the worktree lives under the expected project directory tree. The current global worktree location breaks those setups because the new worktree ends up outside the folder hierarchy those tools rely on.

This change lets users keep the existing global behavior, place worktrees under the project, or define a custom layout when their environment has stricter path requirements.

UI Changes

Before:

  • worktrees were created in the default global location only
  • there was no setting to change that behavior
image

After:

  • General Settings includes a Worktree location setting
  • users can choose a built-in location mode or a custom template
  • the UI shows a live preview of the resolved path and inline validation for invalid custom templates
imageimage
_20260411_131122.webm

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Medium Risk
Changes where worktrees are created on disk (filesystem layout) and threads on paths that depend on project-adjacent tooling; invalid templates fail worktree creation explicitly rather than silently using the old default.

Overview
Adds configurable worktree paths so server-driven worktree creation (new worktree threads, PR worktree prep, and createWorktree without an explicit path) no longer always uses Git’s default layout.

Server: Introduces WorktreeLocationResolver, wired into GitManager and GitWorkflowService, which reads worktreeLocation from server settings and resolves a path before git worktree add. Invalid custom templates surface as WorktreeLocationResolverError (also included in git manager / VCS create-worktree error unions).

Contracts & shared:ServerSettings gains worktreeLocation (mode + template); shared worktreeLocation helpers handle template validation, variable substitution ($T3_HOME, $PROJECT_DIRNAME, $PROJECT_NAME, $WORKTREE_NAME), resolution for default / project-subdirectory / project-sibling / custom modes, and previews.

UI: General Settings adds a Worktree location control (mode selector, custom template field with variable hints, live preview, validation) and includes it in restore-defaults.

Tests: Coverage for shared resolution, resolver layers in git/server tests, and updated expectations when paths are auto-resolved (e.g. mock .mock-worktrees/... in tests).

Reviewed by Cursor Bugbot for commit 49b653e. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add configurable worktree location settings with UI controls and live preview

  • Adds a new WorktreeLocationResolver service that resolves where git worktrees are created, supporting four modes: default, project-subdirectory, project-sibling, and custom template.
  • Adds worktreeLocation (mode + template) to ServerSettings with defaults, patch support, and a new WorktreeLocationResolverError error type in contracts.
  • Wires the live resolver into GitManager and GitWorkflowService so worktrees are created at the resolved path instead of an unspecified location.
  • Adds a settings UI row in GeneralSettingsPanel with a mode selector, optional custom template input, variable chips, and a live preview/validation message.
  • Behavioral Change: createWorktree and preparePullRequestThread now use a resolved path rather than null; the WsVcsCreateWorktreeRpc RPC may now fail with WorktreeLocationResolverError in addition to GitCommandError.

Macroscope summarized 49b653e.


Open in Devin Review

@coderabbitai

coderabbitaiBot commented Apr 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 182a8ecd-bf74-4bc9-8f9b-673b11651c9d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actionsgithub-actionsBot added size:XL 500-999 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Apr 11, 2026
Comment threadpackages/shared/src/worktreeLocation.ts
Comment threadpackages/shared/src/worktreeLocation.ts Outdated
@macroscopeapp

macroscopeappBot commented Apr 11, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

This PR introduces a new feature (configurable worktree locations) with substantial new code across services, shared utilities, UI components, and settings schema. New user-facing capabilities and runtime behavior changes warrant human review.

You can customize Macroscope's approvability policy. Learn more.

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit c34be34. Configure here.

Comment threadapps/server/src/server.test.ts Outdated
@fredericmorin-flare

Copy link
Copy Markdown

bump! would love to have that feature. currently blocked from using t3code on a project that requires worktree to be in a specific location for some other integration to work.

@tarik02

Copy link
Copy Markdown
ContributorAuthor

bump! would love to have that feature. currently blocked from using t3code on a project that requires worktree to be in a specific location for some other integration to work.

@fredericmorin-flare actually you can create worktrees on your own and they become available in t3code branch picker

pretty good workaround

@juliusmarminge

Copy link
Copy Markdown
Member

Closing after product review: configurable worktree location is not planned in this form against the current workspace lifecycle.

@tarik02
tarik02 deleted the add-worktree-location-settings branch August 20, 2026 08:27
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL500-999 changed lines (additions + deletions).vouch:unvouchedPR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: configurable worktree location

3 participants

@tarik02@fredericmorin-flare@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

add configurable worktree location settings - #1926

Closed
tarik02 wants to merge 8 commits into
pingdotgg:mainfrom
tarik02-org:add-worktree-location-settings
Closed

add configurable worktree location settings#1926
tarik02 wants to merge 8 commits into
pingdotgg:mainfrom
tarik02-org:add-worktree-location-settings

Conversation

@tarik02

@tarik02tarik02 commented Apr 11, 2026

Copy link
Copy Markdown
Contributor

Fixes#1878

What Changed

This adds configurable worktree location settings so T3 Code does not have to create worktrees in one fixed global layout.

Specifically, this PR:

  • adds built-in worktree location modes for the default global layout, a project subdirectory layout, and a project sibling layout
  • adds a custom template option for users who need a different absolute path layout
  • updates server-side worktree creation flows to resolve the target path before creating a worktree
  • centralizes path sanitization, template validation, resolution, and preview rendering in shared helpers
  • adds settings UI for selecting the mode, editing a custom template, previewing the final path, and showing inline validation errors
  • adds tests for shared helpers, server plumbing, and settings panel behavior
  • GitCore no longer depends on ServerConfig

Why

Some projects depend on folder-scoped local tooling and parent-directory configuration.

Examples from the issue include setups like direnv, flakes, and similar tooling that only work when the worktree lives under the expected project directory tree. The current global worktree location breaks those setups because the new worktree ends up outside the folder hierarchy those tools rely on.

This change lets users keep the existing global behavior, place worktrees under the project, or define a custom layout when their environment has stricter path requirements.

UI Changes

Before:

  • worktrees were created in the default global location only
  • there was no setting to change that behavior
image

After:

  • General Settings includes a Worktree location setting
  • users can choose a built-in location mode or a custom template
  • the UI shows a live preview of the resolved path and inline validation for invalid custom templates
imageimage
_20260411_131122.webm

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Medium Risk
Changes where worktrees are created on disk (filesystem layout) and threads on paths that depend on project-adjacent tooling; invalid templates fail worktree creation explicitly rather than silently using the old default.

Overview
Adds configurable worktree paths so server-driven worktree creation (new worktree threads, PR worktree prep, and createWorktree without an explicit path) no longer always uses Git’s default layout.

Server: Introduces WorktreeLocationResolver, wired into GitManager and GitWorkflowService, which reads worktreeLocation from server settings and resolves a path before git worktree add. Invalid custom templates surface as WorktreeLocationResolverError (also included in git manager / VCS create-worktree error unions).

Contracts & shared:ServerSettings gains worktreeLocation (mode + template); shared worktreeLocation helpers handle template validation, variable substitution ($T3_HOME, $PROJECT_DIRNAME, $PROJECT_NAME, $WORKTREE_NAME), resolution for default / project-subdirectory / project-sibling / custom modes, and previews.

UI: General Settings adds a Worktree location control (mode selector, custom template field with variable hints, live preview, validation) and includes it in restore-defaults.

Tests: Coverage for shared resolution, resolver layers in git/server tests, and updated expectations when paths are auto-resolved (e.g. mock .mock-worktrees/... in tests).

Reviewed by Cursor Bugbot for commit 49b653e. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add configurable worktree location settings with UI controls and live preview

  • Adds a new WorktreeLocationResolver service that resolves where git worktrees are created, supporting four modes: default, project-subdirectory, project-sibling, and custom template.
  • Adds worktreeLocation (mode + template) to ServerSettings with defaults, patch support, and a new WorktreeLocationResolverError error type in contracts.
  • Wires the live resolver into GitManager and GitWorkflowService so worktrees are created at the resolved path instead of an unspecified location.
  • Adds a settings UI row in GeneralSettingsPanel with a mode selector, optional custom template input, variable chips, and a live preview/validation message.
  • Behavioral Change: createWorktree and preparePullRequestThread now use a resolved path rather than null; the WsVcsCreateWorktreeRpc RPC may now fail with WorktreeLocationResolverError in addition to GitCommandError.

Macroscope summarized 49b653e.


Open in Devin Review

@coderabbitai

coderabbitaiBot commented Apr 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 182a8ecd-bf74-4bc9-8f9b-673b11651c9d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actionsgithub-actionsBot added size:XL 500-999 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Apr 11, 2026
Comment threadpackages/shared/src/worktreeLocation.ts
Comment threadpackages/shared/src/worktreeLocation.ts Outdated
@macroscopeapp

macroscopeappBot commented Apr 11, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

This PR introduces a new feature (configurable worktree locations) with substantial new code across services, shared utilities, UI components, and settings schema. New user-facing capabilities and runtime behavior changes warrant human review.

You can customize Macroscope's approvability policy. Learn more.

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit c34be34. Configure here.

Comment threadapps/server/src/server.test.ts Outdated
@fredericmorin-flare

Copy link
Copy Markdown

bump! would love to have that feature. currently blocked from using t3code on a project that requires worktree to be in a specific location for some other integration to work.

@tarik02

Copy link
Copy Markdown
ContributorAuthor

bump! would love to have that feature. currently blocked from using t3code on a project that requires worktree to be in a specific location for some other integration to work.

@fredericmorin-flare actually you can create worktrees on your own and they become available in t3code branch picker

pretty good workaround

@juliusmarminge

Copy link
Copy Markdown
Member

Closing after product review: configurable worktree location is not planned in this form against the current workspace lifecycle.

@tarik02
tarik02 deleted the add-worktree-location-settings branch August 20, 2026 08:27
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL500-999 changed lines (additions + deletions).vouch:unvouchedPR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: configurable worktree location

3 participants

@tarik02@fredericmorin-flare@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

add configurable worktree location settings - #1926

Closed
tarik02 wants to merge 8 commits into
pingdotgg:mainfrom
tarik02-org:add-worktree-location-settings
Closed

add configurable worktree location settings#1926
tarik02 wants to merge 8 commits into
pingdotgg:mainfrom
tarik02-org:add-worktree-location-settings

Conversation

@tarik02

@tarik02tarik02 commented Apr 11, 2026

Copy link
Copy Markdown
Contributor

Fixes#1878

What Changed

This adds configurable worktree location settings so T3 Code does not have to create worktrees in one fixed global layout.

Specifically, this PR:

  • adds built-in worktree location modes for the default global layout, a project subdirectory layout, and a project sibling layout
  • adds a custom template option for users who need a different absolute path layout
  • updates server-side worktree creation flows to resolve the target path before creating a worktree
  • centralizes path sanitization, template validation, resolution, and preview rendering in shared helpers
  • adds settings UI for selecting the mode, editing a custom template, previewing the final path, and showing inline validation errors
  • adds tests for shared helpers, server plumbing, and settings panel behavior
  • GitCore no longer depends on ServerConfig

Why

Some projects depend on folder-scoped local tooling and parent-directory configuration.

Examples from the issue include setups like direnv, flakes, and similar tooling that only work when the worktree lives under the expected project directory tree. The current global worktree location breaks those setups because the new worktree ends up outside the folder hierarchy those tools rely on.

This change lets users keep the existing global behavior, place worktrees under the project, or define a custom layout when their environment has stricter path requirements.

UI Changes

Before:

  • worktrees were created in the default global location only
  • there was no setting to change that behavior
image

After:

  • General Settings includes a Worktree location setting
  • users can choose a built-in location mode or a custom template
  • the UI shows a live preview of the resolved path and inline validation for invalid custom templates
imageimage
_20260411_131122.webm

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Medium Risk
Changes where worktrees are created on disk (filesystem layout) and threads on paths that depend on project-adjacent tooling; invalid templates fail worktree creation explicitly rather than silently using the old default.

Overview
Adds configurable worktree paths so server-driven worktree creation (new worktree threads, PR worktree prep, and createWorktree without an explicit path) no longer always uses Git’s default layout.

Server: Introduces WorktreeLocationResolver, wired into GitManager and GitWorkflowService, which reads worktreeLocation from server settings and resolves a path before git worktree add. Invalid custom templates surface as WorktreeLocationResolverError (also included in git manager / VCS create-worktree error unions).

Contracts & shared:ServerSettings gains worktreeLocation (mode + template); shared worktreeLocation helpers handle template validation, variable substitution ($T3_HOME, $PROJECT_DIRNAME, $PROJECT_NAME, $WORKTREE_NAME), resolution for default / project-subdirectory / project-sibling / custom modes, and previews.

UI: General Settings adds a Worktree location control (mode selector, custom template field with variable hints, live preview, validation) and includes it in restore-defaults.

Tests: Coverage for shared resolution, resolver layers in git/server tests, and updated expectations when paths are auto-resolved (e.g. mock .mock-worktrees/... in tests).

Reviewed by Cursor Bugbot for commit 49b653e. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add configurable worktree location settings with UI controls and live preview

  • Adds a new WorktreeLocationResolver service that resolves where git worktrees are created, supporting four modes: default, project-subdirectory, project-sibling, and custom template.
  • Adds worktreeLocation (mode + template) to ServerSettings with defaults, patch support, and a new WorktreeLocationResolverError error type in contracts.
  • Wires the live resolver into GitManager and GitWorkflowService so worktrees are created at the resolved path instead of an unspecified location.
  • Adds a settings UI row in GeneralSettingsPanel with a mode selector, optional custom template input, variable chips, and a live preview/validation message.
  • Behavioral Change: createWorktree and preparePullRequestThread now use a resolved path rather than null; the WsVcsCreateWorktreeRpc RPC may now fail with WorktreeLocationResolverError in addition to GitCommandError.

Macroscope summarized 49b653e.


Open in Devin Review

@coderabbitai

coderabbitaiBot commented Apr 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 182a8ecd-bf74-4bc9-8f9b-673b11651c9d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actionsgithub-actionsBot added size:XL 500-999 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Apr 11, 2026
Comment threadpackages/shared/src/worktreeLocation.ts
Comment threadpackages/shared/src/worktreeLocation.ts Outdated
@macroscopeapp

macroscopeappBot commented Apr 11, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

This PR introduces a new feature (configurable worktree locations) with substantial new code across services, shared utilities, UI components, and settings schema. New user-facing capabilities and runtime behavior changes warrant human review.

You can customize Macroscope's approvability policy. Learn more.

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit c34be34. Configure here.

Comment threadapps/server/src/server.test.ts Outdated
@fredericmorin-flare

Copy link
Copy Markdown

bump! would love to have that feature. currently blocked from using t3code on a project that requires worktree to be in a specific location for some other integration to work.

@tarik02

Copy link
Copy Markdown
ContributorAuthor

bump! would love to have that feature. currently blocked from using t3code on a project that requires worktree to be in a specific location for some other integration to work.

@fredericmorin-flare actually you can create worktrees on your own and they become available in t3code branch picker

pretty good workaround

@juliusmarminge

Copy link
Copy Markdown
Member

Closing after product review: configurable worktree location is not planned in this form against the current workspace lifecycle.

@tarik02
tarik02 deleted the add-worktree-location-settings branch August 20, 2026 08:27
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL500-999 changed lines (additions + deletions).vouch:unvouchedPR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: configurable worktree location

3 participants

@tarik02@fredericmorin-flare@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

add configurable worktree location settings - #1926

Closed
tarik02 wants to merge 8 commits into
pingdotgg:mainfrom
tarik02-org:add-worktree-location-settings
Closed

add configurable worktree location settings#1926
tarik02 wants to merge 8 commits into
pingdotgg:mainfrom
tarik02-org:add-worktree-location-settings

Conversation

@tarik02

@tarik02tarik02 commented Apr 11, 2026

Copy link
Copy Markdown
Contributor

Fixes#1878

What Changed

This adds configurable worktree location settings so T3 Code does not have to create worktrees in one fixed global layout.

Specifically, this PR:

  • adds built-in worktree location modes for the default global layout, a project subdirectory layout, and a project sibling layout
  • adds a custom template option for users who need a different absolute path layout
  • updates server-side worktree creation flows to resolve the target path before creating a worktree
  • centralizes path sanitization, template validation, resolution, and preview rendering in shared helpers
  • adds settings UI for selecting the mode, editing a custom template, previewing the final path, and showing inline validation errors
  • adds tests for shared helpers, server plumbing, and settings panel behavior
  • GitCore no longer depends on ServerConfig

Why

Some projects depend on folder-scoped local tooling and parent-directory configuration.

Examples from the issue include setups like direnv, flakes, and similar tooling that only work when the worktree lives under the expected project directory tree. The current global worktree location breaks those setups because the new worktree ends up outside the folder hierarchy those tools rely on.

This change lets users keep the existing global behavior, place worktrees under the project, or define a custom layout when their environment has stricter path requirements.

UI Changes

Before:

  • worktrees were created in the default global location only
  • there was no setting to change that behavior
image

After:

  • General Settings includes a Worktree location setting
  • users can choose a built-in location mode or a custom template
  • the UI shows a live preview of the resolved path and inline validation for invalid custom templates
imageimage
_20260411_131122.webm

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Medium Risk
Changes where worktrees are created on disk (filesystem layout) and threads on paths that depend on project-adjacent tooling; invalid templates fail worktree creation explicitly rather than silently using the old default.

Overview
Adds configurable worktree paths so server-driven worktree creation (new worktree threads, PR worktree prep, and createWorktree without an explicit path) no longer always uses Git’s default layout.

Server: Introduces WorktreeLocationResolver, wired into GitManager and GitWorkflowService, which reads worktreeLocation from server settings and resolves a path before git worktree add. Invalid custom templates surface as WorktreeLocationResolverError (also included in git manager / VCS create-worktree error unions).

Contracts & shared:ServerSettings gains worktreeLocation (mode + template); shared worktreeLocation helpers handle template validation, variable substitution ($T3_HOME, $PROJECT_DIRNAME, $PROJECT_NAME, $WORKTREE_NAME), resolution for default / project-subdirectory / project-sibling / custom modes, and previews.

UI: General Settings adds a Worktree location control (mode selector, custom template field with variable hints, live preview, validation) and includes it in restore-defaults.

Tests: Coverage for shared resolution, resolver layers in git/server tests, and updated expectations when paths are auto-resolved (e.g. mock .mock-worktrees/... in tests).

Reviewed by Cursor Bugbot for commit 49b653e. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add configurable worktree location settings with UI controls and live preview

  • Adds a new WorktreeLocationResolver service that resolves where git worktrees are created, supporting four modes: default, project-subdirectory, project-sibling, and custom template.
  • Adds worktreeLocation (mode + template) to ServerSettings with defaults, patch support, and a new WorktreeLocationResolverError error type in contracts.
  • Wires the live resolver into GitManager and GitWorkflowService so worktrees are created at the resolved path instead of an unspecified location.
  • Adds a settings UI row in GeneralSettingsPanel with a mode selector, optional custom template input, variable chips, and a live preview/validation message.
  • Behavioral Change: createWorktree and preparePullRequestThread now use a resolved path rather than null; the WsVcsCreateWorktreeRpc RPC may now fail with WorktreeLocationResolverError in addition to GitCommandError.

Macroscope summarized 49b653e.


Open in Devin Review

@coderabbitai

coderabbitaiBot commented Apr 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 182a8ecd-bf74-4bc9-8f9b-673b11651c9d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actionsgithub-actionsBot added size:XL 500-999 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Apr 11, 2026
Comment threadpackages/shared/src/worktreeLocation.ts
Comment threadpackages/shared/src/worktreeLocation.ts Outdated
@macroscopeapp

macroscopeappBot commented Apr 11, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

This PR introduces a new feature (configurable worktree locations) with substantial new code across services, shared utilities, UI components, and settings schema. New user-facing capabilities and runtime behavior changes warrant human review.

You can customize Macroscope's approvability policy. Learn more.

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit c34be34. Configure here.

Comment threadapps/server/src/server.test.ts Outdated
@fredericmorin-flare

Copy link
Copy Markdown

bump! would love to have that feature. currently blocked from using t3code on a project that requires worktree to be in a specific location for some other integration to work.

@tarik02

Copy link
Copy Markdown
ContributorAuthor

bump! would love to have that feature. currently blocked from using t3code on a project that requires worktree to be in a specific location for some other integration to work.

@fredericmorin-flare actually you can create worktrees on your own and they become available in t3code branch picker

pretty good workaround

@juliusmarminge

Copy link
Copy Markdown
Member

Closing after product review: configurable worktree location is not planned in this form against the current workspace lifecycle.

@tarik02
tarik02 deleted the add-worktree-location-settings branch August 20, 2026 08:27
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL500-999 changed lines (additions + deletions).vouch:unvouchedPR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: configurable worktree location

3 participants

@tarik02@fredericmorin-flare@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

add configurable worktree location settings - #1926

Closed
tarik02 wants to merge 8 commits into
pingdotgg:mainfrom
tarik02-org:add-worktree-location-settings
Closed

add configurable worktree location settings#1926
tarik02 wants to merge 8 commits into
pingdotgg:mainfrom
tarik02-org:add-worktree-location-settings

Conversation

@tarik02

@tarik02tarik02 commented Apr 11, 2026

Copy link
Copy Markdown
Contributor

Fixes#1878

What Changed

This adds configurable worktree location settings so T3 Code does not have to create worktrees in one fixed global layout.

Specifically, this PR:

  • adds built-in worktree location modes for the default global layout, a project subdirectory layout, and a project sibling layout
  • adds a custom template option for users who need a different absolute path layout
  • updates server-side worktree creation flows to resolve the target path before creating a worktree
  • centralizes path sanitization, template validation, resolution, and preview rendering in shared helpers
  • adds settings UI for selecting the mode, editing a custom template, previewing the final path, and showing inline validation errors
  • adds tests for shared helpers, server plumbing, and settings panel behavior
  • GitCore no longer depends on ServerConfig

Why

Some projects depend on folder-scoped local tooling and parent-directory configuration.

Examples from the issue include setups like direnv, flakes, and similar tooling that only work when the worktree lives under the expected project directory tree. The current global worktree location breaks those setups because the new worktree ends up outside the folder hierarchy those tools rely on.

This change lets users keep the existing global behavior, place worktrees under the project, or define a custom layout when their environment has stricter path requirements.

UI Changes

Before:

  • worktrees were created in the default global location only
  • there was no setting to change that behavior
image

After:

  • General Settings includes a Worktree location setting
  • users can choose a built-in location mode or a custom template
  • the UI shows a live preview of the resolved path and inline validation for invalid custom templates
imageimage
_20260411_131122.webm

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Medium Risk
Changes where worktrees are created on disk (filesystem layout) and threads on paths that depend on project-adjacent tooling; invalid templates fail worktree creation explicitly rather than silently using the old default.

Overview
Adds configurable worktree paths so server-driven worktree creation (new worktree threads, PR worktree prep, and createWorktree without an explicit path) no longer always uses Git’s default layout.

Server: Introduces WorktreeLocationResolver, wired into GitManager and GitWorkflowService, which reads worktreeLocation from server settings and resolves a path before git worktree add. Invalid custom templates surface as WorktreeLocationResolverError (also included in git manager / VCS create-worktree error unions).

Contracts & shared:ServerSettings gains worktreeLocation (mode + template); shared worktreeLocation helpers handle template validation, variable substitution ($T3_HOME, $PROJECT_DIRNAME, $PROJECT_NAME, $WORKTREE_NAME), resolution for default / project-subdirectory / project-sibling / custom modes, and previews.

UI: General Settings adds a Worktree location control (mode selector, custom template field with variable hints, live preview, validation) and includes it in restore-defaults.

Tests: Coverage for shared resolution, resolver layers in git/server tests, and updated expectations when paths are auto-resolved (e.g. mock .mock-worktrees/... in tests).

Reviewed by Cursor Bugbot for commit 49b653e. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add configurable worktree location settings with UI controls and live preview

  • Adds a new WorktreeLocationResolver service that resolves where git worktrees are created, supporting four modes: default, project-subdirectory, project-sibling, and custom template.
  • Adds worktreeLocation (mode + template) to ServerSettings with defaults, patch support, and a new WorktreeLocationResolverError error type in contracts.
  • Wires the live resolver into GitManager and GitWorkflowService so worktrees are created at the resolved path instead of an unspecified location.
  • Adds a settings UI row in GeneralSettingsPanel with a mode selector, optional custom template input, variable chips, and a live preview/validation message.
  • Behavioral Change: createWorktree and preparePullRequestThread now use a resolved path rather than null; the WsVcsCreateWorktreeRpc RPC may now fail with WorktreeLocationResolverError in addition to GitCommandError.

Macroscope summarized 49b653e.


Open in Devin Review

@coderabbitai

coderabbitaiBot commented Apr 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 182a8ecd-bf74-4bc9-8f9b-673b11651c9d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actionsgithub-actionsBot added size:XL 500-999 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Apr 11, 2026
Comment threadpackages/shared/src/worktreeLocation.ts
Comment threadpackages/shared/src/worktreeLocation.ts Outdated
@macroscopeapp

macroscopeappBot commented Apr 11, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

This PR introduces a new feature (configurable worktree locations) with substantial new code across services, shared utilities, UI components, and settings schema. New user-facing capabilities and runtime behavior changes warrant human review.

You can customize Macroscope's approvability policy. Learn more.

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit c34be34. Configure here.

Comment threadapps/server/src/server.test.ts Outdated
@fredericmorin-flare

Copy link
Copy Markdown

bump! would love to have that feature. currently blocked from using t3code on a project that requires worktree to be in a specific location for some other integration to work.

@tarik02

Copy link
Copy Markdown
ContributorAuthor

bump! would love to have that feature. currently blocked from using t3code on a project that requires worktree to be in a specific location for some other integration to work.

@fredericmorin-flare actually you can create worktrees on your own and they become available in t3code branch picker

pretty good workaround

@juliusmarminge

Copy link
Copy Markdown
Member

Closing after product review: configurable worktree location is not planned in this form against the current workspace lifecycle.

@tarik02
tarik02 deleted the add-worktree-location-settings branch August 20, 2026 08:27
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL500-999 changed lines (additions + deletions).vouch:unvouchedPR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: configurable worktree location

3 participants

@tarik02@fredericmorin-flare@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

add configurable worktree location settings - #1926

Closed
tarik02 wants to merge 8 commits into
pingdotgg:mainfrom
tarik02-org:add-worktree-location-settings
Closed

add configurable worktree location settings#1926
tarik02 wants to merge 8 commits into
pingdotgg:mainfrom
tarik02-org:add-worktree-location-settings

Conversation

@tarik02

@tarik02tarik02 commented Apr 11, 2026

Copy link
Copy Markdown
Contributor

Fixes#1878

What Changed

This adds configurable worktree location settings so T3 Code does not have to create worktrees in one fixed global layout.

Specifically, this PR:

  • adds built-in worktree location modes for the default global layout, a project subdirectory layout, and a project sibling layout
  • adds a custom template option for users who need a different absolute path layout
  • updates server-side worktree creation flows to resolve the target path before creating a worktree
  • centralizes path sanitization, template validation, resolution, and preview rendering in shared helpers
  • adds settings UI for selecting the mode, editing a custom template, previewing the final path, and showing inline validation errors
  • adds tests for shared helpers, server plumbing, and settings panel behavior
  • GitCore no longer depends on ServerConfig

Why

Some projects depend on folder-scoped local tooling and parent-directory configuration.

Examples from the issue include setups like direnv, flakes, and similar tooling that only work when the worktree lives under the expected project directory tree. The current global worktree location breaks those setups because the new worktree ends up outside the folder hierarchy those tools rely on.

This change lets users keep the existing global behavior, place worktrees under the project, or define a custom layout when their environment has stricter path requirements.

UI Changes

Before:

  • worktrees were created in the default global location only
  • there was no setting to change that behavior
image

After:

  • General Settings includes a Worktree location setting
  • users can choose a built-in location mode or a custom template
  • the UI shows a live preview of the resolved path and inline validation for invalid custom templates
imageimage
_20260411_131122.webm

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Medium Risk
Changes where worktrees are created on disk (filesystem layout) and threads on paths that depend on project-adjacent tooling; invalid templates fail worktree creation explicitly rather than silently using the old default.

Overview
Adds configurable worktree paths so server-driven worktree creation (new worktree threads, PR worktree prep, and createWorktree without an explicit path) no longer always uses Git’s default layout.

Server: Introduces WorktreeLocationResolver, wired into GitManager and GitWorkflowService, which reads worktreeLocation from server settings and resolves a path before git worktree add. Invalid custom templates surface as WorktreeLocationResolverError (also included in git manager / VCS create-worktree error unions).

Contracts & shared:ServerSettings gains worktreeLocation (mode + template); shared worktreeLocation helpers handle template validation, variable substitution ($T3_HOME, $PROJECT_DIRNAME, $PROJECT_NAME, $WORKTREE_NAME), resolution for default / project-subdirectory / project-sibling / custom modes, and previews.

UI: General Settings adds a Worktree location control (mode selector, custom template field with variable hints, live preview, validation) and includes it in restore-defaults.

Tests: Coverage for shared resolution, resolver layers in git/server tests, and updated expectations when paths are auto-resolved (e.g. mock .mock-worktrees/... in tests).

Reviewed by Cursor Bugbot for commit 49b653e. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add configurable worktree location settings with UI controls and live preview

  • Adds a new WorktreeLocationResolver service that resolves where git worktrees are created, supporting four modes: default, project-subdirectory, project-sibling, and custom template.
  • Adds worktreeLocation (mode + template) to ServerSettings with defaults, patch support, and a new WorktreeLocationResolverError error type in contracts.
  • Wires the live resolver into GitManager and GitWorkflowService so worktrees are created at the resolved path instead of an unspecified location.
  • Adds a settings UI row in GeneralSettingsPanel with a mode selector, optional custom template input, variable chips, and a live preview/validation message.
  • Behavioral Change: createWorktree and preparePullRequestThread now use a resolved path rather than null; the WsVcsCreateWorktreeRpc RPC may now fail with WorktreeLocationResolverError in addition to GitCommandError.

Macroscope summarized 49b653e.


Open in Devin Review

@coderabbitai

coderabbitaiBot commented Apr 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 182a8ecd-bf74-4bc9-8f9b-673b11651c9d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actionsgithub-actionsBot added size:XL 500-999 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Apr 11, 2026
Comment threadpackages/shared/src/worktreeLocation.ts
Comment threadpackages/shared/src/worktreeLocation.ts Outdated
@macroscopeapp

macroscopeappBot commented Apr 11, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

This PR introduces a new feature (configurable worktree locations) with substantial new code across services, shared utilities, UI components, and settings schema. New user-facing capabilities and runtime behavior changes warrant human review.

You can customize Macroscope's approvability policy. Learn more.

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit c34be34. Configure here.

Comment threadapps/server/src/server.test.ts Outdated
@fredericmorin-flare

Copy link
Copy Markdown

bump! would love to have that feature. currently blocked from using t3code on a project that requires worktree to be in a specific location for some other integration to work.

@tarik02

Copy link
Copy Markdown
ContributorAuthor

bump! would love to have that feature. currently blocked from using t3code on a project that requires worktree to be in a specific location for some other integration to work.

@fredericmorin-flare actually you can create worktrees on your own and they become available in t3code branch picker

pretty good workaround

@juliusmarminge

Copy link
Copy Markdown
Member

Closing after product review: configurable worktree location is not planned in this form against the current workspace lifecycle.

@tarik02
tarik02 deleted the add-worktree-location-settings branch August 20, 2026 08:27
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL500-999 changed lines (additions + deletions).vouch:unvouchedPR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: configurable worktree location

3 participants

@tarik02@fredericmorin-flare@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

add configurable worktree location settings - #1926

Closed
tarik02 wants to merge 8 commits into
pingdotgg:mainfrom
tarik02-org:add-worktree-location-settings
Closed

add configurable worktree location settings#1926
tarik02 wants to merge 8 commits into
pingdotgg:mainfrom
tarik02-org:add-worktree-location-settings

Conversation

@tarik02

@tarik02tarik02 commented Apr 11, 2026

Copy link
Copy Markdown
Contributor

Fixes#1878

What Changed

This adds configurable worktree location settings so T3 Code does not have to create worktrees in one fixed global layout.

Specifically, this PR:

  • adds built-in worktree location modes for the default global layout, a project subdirectory layout, and a project sibling layout
  • adds a custom template option for users who need a different absolute path layout
  • updates server-side worktree creation flows to resolve the target path before creating a worktree
  • centralizes path sanitization, template validation, resolution, and preview rendering in shared helpers
  • adds settings UI for selecting the mode, editing a custom template, previewing the final path, and showing inline validation errors
  • adds tests for shared helpers, server plumbing, and settings panel behavior
  • GitCore no longer depends on ServerConfig

Why

Some projects depend on folder-scoped local tooling and parent-directory configuration.

Examples from the issue include setups like direnv, flakes, and similar tooling that only work when the worktree lives under the expected project directory tree. The current global worktree location breaks those setups because the new worktree ends up outside the folder hierarchy those tools rely on.

This change lets users keep the existing global behavior, place worktrees under the project, or define a custom layout when their environment has stricter path requirements.

UI Changes

Before:

  • worktrees were created in the default global location only
  • there was no setting to change that behavior
image

After:

  • General Settings includes a Worktree location setting
  • users can choose a built-in location mode or a custom template
  • the UI shows a live preview of the resolved path and inline validation for invalid custom templates
imageimage
_20260411_131122.webm

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Medium Risk
Changes where worktrees are created on disk (filesystem layout) and threads on paths that depend on project-adjacent tooling; invalid templates fail worktree creation explicitly rather than silently using the old default.

Overview
Adds configurable worktree paths so server-driven worktree creation (new worktree threads, PR worktree prep, and createWorktree without an explicit path) no longer always uses Git’s default layout.

Server: Introduces WorktreeLocationResolver, wired into GitManager and GitWorkflowService, which reads worktreeLocation from server settings and resolves a path before git worktree add. Invalid custom templates surface as WorktreeLocationResolverError (also included in git manager / VCS create-worktree error unions).

Contracts & shared:ServerSettings gains worktreeLocation (mode + template); shared worktreeLocation helpers handle template validation, variable substitution ($T3_HOME, $PROJECT_DIRNAME, $PROJECT_NAME, $WORKTREE_NAME), resolution for default / project-subdirectory / project-sibling / custom modes, and previews.

UI: General Settings adds a Worktree location control (mode selector, custom template field with variable hints, live preview, validation) and includes it in restore-defaults.

Tests: Coverage for shared resolution, resolver layers in git/server tests, and updated expectations when paths are auto-resolved (e.g. mock .mock-worktrees/... in tests).

Reviewed by Cursor Bugbot for commit 49b653e. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add configurable worktree location settings with UI controls and live preview

  • Adds a new WorktreeLocationResolver service that resolves where git worktrees are created, supporting four modes: default, project-subdirectory, project-sibling, and custom template.
  • Adds worktreeLocation (mode + template) to ServerSettings with defaults, patch support, and a new WorktreeLocationResolverError error type in contracts.
  • Wires the live resolver into GitManager and GitWorkflowService so worktrees are created at the resolved path instead of an unspecified location.
  • Adds a settings UI row in GeneralSettingsPanel with a mode selector, optional custom template input, variable chips, and a live preview/validation message.
  • Behavioral Change: createWorktree and preparePullRequestThread now use a resolved path rather than null; the WsVcsCreateWorktreeRpc RPC may now fail with WorktreeLocationResolverError in addition to GitCommandError.

Macroscope summarized 49b653e.


Open in Devin Review

@coderabbitai

coderabbitaiBot commented Apr 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 182a8ecd-bf74-4bc9-8f9b-673b11651c9d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actionsgithub-actionsBot added size:XL 500-999 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Apr 11, 2026
Comment threadpackages/shared/src/worktreeLocation.ts
Comment threadpackages/shared/src/worktreeLocation.ts Outdated
@macroscopeapp

macroscopeappBot commented Apr 11, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

This PR introduces a new feature (configurable worktree locations) with substantial new code across services, shared utilities, UI components, and settings schema. New user-facing capabilities and runtime behavior changes warrant human review.

You can customize Macroscope's approvability policy. Learn more.

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit c34be34. Configure here.

Comment threadapps/server/src/server.test.ts Outdated
@fredericmorin-flare

Copy link
Copy Markdown

bump! would love to have that feature. currently blocked from using t3code on a project that requires worktree to be in a specific location for some other integration to work.

@tarik02

Copy link
Copy Markdown
ContributorAuthor

bump! would love to have that feature. currently blocked from using t3code on a project that requires worktree to be in a specific location for some other integration to work.

@fredericmorin-flare actually you can create worktrees on your own and they become available in t3code branch picker

pretty good workaround

@juliusmarminge

Copy link
Copy Markdown
Member

Closing after product review: configurable worktree location is not planned in this form against the current workspace lifecycle.

@tarik02
tarik02 deleted the add-worktree-location-settings branch August 20, 2026 08:27
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL500-999 changed lines (additions + deletions).vouch:unvouchedPR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: configurable worktree location

3 participants

@tarik02@fredericmorin-flare@juliusmarminge