Uh oh!
There was an error while loading. Please reload this page.
effect-codex-app-server - #1942
Merged
Merged
Conversation
Loading
Uh oh!
There was an error while loading. Please reload this page.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typesafe JSONRPC effect API for Codex App Server. Generated from the protocol's JSON schemas
Note
Medium Risk
Moderate risk because it replaces the Codex provider’s session/runtime implementation and event mapping, which can affect session lifecycle and downstream consumers of provider events.
Overview
Switches the server’s Codex integration from the in-repo
CodexAppServerManagerto theeffect-codex-app-servertyped JSON-RPC runtime, including per-thread scoped session lifecycles and a new schema-driven mapping from raw Codex notifications/requests to canonical runtime events.Removes the legacy manager implementation and its large test suite, adds shared
CodexDeveloperInstructionsconstants, and updates Codex git text generation to usefastModedirectly (dropping capability-based normalization). The Codex adapter tests are rewritten to exercise the new runtime factory/scoping behavior, native event log flushing on layer shutdown, and updated payload shapes (e.g., user-input answers, request resolution, plan item typing).Reviewed by Cursor Bugbot for commit 97a9354. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Add
effect-codex-app-serverpackage with typed RPC client and migrate Codex provider to app-server protocolpackages/effect-codex-app-serverpackage providing a JSONL-over-stdio RPC client, generated protocol schemas, and structured error types for communicating with the Codex app-server subprocess.CodexProvider.tsto probe provider status by spawning the app-server and querying it via RPC for account, models, and skills, replacing all CLI-based auth parsing and config.toml logic.CodexAdapter.tsto manage per-threadCodexSessionRuntimeShapeinstances directly, streaming typed events into a queue via a per-session fiber, replacingCodexAppServerManagerand its event emitter.CodexSessionRuntime.tsdefining the session runtime interface, options, and schemas consumed by the adapter.Macroscope summarized 97a9354.